From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2444C43217 for ; Mon, 17 Oct 2022 08:37:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbiJQIhu (ORCPT ); Mon, 17 Oct 2022 04:37:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229977AbiJQIhs (ORCPT ); Mon, 17 Oct 2022 04:37:48 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4046363BD for ; Mon, 17 Oct 2022 01:37:47 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id c22so11754996lja.6 for ; Mon, 17 Oct 2022 01:37:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2MOsGrPb54psCQ1QJFpQlc3AIz/KkigbI3AX0l8Zs84=; b=ALxyAy8pzannD55LWKsZcE2utLsNDwHOUKhtiRG/lPNJX0ZLo+si5+UuARQhzt9H16 22lvSJkYyOxakAMB8HOPIHCRTKxLzP9N1xzZKkmPdcOB/brwscylpqqr5X+qChjnzw71 cUVaqJmKi2KcCO6BLWliXqJDSRNdvFk5Y30vj9rF9HtHjhPQioJD8LQzQuy+xeX1vTvZ 2zfW6BZRuv+u2BrNKN8J1XU6dFsKFIobeymG6R92PZK2KMu6WH9Wgyd3BCXSmkL1WpnM oEU3Bw4bVmRefPPrmcjzdwd4mGlMvAG69Qg2ePZzf9XfmPirfSnWA0U4ms69HZV79e3k xJKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2MOsGrPb54psCQ1QJFpQlc3AIz/KkigbI3AX0l8Zs84=; b=U5MJR8QZSByE1LvIQgvDy1srFDcx4yhVfSOqsgyXDWGi4nL62h6frZsn9t/SXoCOLb o+HDF8ryuL0or9zd/8FrzYXrJtYOyHNSjLTwUjpfdvVdiy8h6okgMmqZbyLYeuskZljt K5Q2lQrcff0jayLGXAWHwwHpnvJuXk0QZvqs9iT2+Wm4qW0cOlhrZfva/tUvYoC260hO pN1WwclahmQBLkHQo9jQH/iZBFSO/Kj3g9WrVfgt98MVbqi7e/pYSNiQ97DnGcb9Wr0D acxfRVVRbD7rrjhOZe+8PZNvmmz4f7XMs9DhEN7DlHTKhoak1XtlSHw7qn9uyjYo7NK/ kOcA== X-Gm-Message-State: ACrzQf1QXg7NgRHjPOryvB++sSkFgEz3pWELit2QYanJ+Nky/H8GfzCm ASJw7eaMzzy6ebWCpx8nzKd6JQ== X-Google-Smtp-Source: AMsMyM4GnVMeqPIvzfl5GnZKWItxAUCifHNWN+MyMCMQhIv0vljSHccqiOWHDk4649xEexNvOp+Uyw== X-Received: by 2002:a05:651c:178e:b0:25a:4357:49cd with SMTP id bn14-20020a05651c178e00b0025a435749cdmr3718914ljb.123.1665995865527; Mon, 17 Oct 2022 01:37:45 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id v20-20020a2e9f54000000b0026bca725cd0sm1398961ljk.39.2022.10.17.01.37.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Oct 2022 01:37:45 -0700 (PDT) Message-ID: <726d5096-7997-05d2-d095-a349305607dc@linaro.org> Date: Mon, 17 Oct 2022 11:37:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v5 10/13] gunyah: rsc_mgr: Add resource manager RPC core To: Elliot Berman , Bjorn Andersson Cc: Murali Nalajala , Trilok Soni , Srivatsa Vaddagiri , Carl van Schaik , Prakruthi Deepak Heragu , Andy Gross , Jassi Brar , linux-arm-kernel@lists.infradead.org, Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Jonathan Corbet , Will Deacon , Catalin Marinas , Arnd Bergmann , Greg Kroah-Hartman , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221011000840.289033-1-quic_eberman@quicinc.com> <20221011000840.289033-11-quic_eberman@quicinc.com> <9a42be23-e035-0944-ba62-f6af6b7acc0d@linaro.org> Content-Language: en-GB From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/10/2022 01:32, Elliot Berman wrote: > > > On 10/12/2022 3:52 PM, Dmitry Baryshkov wrote: >> On 11/10/2022 03:08, Elliot Berman wrote >> diff --git >>> +static int gh_msgq_platform_probe_direction(struct platform_device >>> *pdev, >>> +                u8 gh_type, int idx, struct gunyah_resource *ghrsc) >>> +{ >>> +    int ret; >>> +    struct device_node *node = pdev->dev.of_node; >>> + >>> +    ghrsc->type = gh_type; >>> + >>> +    ghrsc->irq = platform_get_irq(pdev, idx); >>> +    if (ghrsc->irq < 0) { >>> +        dev_err(&pdev->dev, "Failed to get irq%d: %d\n", idx, >>> ghrsc->irq); >>> +        return ghrsc->irq; >>> +    } >>> + >>> +    ret = of_property_read_u64_index(node, "reg", idx, &ghrsc->capid); >> >> Is there any reason why can't you use platform_get_resource() here? >> > > These don't show up as resources because size-cells = 0. Hmm, judging from of_device_alloc() / __of_address_to_resource(), the resources should still be created, unless I miss something. -- With best wishes Dmitry