* [PATCH] arm64: dts: rockchip: perfection vop property define for px30
@ 2018-08-29 3:17 Sandy Huang
2018-08-29 12:57 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Sandy Huang @ 2018-08-29 3:17 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Heiko Stuebner, Sandy Huang,
Liang Chen
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Add display ports for display-subsystem and add reset property
for vop node, if missing this two define, drm driver can't
probe sucess.
Signed-off-by: Sandy Huang <hjc-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
---
arch/arm64/boot/dts/rockchip/px30.dtsi | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi
index dc3b22c..b2f1716 100644
--- a/arch/arm64/boot/dts/rockchip/px30.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30.dtsi
@@ -157,6 +157,7 @@
display_subsystem: display-subsystem {
compatible = "rockchip,display-subsystem";
+ ports = <&vopb_out>, <&vopl_out>;
status = "disabled";
};
@@ -795,10 +796,16 @@
clocks = <&cru ACLK_VOPB>, <&cru DCLK_VOPB>,
<&cru HCLK_VOPB>;
clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
+ resets = <&cru SRST_VOPB_A>, <&cru SRST_VOPB_H>, <&cru SRST_VOPB>;
+ reset-names = "axi", "ahb", "dclk";
iommus = <&vopb_mmu>;
power-domains = <&power PX30_PD_VO>;
rockchip,grf = <&grf>;
status = "disabled";
+ vopb_out: port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
};
vopb_mmu: iommu@ff460f00 {
@@ -820,10 +827,16 @@
clocks = <&cru ACLK_VOPL>, <&cru DCLK_VOPL>,
<&cru HCLK_VOPL>;
clock-names = "aclk_vop", "dclk_vop", "hclk_vop";
+ resets = <&cru SRST_VOPL_A>, <&cru SRST_VOPL_H>, <&cru SRST_VOPL>;
+ reset-names = "axi", "ahb", "dclk";
iommus = <&vopl_mmu>;
power-domains = <&power PX30_PD_VO>;
rockchip,grf = <&grf>;
status = "disabled";
+ vopl_out: port {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ };
};
vopl_mmu: iommu@ff470f00 {
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: perfection vop property define for px30
2018-08-29 3:17 [PATCH] arm64: dts: rockchip: perfection vop property define for px30 Sandy Huang
@ 2018-08-29 12:57 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2018-08-29 12:57 UTC (permalink / raw)
To: Sandy Huang
Cc: Rob Herring, Mark Rutland, Liang Chen, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
Am Mittwoch, 29. August 2018, 05:17:13 CEST schrieb Sandy Huang:
> Add display ports for display-subsystem and add reset property
> for vop node, if missing this two define, drm driver can't
> probe sucess.
>
> Signed-off-by: Sandy Huang <hjc@rock-chips.com>
with a bit of cleanup applied for 4.20
Thanks
Heiko
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-29 12:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-29 3:17 [PATCH] arm64: dts: rockchip: perfection vop property define for px30 Sandy Huang
2018-08-29 12:57 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).