From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C362DC83F12 for ; Thu, 31 Aug 2023 11:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345955AbjHaLyu (ORCPT ); Thu, 31 Aug 2023 07:54:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346142AbjHaLyt (ORCPT ); Thu, 31 Aug 2023 07:54:49 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A47B5CFE for ; Thu, 31 Aug 2023 04:54:42 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-99bc9e3cbf1so145144366b.0 for ; Thu, 31 Aug 2023 04:54:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693482881; x=1694087681; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/hD9FTxJbMKacozOlk38SeaYZ8nm15TjXdv4WV8+FzQ=; b=B7kaoMOkhaQEV8+d2OJLv/GMBYNhhr2mkjlrAX91TYhJYJM641006iI6xzluCknU3P zEz/z/zLUJzeWErbWpkeWLuxKP7DVxgSOJNFzq49XT3NFKdumtVa1tJ4NREpzfbQ/G76 5kR5NgvgGyyNoKwnSciQEEywEqQhknhyKlJC6T7hdjJt97QGk9378vmKd+o+KtMzhvzw vX0rnhLTd+Zv6cIprR9iJtCKWuMRuqnUyQcsSghKvBut4vbt1N8XHsxJOZC2dAFOFb3o a6bzBV/mmeN2w4w9WCxaL45HlvE5MEwfMANvCQSus/L2Es757que78Rph5tRFnJ9o3k+ EfZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693482881; x=1694087681; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/hD9FTxJbMKacozOlk38SeaYZ8nm15TjXdv4WV8+FzQ=; b=DMPaDEIMTMvOMuFdGnddJaRFRLtkT7G7HQmGcf9RWBp0BnO/5KUkIf1KRlHQlPgBHO NiBF0+8Ggg9lXHu+d5I8NZibIf35XB79RyPWE1OR4SDrQz8DcRLvBGmGN0gZd+eMX4iT K1ObFE8JhBxxDwxpONfGVQ1Ak71SPmbENh5v0Edz01eniH5C+PaLORa+b/FYnH7Vrpe7 tyEesJhvqZ81c9P4BKEUPQBp0EqdGAbD8clxAvMpKnwgfNSnkhTUmFbkHbsvrNOjAAnW +IkW9RVwN8zTXcovTCIYZuB/7tksC1IAtpBQnD7Iaa++aDpaJQHi7XnOCQFZypODzdaW 20HQ== X-Gm-Message-State: AOJu0Yw1nzoRi0ywpcDyghT+ZR2PtICzijiPqTJXxlb4r0h77WGT0hUO fYChadfwmGkwrU167vq1tPWikw== X-Google-Smtp-Source: AGHT+IEv7SRBdXlCmMcMYVzriOzfH5+6r/nMV6Or12OHswNkE+1axAP7Y6sSExBTWPJjO3FYpjyL4Q== X-Received: by 2002:a17:907:781a:b0:99c:5056:4e31 with SMTP id la26-20020a170907781a00b0099c50564e31mr3138983ejc.15.1693482881101; Thu, 31 Aug 2023 04:54:41 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id k13-20020a17090646cd00b00997e00e78e6sm673645ejs.112.2023.08.31.04.54.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Aug 2023 04:54:40 -0700 (PDT) Message-ID: <728003b9-db27-fdc0-e761-197a02a38c24@linaro.org> Date: Thu, 31 Aug 2023 13:54:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 04/11] arm64: dts: qcom: pm7250b: make SID configurable To: Dmitry Baryshkov , Luca Weiss Cc: cros-qcom-dts-watchers@chromium.org, Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Srinivas Kandagatla , Linus Walleij , "Rafael J. Wysocki" , Viresh Kumar , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org References: <20230830-fp5-initial-v1-0-5a954519bbad@fairphone.com> <20230830-fp5-initial-v1-4-5a954519bbad@fairphone.com> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 31/08/2023 13:33, Dmitry Baryshkov wrote: > On Thu, 31 Aug 2023 at 13:13, Luca Weiss wrote: >> >> On Wed Aug 30, 2023 at 12:06 PM CEST, Krzysztof Kozlowski wrote: >>> On 30/08/2023 11:58, Luca Weiss wrote: >>>> Like other Qualcomm PMICs the PM7250B can be used on different addresses >>>> on the SPMI bus. Use similar defines like the PMK8350 to make this >>>> possible. >>>> >>>> Signed-off-by: Luca Weiss >>>> --- >>>> arch/arm64/boot/dts/qcom/pm7250b.dtsi | 23 ++++++++++++++++------- >>>> 1 file changed, 16 insertions(+), 7 deletions(-) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/pm7250b.dtsi b/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>> index e8540c36bd99..3514de536baa 100644 >>>> --- a/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/pm7250b.dtsi >>>> @@ -7,6 +7,15 @@ >>>> #include >>>> #include >>>> >>>> +/* This PMIC can be configured to be at different SIDs */ >>>> +#ifndef PM7250B_SID >>>> + #define PM7250B_SID 2 >>>> +#endif >>> >>> Why do you send the same patch as v1, without any reference to previous >>> discussions? >>> >>> You got here feedback already. >>> >>> https://lore.kernel.org/linux-arm-msm/f52524da-719b-790f-ad2c-0c3f313d9fe9@linaro.org/ >> >> Hi Krzysztof, >> >> I did mention that original patch in the cover letter of this series. >> I'm definitely aware of the discussion earlier this year there but also >> tried to get an update lately if there's any update with no response. > > I think the overall consensus was that my proposal is too complicated > for the DT files. I proposed to duplicate the entries. Do you keep QUP nodes in DTSI and customize per address? No. I definitely do not agree to these ifndef->define. Maybe using just define would work (so drop ifndef->define), because this makes it obvious and fail-safe if included in wrong place... except that it is still not the define we expect. This is not the coding style present in other DTSes. The true problem how these SPMI bindings were created. Requiring SID address in every child is clearly redundant and I think we do not follow such approach anywhere else. Best regards, Krzysztof