From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562D7C77B7D for ; Tue, 18 Apr 2023 16:34:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232532AbjDRQe2 (ORCPT ); Tue, 18 Apr 2023 12:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231769AbjDRQe0 (ORCPT ); Tue, 18 Apr 2023 12:34:26 -0400 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B92EC64B for ; Tue, 18 Apr 2023 09:34:25 -0700 (PDT) Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-504eac2f0b2so5649391a12.3 for ; Tue, 18 Apr 2023 09:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681835664; x=1684427664; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6oIFKPLBODqM+PzUpjfAu1hIVbXjOylONsSo47WP2F8=; b=pjq7HLfctmKkroWFE6ViMBK8oK0QM+Dh9Nz2t/No92ziYsQJJyn9N2s3SiTD/84OvA 8Gm27mPBoJJLqxA5LsAy4Yn75sAecBfx+CTtayUZgeweFyZoaCaWh/3aDTtDnXFWp4G6 xZq5hzNoClRLEiZ83jAoI0xY7b3shpYhbvbiyEe7cm6D7bsdE8kzs/YGvly2nX6DfNgY 0vJ93LSY7INJzRiVLVNqTBx0npmTwE6oIFXmDeSZtKGd7+rfrJC2aCVFqYz2lT7qX/bR v9qSseoAlMOhII6EUAB8nAlWMB6fRPNXBtnCn7PGFKaQeVC0uce5lY/5k+DREKQbFknO zZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681835664; x=1684427664; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6oIFKPLBODqM+PzUpjfAu1hIVbXjOylONsSo47WP2F8=; b=HK+1vHAEjaKUCRrrmGAxikyHEPDsT9DKJM0WLRzmjDPYAZVBtlXfa+9mcrqaHmjVGw /9sgkJif0ln8R3UrmUdQmgcf9PyHrDUrnmHTp4AixJqUN+9xBp9/lRrl+FuWfeqOh9rc RQUcOBfL3kJum1QZZE2dOZ7gXIGnFgx9YQNRjo9ju8O1x0WlOoql/u6oXR8mVKggo/lP vtye0mItIDfKO0J5jvdC3Bd+LjBYWEjb5iw1WftOwcE7UP9TtrQM5L1HMReNFFzyIYhE aFnGZlcUo24M4AnGIA6V/4emKfA0D7PQeKfDF5MEFpgcisJ+1W87eF7sR8MmwpHWugEm 511Q== X-Gm-Message-State: AAQBX9eXzLK0fRj4tQYNJy0ofCjfhAaLznqP8gO5TAVyknDblFvyHBB+ 0/orFYTCFU8ReSCHfxaNTp7omQ== X-Google-Smtp-Source: AKy350ZcGdS2ld20+tmquecSTNC8TNwlZQjxvSvV7h1YVX7Os4BwdWf2HH4O46iq+Y71LeJq0rjquw== X-Received: by 2002:a05:6402:150f:b0:504:a2e5:d951 with SMTP id f15-20020a056402150f00b00504a2e5d951mr2683856edw.13.1681835663796; Tue, 18 Apr 2023 09:34:23 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:a276:7d35:5226:1c77? ([2a02:810d:15c0:828:a276:7d35:5226:1c77]) by smtp.gmail.com with ESMTPSA id y2-20020aa7ccc2000000b004c2158e87e6sm7124039edt.97.2023.04.18.09.34.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 09:34:23 -0700 (PDT) Message-ID: <72d5b078-da9e-ccbb-1557-9cacaea68e8d@linaro.org> Date: Tue, 18 Apr 2023 18:34:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 2/2] iio: light: Add support for TI OPT4001 light sensor Content-Language: en-US To: Stefan Windfeldt-Prytz , Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com References: <20230323-add-opt4001-driver-v1-0-1451dcc1bc8a@axis.com> <20230323-add-opt4001-driver-v1-2-1451dcc1bc8a@axis.com> From: Krzysztof Kozlowski In-Reply-To: <20230323-add-opt4001-driver-v1-2-1451dcc1bc8a@axis.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/04/2023 11:07, Stefan Windfeldt-Prytz wrote: > This driver uses the continuous mode of the chip and integration > time can be configured through sysfs. > The constants for calculating lux value differs between packaging > so it uses different compatible string for the two versions > "ti,opt4001-picostar" and "ti,opt4001-sot-5x3" since the device id > is the same. Thank you for your patch. There is something to discuss/improve. > + > + indio_dev->channels = opt4001_channels; > + indio_dev->num_channels = ARRAY_SIZE(opt4001_channels); > + indio_dev->modes = INDIO_DIRECT_MODE; > + indio_dev->name = chip->client->name; > + > + of_id = of_match_device(of_match_ptr(opt4001_of_match), &client->dev); ? Drop of_match_ptr > + chip->package_constants = of_id->data; > + > + ret = opt4001_load_defaults(chip); > + if (ret < 0) > + return dev_err_probe(&client->dev, ret, > + "Failed to set sensor defaults\n"); > + > + return devm_iio_device_register(&client->dev, indio_dev); > +} > + > +static void opt4001_remove(struct i2c_client *client) > +{ > + struct iio_dev *indio_dev = i2c_get_clientdata(client); > + struct opt4001_chip *chip = iio_priv(indio_dev); > + > + opt4001_power_down(chip); > +} > + > +static struct i2c_driver opt4001_driver = { > + .driver = { > + .name = "opt4001", > + .of_match_table = of_match_ptr(opt4001_of_match), This should sparkle some warnings. Drop of_match_ptr(). Best regards, Krzysztof