From: Guenter Roeck <linux@roeck-us.net>
To: Luca Ceresoli <luca@lucaceresoli.net>, linux-kernel@vger.kernel.org
Cc: linux-rtc@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Chiwoong Byun <woong.byun@samsung.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v5 7/9] watchdog: max77620: add support for the max77714 variant
Date: Tue, 21 Dec 2021 07:06:04 -0800 [thread overview]
Message-ID: <72d7d229-75da-603d-0b71-46db8e32af2b@roeck-us.net> (raw)
In-Reply-To: <20211211203432.32446-1-luca@lucaceresoli.net>
On 12/11/21 12:34 PM, Luca Ceresoli wrote:
> The MAX77714 is a MFD chip whose watchdog has the same programming
> procedures as the MAX77620 watchdog, but most register offsets and bit
> masks are different, as well as some features.
>
> Support the MAX77714 watchdog by adding a variant description table holding
> the differences.
>
> All the features implemented by this driver are available on the MAX77714
> except for the lack of a WDTOFFC bit. Instead of using a "HAS_*" flag we
> handle this by holding in the cnfg_glbl2_cfg_bits struct field the bits
> (i.e. the features) to enable in the CNFG_GLBL2 register. These bits differ
> among the two models. This implementation allows to avoid any conditional
> code, keeping the execution flow unchanged.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2021-12-21 15:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-11 17:59 [PATCH v5 0/9] Add MAX77714 PMIC minimal driver (RTC and watchdog only) Luca Ceresoli
2021-12-11 17:59 ` [PATCH v5 1/9] rtc: max77686: convert comments to kernel-doc format Luca Ceresoli
2021-12-11 17:59 ` [PATCH v5 2/9] rtc: max77686: rename day-of-month defines Luca Ceresoli
2021-12-11 17:59 ` [PATCH v5 3/9] rtc: max77686: remove unused code to read in 12-hour mode Luca Ceresoli
2021-12-11 17:59 ` [PATCH v5 4/9] dt-bindings: mfd: add Maxim MAX77714 PMIC Luca Ceresoli
2021-12-11 17:59 ` [PATCH v5 5/9] mfd: max77714: Add driver for " Luca Ceresoli
2021-12-21 9:29 ` Lee Jones
2021-12-21 9:38 ` Luca Ceresoli
2021-12-11 17:59 ` [PATCH v5 6/9] watchdog: Kconfig: fix help text indentation Luca Ceresoli
2021-12-11 20:34 ` [PATCH v5 7/9] watchdog: max77620: add support for the max77714 variant Luca Ceresoli
2021-12-11 20:34 ` [PATCH v5 8/9] watchdog: max77620: add comment to clarify set_timeout procedure Luca Ceresoli
2021-12-21 15:06 ` Guenter Roeck
2021-12-11 20:34 ` [PATCH v5 9/9] rtc: max77686: add MAX77714 support Luca Ceresoli
2021-12-21 15:06 ` Guenter Roeck [this message]
2022-01-11 10:10 ` [PATCH v5 0/9] Add MAX77714 PMIC minimal driver (RTC and watchdog only) Luca Ceresoli
2022-01-29 8:40 ` Luca Ceresoli
2022-01-30 1:48 ` Guenter Roeck
2022-01-30 12:45 ` Luca Ceresoli
2022-01-30 16:00 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d7d229-75da-603d-0b71-46db8e32af2b@roeck-us.net \
--to=linux@roeck-us.net \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@canonical.com \
--cc=ldewangan@nvidia.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=luca@lucaceresoli.net \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=woong.byun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox