From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-03.galae.net (smtpout-03.galae.net [185.246.85.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 453E530DED0 for ; Tue, 14 Oct 2025 07:14:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.85.4 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760426045; cv=none; b=LBYFZicPGdzTqCPW8unHzhCWtAt9F5Hjwj7Aljt4rKr3Gfk5fzRL5GkVEf5zYKmKPOq515dZEtJja2mUPCiuuD7JPbucLeOa2Jdi5E2C3zg1ackpkg9+o5hYgb5j9VS4DcdWY78joQ6pKp2bxw0LET29UFxUlDzhZMpPf/wxDLw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760426045; c=relaxed/simple; bh=ofrRWHTc0iq5SR+suJzAIcoxSg/tlD3mx3P7zHJZZBo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WXEMlDPfd9RtuTqntWhZx3bIPo21tSQqw+q8Kw2/zEyngYjrjwAkUB/5XVJeFO0/uF+JX0915K9cUxeOr7Bi3tYiX/dKoysjBTBXpClo2U8ys9Xzjlu4p416dLPod4LTej2LStNqcJKmBe6FDKBFc9dSGzkuIxeT03UYe12RoDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=ZZvdEf6I; arc=none smtp.client-ip=185.246.85.4 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="ZZvdEf6I" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-03.galae.net (Postfix) with ESMTPS id 3977B4E41080; Tue, 14 Oct 2025 07:14:00 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 09945606EC; Tue, 14 Oct 2025 07:14:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id B48C7102F224B; Tue, 14 Oct 2025 09:13:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1760426038; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=1rQPGkIVi3ODkc5CC6srqTaTWUcBBf3OLgjQBFg0e8Q=; b=ZZvdEf6IsnbwHKU53mCP/OJVvqaMjPPYJ6LVInAyhJAnoY5WHLT0aiiBaULt3scVtTDLfT MrlZ2yAeFbtlptpU58fw1BkWZsNgWzGhTJ53QT8KpCGw2yl/YYNSD3Q3ufDZmne+1ywRl5 +7gNdp6rf94tvaKq84k92Xn+G5h3/XhB46xtaTO8T9w0Ln60XmksgF7Zne+VIN0SHmaltX Lm1J8uJKhiwBAJqKn7WReaj1cst9KJkCySbLwSdL0TEiEPXatY3WzkjuFpipKViGtJ+T1E NAcTO+x1RMvIk/TYApPpC2NoR5ozDBKtwvAZuoI/B9y6QBNHphj6Q6YLHYrMmQ== Message-ID: <72d9b0f3-da27-4e30-b07b-d85be23b1407@bootlin.com> Date: Tue, 14 Oct 2025 09:13:43 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 14/15] dt-bindings: mtd: sunxi: Add H616 compatible To: Conor Dooley Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Wentao Liang , Johan Hovold , Maxime Ripard , Thomas Petazzoni , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org References: <20251013152645.1119308-1-richard.genoud@bootlin.com> <20251013152645.1119308-15-richard.genoud@bootlin.com> <20251013-parrot-sandpaper-4e31d2d1a6b3@spud> From: Richard GENOUD Content-Language: en-US, fr Organization: Bootlin In-Reply-To: <20251013-parrot-sandpaper-4e31d2d1a6b3@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Le 13/10/2025 à 21:44, Conor Dooley a écrit : > On Mon, Oct 13, 2025 at 05:26:44PM +0200, Richard Genoud wrote: >> The H616 NAND controller is quite different from the A10 and A23 ones, >> some registers offset changed, and some new one are introduced. >> Also, the DMA handling is different (it uses chained descriptors) >> >> So, introduce a new compatible to represent this version of the IP. >> >> Signed-off-by: Richard Genoud >> --- >> .../mtd/allwinner,sun4i-a10-nand.yaml | 57 ++++++++++++++++--- >> 1 file changed, 48 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mtd/allwinner,sun4i-a10-nand.yaml b/Documentation/devicetree/bindings/mtd/allwinner,sun4i-a10-nand.yaml >> index 054b6b8bf9b9..4b82de9fae17 100644 >> --- a/Documentation/devicetree/bindings/mtd/allwinner,sun4i-a10-nand.yaml >> +++ b/Documentation/devicetree/bindings/mtd/allwinner,sun4i-a10-nand.yaml >> @@ -6,9 +6,6 @@ $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> title: Allwinner A10 NAND Controller >> >> -allOf: >> - - $ref: nand-controller.yaml >> - >> maintainers: >> - Chen-Yu Tsai >> - Maxime Ripard >> @@ -18,6 +15,8 @@ properties: >> enum: >> - allwinner,sun4i-a10-nand >> - allwinner,sun8i-a23-nand-controller >> + - allwinner,sun50i-h616-nand-controller >> + >> reg: >> maxItems: 1 >> >> @@ -25,14 +24,12 @@ properties: >> maxItems: 1 >> >> clocks: >> - items: >> - - description: Bus Clock >> - - description: Module Clock >> + minItems: 2 >> + maxItems: 4 >> >> clock-names: >> - items: >> - - const: ahb >> - - const: mod >> + minItems: 2 >> + maxItems: 4 > > The clock descriptions and names should remain out here, with your new > min/max constraints, since they're identical at indices 0 and 1 to for > both types of device. The if/then should only set the min to 4 for the > new device and the max to 2 for the existing ones. Indeed. Thanks! > > Cheers, > Conor. > > pw-bot: changes-requested > >> >> resets: >> maxItems: 1 >> @@ -85,6 +82,48 @@ required: >> >> unevaluatedProperties: false >> >> +allOf: >> + - $ref: nand-controller.yaml >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - allwinner,sun4i-a10-nand >> + - allwinner,sun8i-a23-nand-controller >> + then: >> + properties: >> + clocks: >> + items: >> + - description: Bus Clock >> + - description: Module Clock >> + clock-names: >> + items: >> + - const: ahb >> + - const: mod >> + >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - allwinner,sun50i-h616-nand-controller >> + then: >> + properties: >> + clocks: >> + items: >> + - description: Bus Clock >> + - description: Module Clock >> + - description: ECC Clock >> + - description: MBus Clock >> + clock-names: >> + items: >> + - const: ahb >> + - const: mod >> + - const: ecc >> + - const: mbus >> + >> examples: >> - | >> #include -- Richard Genoud, Bootlin Embedded Linux and Kernel engineering https://bootlin.com