devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrea Collamati <andrea.collamati@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
	Jonathan Cameron <jic23@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	William Breathitt Gray <william.gray@linaro.org>,
	Angelo Dureghello <angelo.dureghello@timesys.com>,
	Fabio Estevam <festevam@gmail.com>,
	Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] add mcp4728 I2C DAC driver​
Date: Mon, 17 Jul 2023 14:23:26 +0200	[thread overview]
Message-ID: <72df284b-66dd-2deb-13c2-cc0c9f4105cb@gmail.com> (raw)
In-Reply-To: <46bccbca-1343-aed4-4dfe-eb5182b8f6a1@linaro.org>

On 7/17/23 09:17, Krzysztof Kozlowski wrote:
>>> Shouldn't this binding be just merged with existing mcp4725? Are you
>>> sure it's not similar device, IOW, are you sure you do not have vref supply?
>>>
>> Unfortunately they are not that similar. MCP4728 has two vref choices:
>>
>> - Use Vdd (power supply) as Vref
>>
>> - User Internal 2.048 V Vref source.
> Exactly the same as existing mcp4726, so what is the problem?

MCP4726 has 2 separate pins, VDD and VREF that can be both used as external Vref depending on configuration.

MCP4728 has only one external vref pin, VDD pin. The other vref source is internal and fixed to 2.048V.

Furthermore MCP4728  has four independent channels. For each channels it's possible to choose whether

using VDD (External VRef) or 2.048V (Internal Vref).

Best regards

            Andrea



  reply	other threads:[~2023-07-17 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-16 21:26 [PATCH v2 0/2] add mcp4728 I2C DAC driver​ Andrea Collamati
2023-07-17  7:17 ` Krzysztof Kozlowski
2023-07-17 12:23   ` Andrea Collamati [this message]
2023-07-17 15:03     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=72df284b-66dd-2deb-13c2-cc0c9f4105cb@gmail.com \
    --to=andrea.collamati@gmail.com \
    --cc=angelo.dureghello@timesys.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=william.gray@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).