From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sandipan Patra <spatra@nvidia.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Bibek Basu <bbasu@nvidia.com>,
Krishna Yarlagadda <kyarlagadda@nvidia.com>
Subject: Re: [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for Tegra234
Date: Fri, 9 Sep 2022 14:57:06 +0200 [thread overview]
Message-ID: <72ed9df4-4bec-b9e5-c14d-3e998d83a102@linaro.org> (raw)
In-Reply-To: <DM5PR12MB16283364646CBD853C89B425AD439@DM5PR12MB1628.namprd12.prod.outlook.com>
On 09/09/2022 13:17, Sandipan Patra wrote:
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: Thursday, September 8, 2022 5:44 PM
>> To: Sandipan Patra <spatra@nvidia.com>; thierry.reding@gmail.com;
>> Jonathan Hunter <jonathanh@nvidia.com>; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; linux-
>> tegra@vger.kernel.org; linux-kernel@vger.kernel.org
>> Cc: Bibek Basu <bbasu@nvidia.com>; Krishna Yarlagadda
>> <kyarlagadda@nvidia.com>
>> Subject: Re: [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for
>> Tegra234
>>
>> External email: Use caution opening links or attachments
>>
>>
>> On 07/09/2022 08:25, Sandipan Patra wrote:
>>> Tegra234 has 8 different PWM controllers and each controller has only
>>> one output. Add a device tree compatible string for Tegra234.
>>>
>>> Signed-off-by: Sandipan Patra <spatra@nvidia.com>
>>> ---
>>> Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
>>> b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
>>> index 74c41e34c3b6..331c1e66e8fa 100644
>>> --- a/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
>>> +++ b/Documentation/devicetree/bindings/pwm/nvidia,tegra20-pwm.txt
>>> @@ -9,7 +9,7 @@ Required properties:
>>> - "nvidia,tegra132-pwm", "nvidia,tegra20-pwm": for Tegra132
>>> - "nvidia,tegra210-pwm", "nvidia,tegra20-pwm": for Tegra210
>>> - "nvidia,tegra186-pwm": for Tegra186
>>> - - "nvidia,tegra194-pwm": for Tegra194
>>> + - "nvidia,tegra194-pwm": for Tegra194, Tegra234
>>
>> The commit msg suggest it is different. Are you sure they are exactly the
>> same? If not the same, but compatible, you should use fallback.
>
> Tegra194 and Tegra234 are 2 different chips using exactly same pwm module and dt node.
> This change is to convey that same compatible is used for Tegra234 as well.
Then recommended is to have Tegra234 specific compatible with fallback
to 194.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-09-09 12:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-07 6:25 [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for Tegra234 Sandipan Patra
2022-09-07 6:25 ` [PATCH 2/3] arm64: tegra: Add PWM controllers on Tegra234 Sandipan Patra
2022-09-07 6:25 ` [PATCH 3/3] arm64: tegra: Add user PWM support on Jetson Orin Sandipan Patra
2022-09-08 12:13 ` [PATCH 1/3] dt-bindings: pwm: tegra: Add compatible string for Tegra234 Krzysztof Kozlowski
2022-09-09 11:17 ` Sandipan Patra
2022-09-09 12:57 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72ed9df4-4bec-b9e5-c14d-3e998d83a102@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bbasu@nvidia.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kyarlagadda@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=spatra@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).