From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bryan O'Donoghue <bod@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v8 02/18] dt-bindings: media: qcom,x1e80100-camss: Convert from inline PHY definitions to PHY handles
Date: Thu, 26 Feb 2026 10:50:24 +0100 [thread overview]
Message-ID: <72f0ed74-ac86-4571-8a72-d41282349718@kernel.org> (raw)
In-Reply-To: <c2d9742c-3d82-4340-a11b-16370bcad5ea@kernel.org>
On 26/02/2026 10:40, Bryan O'Donoghue wrote:
> On 26/02/2026 09:33, Krzysztof Kozlowski wrote:
>> On 26/02/2026 10:27, Bryan O'Donoghue wrote:
>>> On 26/02/2026 07:07, Krzysztof Kozlowski wrote:
>>>> No, it does not allow that. You cannto change the ABI.
>>>>
>>>> That's why I reminded multiple times before reviewing new CAMSS bindings
>>>> for Milos and something more. Because once it gets accepted, you cannot
>>>> change it anymore without valid reason. And there is no valid reason
>>>> here provided. I kept these patches in staging/waiting for long
>>>> enough...
>>>
>>> I thought your policy was - a dtsi had to have it, which we don't yet have.
>>
>> And from where did you take that policy? I am pretty sure my each
>> comment is about ABI. Heh, I even commented few times about implied ABI
>> purely based on kernel, without DTS.
>
> Correct me if I'm wrong. I thought we had discussed either @ the Linaro
> Dublin meet or the Linaro Amsterdam meet that changing upstream YAML
> would be feasible _if_ you could show there was no dependency on it -
> say u-boot, FreeBSD etc.
And I mentioned multiple caveats and restrictions. Do you quote them
here or just took the first part of sentence before ", but only ..."?
Anyway, whatever spoken is improvable and I am sure I did not give such
permissions, maybe except that Dublin meeting was in 2024 thus before
the release of previous user, so before v6.16, so of course you can
still reshape unreleased ABI. And then you released it closing the
discussion.
>
> I completely understand why you'd say for a UART definition its an ABI
> since quite likely another OS might consume the YAML but, I also think
> nobody but upstream Linux cares about this binding at all and our only
> actual user is upstream dtsi in Linux, which doesn't exist yet.
Half of the comments responding to DT maintainers are "but no one
cares". Well, I do care, so that's it. If I start analyzing each case
for possible exceptions I would spend too much time on it. So follow
documented and expressed in written rules.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-26 9:50 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 15:11 [PATCH v8 00/18] Add dt-bindings and dtsi changes for CAMSS on x1e80100 silicon Bryan O'Donoghue
2026-02-25 15:11 ` [PATCH v8 01/18] dt-bindings: media: qcom,x1e80100-camss: Assign correct main register bank to first address Bryan O'Donoghue
2026-02-26 7:04 ` Krzysztof Kozlowski
2026-02-26 9:25 ` Bryan O'Donoghue
2026-02-26 9:32 ` Krzysztof Kozlowski
2026-02-26 9:35 ` Bryan O'Donoghue
2026-02-26 9:38 ` Krzysztof Kozlowski
2026-02-26 9:49 ` Bryan O'Donoghue
2026-02-27 22:01 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 02/18] dt-bindings: media: qcom,x1e80100-camss: Convert from inline PHY definitions to PHY handles Bryan O'Donoghue
2026-02-26 7:07 ` Krzysztof Kozlowski
2026-02-26 9:27 ` Bryan O'Donoghue
2026-02-26 9:33 ` Krzysztof Kozlowski
2026-02-26 9:40 ` Bryan O'Donoghue
2026-02-26 9:50 ` Krzysztof Kozlowski [this message]
2026-02-26 10:06 ` Bryan O'Donoghue
2026-02-27 7:24 ` Krzysztof Kozlowski
2026-02-27 8:48 ` Bryan O'Donoghue
2026-02-27 20:10 ` Dmitry Baryshkov
2026-02-27 21:49 ` Bryan O'Donoghue
2026-02-27 22:01 ` Christopher Obbard
2026-02-28 13:28 ` Krzysztof Kozlowski
2026-02-25 15:11 ` [PATCH v8 03/18] dt-bindings: media: qcom,x1e80100-camss: Add support for combo-mode endpoints Bryan O'Donoghue
2026-02-27 22:01 ` Christopher Obbard
2026-02-28 7:17 ` Dmitry Baryshkov
2026-03-04 4:38 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 04/18] dt-bindings: media: qcom,x1e80100-camss: Reduce iommus to five Bryan O'Donoghue
2026-02-26 7:08 ` Krzysztof Kozlowski
2026-02-27 22:02 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 05/18] media: qcom: camss: Add legacy_phy flag to SoC definition structures Bryan O'Donoghue
2026-02-27 22:02 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 06/18] media: qcom: camss: Add support for PHY API devices Bryan O'Donoghue
2026-02-27 22:03 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 07/18] media: qcom: camss: Drop legacy PHY descriptions from x1e Bryan O'Donoghue
2026-02-27 22:03 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 08/18] arm64: dts: qcom: x1e80100: Add CAMCC block definition Bryan O'Donoghue
2026-02-27 22:03 ` Christopher Obbard
2026-03-02 16:19 ` Konrad Dybcio
2026-03-03 5:56 ` Taniya Das
2026-03-03 10:05 ` Konrad Dybcio
2026-02-25 15:11 ` [PATCH v8 09/18] arm64: dts: qcom: x1e80100: Add CCI definitions Bryan O'Donoghue
2026-02-27 22:04 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 10/18] arm64: dts: qcom: x1e80100: Add MIPI CSI PHY nodes Bryan O'Donoghue
2026-02-26 7:11 ` Krzysztof Kozlowski
2026-02-26 9:30 ` Bryan O'Donoghue
2026-02-26 9:35 ` Krzysztof Kozlowski
2026-02-27 22:04 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 11/18] arm64: dts: qcom: x1e80100: Add CAMSS block definition Bryan O'Donoghue
2026-02-27 22:05 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 12/18] arm64: dts: qcom: x1e80100-crd: Add pm8010 CRD pmic,id=m regulators Bryan O'Donoghue
2026-02-27 22:05 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 13/18] arm64: dts: qcom: x1e80100-crd: Add ov08x40 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-02-27 22:06 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 14/18] arm64: dts: qcom: x1e80100-t14s: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2026-02-25 15:11 ` [PATCH v8 15/18] arm64: dts: qcom: x1e80100-t14s: Add on ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-02-27 22:08 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 16/18] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add pm8010 camera PMIC with voltage levels for IR and RGB camera Bryan O'Donoghue
2026-02-27 22:08 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 17/18] arm64: dts: qcom: x1e80100-lenovo-yoga-slim7x: Add ov02c10 RGB sensor on CSIPHY4 Bryan O'Donoghue
2026-02-27 22:08 ` Christopher Obbard
2026-02-25 15:11 ` [PATCH v8 18/18] arm64: dts: qcom: x1e80100-dell-inspiron14-7441: Switch on CAMSS RGB sensor Bryan O'Donoghue
2026-02-27 22:09 ` Christopher Obbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72f0ed74-ac86-4571-8a72-d41282349718@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bod@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mturquette@baylibre.com \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=todor.too@gmail.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox