Re: [PATCH v2 4/6] arm64: dts: rockchip: add px30-cobra base dtsi and board variants

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Heiko,

On 5/13/25 5:02 PM, Heiko Stuebner wrote:

[...]

> +	rk809: pmic@20 {
> +		compatible = "rockchip,rk809";
> +		reg = <0x20>;
> +		#clock-cells = <0>;
> +		clock-output-names = "xin32k";
> +		interrupt-parent = <&gpio0>;
> +		interrupts = <RK_PA7 IRQ_TYPE_LEVEL_LOW>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&pmic_int>;
> +		wakeup-source;
> +		system-power-controller;

Please order the properties alphabetically, system-power-controller is 
not where it should be.

[...]

> +	panel {
> +		dsp_rst: dsp-rst {
> +			rockchip,pins =
> +				<0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>;
> +		};
> +

I would actually have a pull down here to hold the display in reset 
until the driver is probed and goes through the reset procedure?

With the two above done:

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin