From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23761CA9EC0 for ; Mon, 28 Oct 2019 11:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 022C921721 for ; Mon, 28 Oct 2019 11:11:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726332AbfJ1LLC (ORCPT ); Mon, 28 Oct 2019 07:11:02 -0400 Received: from mail-sh.amlogic.com ([58.32.228.43]:8678 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725776AbfJ1LLC (ORCPT ); Mon, 28 Oct 2019 07:11:02 -0400 Received: from [10.18.29.227] (10.18.29.227) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1591.10; Mon, 28 Oct 2019 19:11:13 +0800 Subject: Re: [PATCH RESEND v2 1/4] dt-bindings: power: add Amlogic secure power domains bindings To: Rob Herring CC: Kevin Hilman , "open list:ARM/Amlogic Meson..." , Neil Armstrong , Jerome Brunet , Martin Blumenstingl , "open list:THERMAL" , "linux-kernel@vger.kernel.org" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , , Jian Hu , Hanjie Lin , Victor Wan , Xingyu Chen References: <1570695678-42623-1-git-send-email-jianxin.pan@amlogic.com> <1570695678-42623-2-git-send-email-jianxin.pan@amlogic.com> <20191014173900.GA6886@bogus> <622c7785-8254-5473-6b35-7287830f3c60@amlogic.com> From: Jianxin Pan Message-ID: <730e5611-6dc0-5bf0-0489-4091bda18c9e@amlogic.com> Date: Mon, 28 Oct 2019 19:11:13 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.227] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On 2019/10/26 4:19, Rob Herring wrote: > On Wed, Oct 16, 2019 at 6:26 AM Jianxin Pan wrote: >> >> Hi Rob, >> >> On 2019/10/15 1:39, Rob Herring wrote: >>> On Thu, Oct 10, 2019 at 04:21:15AM -0400, Jianxin Pan wrote: >>>> Add the bindings for the Amlogic Secure power domains, controlling the >>>> secure power domains. >>>> >>>> The bindings targets the Amlogic A1 and C1 compatible SoCs, in which the >>>> power domain registers are in secure world. >>>> >>>> Signed-off-by: Jianxin Pan >>>> --- >>>> .../bindings/power/amlogic,meson-sec-pwrc.yaml | 42 ++++++++++++++++++++++ >>>> include/dt-bindings/power/meson-a1-power.h | 32 +++++++++++++++++ >>>> 2 files changed, 74 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/power/amlogic,meson-sec-pwrc.yaml >>>> + >>>> + secure-monitor: >>>> + description: phandle to the secure-monitor node >>>> + $ref: /schemas/types.yaml#/definitions/phandle >>> >>> Why not just a child node of this node? >>> >> Thanks for the review. >> >> I followed the style of the previous series of meson： >> >> 46 efuse: efuse { >> 47 compatible = "amlogic,meson-gxbb-efuse"; >> 48 clocks = <&clkc CLKID_EFUSE>; >> 49 #address-cells = <1>; >> 50 #size-cells = <1>; >> 51 read-only; >> 52 secure-monitor = <&sm>; >> 53 }; > > Looks like that was not reviewed by me and is only in linux-next. > Please make functions exposed by secure world a child of the secure > firmware node. > > Really for power domains, you only need to add a '#power-domain-cells' > property to the secure monitor node. > OK, I will update them in the next version. Thanks for the review. > Rob > > . >