From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Bharat Bhushan <bbhushan2@marvell.com>,
"wim@linux-watchdog.org" <wim@linux-watchdog.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [EXT] Re: [PATCH 1/2 v5] dt-bindings: watchdog: marvell GTI system watchdog driver
Date: Fri, 5 May 2023 12:57:04 +0200 [thread overview]
Message-ID: <731e99e6-9e48-8f80-7f95-ec8d23a85252@linaro.org> (raw)
In-Reply-To: <DM5PR1801MB1883479AE3CE111B5FC3E5C8E3729@DM5PR1801MB1883.namprd18.prod.outlook.com>
On 05/05/2023 12:41, Bharat Bhushan wrote:
>>>>
>>>> You need anyway SoC specific compatibles. Once you add proper
>>>> compatibles, you will see that property is not needed.
>>>
>>> Also on a given soc, firmware can configure one of 64 timer to be used as
>> system watchdog time then compatible will not work.
>>
>> Can't you query the firmware for that? Or can't you just choose first unused
>> timer? DT is for non-discoverable properties.
>
> Query to firmware required arm SMC call, to me that does not look correct approach. Thought of using first one but that is already used and moving that is as same as this.
>
> Hardcoding to 63 will make it work on some SoCs but not all.
But you know which one is started or is not. GTI_CWD_WDOG tells you this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-05-05 10:57 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <linux-kernel@vger.kernel.org, sgoutham@marvell.com>
2023-05-03 12:10 ` [PATCH 1/2 v5] dt-bindings: watchdog: marvell GTI system watchdog driver Bharat Bhushan
2023-05-03 12:10 ` [PATCH 2/2 v5] Watchdog: Add marvell GTI " Bharat Bhushan
2023-05-04 6:56 ` Krzysztof Kozlowski
2023-05-04 6:54 ` [PATCH 1/2 v5] dt-bindings: watchdog: marvell GTI system " Krzysztof Kozlowski
2023-05-04 9:02 ` [EXT] " Bharat Bhushan
2023-05-04 11:07 ` Krzysztof Kozlowski
2023-05-04 17:10 ` Bharat Bhushan
2023-05-05 6:38 ` Krzysztof Kozlowski
2023-05-05 7:17 ` Bharat Bhushan
2023-05-05 10:31 ` Krzysztof Kozlowski
2023-05-05 7:55 ` Bharat Bhushan
2023-05-05 10:33 ` Krzysztof Kozlowski
2023-05-05 10:41 ` Bharat Bhushan
2023-05-05 10:57 ` Krzysztof Kozlowski [this message]
2023-05-05 11:15 ` Bharat Bhushan
2023-05-05 11:57 ` Krzysztof Kozlowski
2023-05-05 12:19 ` Bharat Bhushan
2023-05-05 12:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=731e99e6-9e48-8f80-7f95-ec8d23a85252@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bbhushan2@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).