From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Shawn Anastasio <sanastasio@raptorengineering.com>,
devicetree@vger.kernel.org, lee@kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>
Cc: Timothy Pearson <tpearson@raptorengineering.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT binding
Date: Wed, 11 Oct 2023 20:39:52 +0200 [thread overview]
Message-ID: <732e0da8-0eff-41c2-bfea-b27a708cf8f6@linaro.org> (raw)
In-Reply-To: <75446d81-449d-b8c9-3e1c-2d9ef8d61e28@raptorengineering.com>
On 09/10/2023 23:04, Shawn Anastasio wrote:
>>> +
>>> + leds:
>>> + type: object
>>> + description: Cronos Platform Status LEDs
>>
>> Missing additionalProperties:false... but anyway this is just empty. No
>> resources? Drop the node.
>>
>
> Having nodes for the leds and the watchdog allows the two independent
> functions to be enabled/disabled in the device tree by adding/removing
> the relevant object. Would it be more idiomatic to instead introduce
> properties to the parent sie,cronos-cpld object to toggle these
> functions?
And why DT should be used to enable/disable them? Or are you suggesting
you have different devices under the same compatible?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-11 18:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1696285339.git.sanastasio@raptorengineering.com>
2023-10-02 22:32 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add prefix for SIE Shawn Anastasio
2023-10-03 9:23 ` Krzysztof Kozlowski
2023-10-09 20:54 ` Shawn Anastasio
2023-10-11 18:38 ` Krzysztof Kozlowski
2023-10-02 22:32 ` [PATCH 2/3] dt-bindings: mfd: sie,cronos-cpld: Add initial DT binding Shawn Anastasio
2023-10-02 23:33 ` Rob Herring
2023-10-03 9:22 ` Krzysztof Kozlowski
2023-10-09 21:04 ` Shawn Anastasio
2023-10-11 18:39 ` Krzysztof Kozlowski [this message]
2023-10-02 22:32 ` [PATCH 3/3] mfd: sie-cronos-cpld: Add driver for SIE cronos CPLD Shawn Anastasio
2023-10-05 1:11 ` kernel test robot
2023-10-12 10:24 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=732e0da8-0eff-41c2-bfea-b27a708cf8f6@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sanastasio@raptorengineering.com \
--cc=tpearson@raptorengineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).