From: Liu Ying <victor.liu@nxp.com>
To: Marek Vasut <marex@denx.de>, devicetree@vger.kernel.org
Cc: Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lucas Stach <l.stach@pengutronix.de>,
NXP Linux Team <linux-imx@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: mxsfb: Document i.MX8M power-domains property
Date: Mon, 12 Dec 2022 10:14:01 +0800 [thread overview]
Message-ID: <733ac9d29fc03568e90cbfeb6c1108fc2ddbd597.camel@nxp.com> (raw)
In-Reply-To: <20221211025702.672364-1-marex@denx.de>
Hi Marek,
On Sun, 2022-12-11 at 03:57 +0100, Marek Vasut wrote:
> The power-domains property is mandatory on i.MX8M Mini, Nano, Plus.
> Document the property and mark it as required on the aforementioned
> variants of the IP, present in those SoCs.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: NXP Linux Team <linux-imx@nxp.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: linux-arm-kernel@lists.infradead.org
> To: devicetree@vger.kernel.org
> ---
> .../devicetree/bindings/display/fsl,lcdif.yaml | 14
> ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> index 876015a44a1e6..31847efedd8f9 100644
> --- a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> +++ b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> @@ -52,6 +52,9 @@ properties:
> interrupts:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
> port:
> $ref: /schemas/graph.yaml#/properties/port
> description: The LCDIF output port
> @@ -87,6 +90,17 @@ allOf:
> maxItems: 1
> clock-names:
> maxItems: 1
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
There is a power-domains property in the lcdif node of imx6sl.dtsi, so
care to add '- fsl,imx6sl-lcdif' here too? The patch subject and
commit message need to be updated correspondingly then.
Regards,
Liu Ying
> + - fsl,imx8mm-lcdif
> + - fsl,imx8mn-lcdif
> + - fsl,imx8mp-lcdif
> + then:
> + required:
> + - power-domains
>
> examples:
> - |
prev parent reply other threads:[~2022-12-12 3:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 2:57 [PATCH] dt-bindings: mxsfb: Document i.MX8M power-domains property Marek Vasut
2022-12-11 20:17 ` Krzysztof Kozlowski
2022-12-12 2:14 ` Liu Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=733ac9d29fc03568e90cbfeb6c1108fc2ddbd597.camel@nxp.com \
--to=victor.liu@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).