Re: [PATCH v8 3/3] arm64: dts: qcom: Add hamoa Samsung Galaxy Book4 Edge devicetrees

[Maxim Storetvedt <mstoretv@cern.ch>]

On 9/30/26 23:39, Antheas Kapenekakis wrote:
> On Wed, 30 Sept 2026 at 23:24, Maxim Storetvedt <mstoretv@cern.ch> wrote:
>>
>> +
>> +       /* Still needed until there's a proper driver for type-c controller */
> 
> What happens if you remove it? the device has no pmic-glink and
> registers an invalid driver. Can someone suggest an alternative?

No display/drm and blocks boot shortly after. Not much in dmesg ("failed
to acquire drm_bridge"). Something's not registered/probed(?). Probably
still working over in your dts since its EmuMC driver re-adds what's
missing in the chain.

> 
>> +       pmic-glink {
>> +               compatible = "qcom,x1e80100-pmic-glink",
>> +                            "qcom,sm8550-pmic-glink",
>> +                            "qcom,pmic-glink";
>> +               #address-cells = <1>;
>> +               #size-cells = <0>;
>> +               orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>,
>> +                                   <&tlmm 123 GPIO_ACTIVE_HIGH>;
>> + [...]
>> +&swr0 {
>> +       status = "okay";
>> +
>> +       pinctrl-0 = <&wsa_swr_active>, <&spkr_01_sd_n_active>;
>> +       pinctrl-names = "default";
>> +
>> +       /* WSA8845, Left Woofer */
>> +       left_woofer: speaker@0,0 {
>> +               compatible = "sdw20217020400";
>> +               reg = <0 0>;
>> +               reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
>> +               #sound-dai-cells = <0>;
>> +               sound-name-prefix = "WooferLeft";
>> +               vdd-1p8-supply = <&vreg_l15b_1p8>;
>> +               vdd-io-supply = <&vreg_l12b_1p2>;
>> +               qcom,port-mapping = <1 2 3 7 10 13>;
>> +       };
>> +
>> +       /* WSA8845, Left Tweeter */
>> +       left_tweeter: speaker@0,1 {
>> +               compatible = "sdw20217020400";
>> +               reg = <0 1>;
>> +               reset-gpios = <&lpass_tlmm 12 GPIO_ACTIVE_LOW>;
>> +               #sound-dai-cells = <0>;
>> +               sound-name-prefix = "TweeterLeft";
>> +               vdd-1p8-supply = <&vreg_l15b_1p8>;
>> +               vdd-io-supply = <&vreg_l12b_1p2>;
>> +               qcom,port-mapping = <4 5 6 7 11 13>;
>> +       };
>> +};
> 
> Review the speaker setup and consider moving it to individual dts, my
> devices do not share this setup.
> 

Speakers not tested, so this setup might not apply either. Perhaps
better to remove the nodes for now in that case.

Cheers,
-Max