Re: [PATCH V5 2/3] ARM: dts: add watchdog device nodes for Exynos5250 and Exynos5420

[Tomasz Figa <t.figa@samsung.com>]

Hi Leela,

On Thursday 31 of October 2013 11:30:49 Leela Krishna Amudala wrote:
> Adds watchdog device nodes to the DT device list for Exynos5250 and Exynos5420
> 
> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5.dtsi    |    7 -------
>  arch/arm/boot/dts/exynos5250.dtsi |    7 ++++++-
>  arch/arm/boot/dts/exynos5420.dtsi |   10 ++++++++++
>  3 files changed, 16 insertions(+), 8 deletions(-)
[snip]
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index c4a8662..7e4867f 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -158,9 +158,14 @@
>  		interrupts = <0 47 0>;
>  	};
>  
> -	watchdog {
> +	watchdog@101D0000 {
> +		compatible = "samsung,exynos5250-wdt";
> +		reg = <0x101D0000 0x100>;
> +		interrupts = <0 42 0>;
>  		clocks = <&clock 336>;
>  		clock-names = "watchdog";
> +		samsung,syscon-phandle = <&pmu_syscon>;
> +		status = "okay";

You can drop the status property here, as it's "okay" by default.

>  	};
>  
>  	g2d@10850000 {
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 6ffefd1..8585fe7 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -369,4 +369,14 @@
>  		clock-names = "gscl";
>  		samsung,power-domain = <&gsc_pd>;
>  	};
> +
> +        watchdog@101D0000 {

Is it just my mail client or there is an indentation issue here?

> +		compatible = "samsung,exynos5420-wdt";
> +		reg = <0x101D0000 0x100>;
> +		interrupts = <0 42 0>;
> +		clocks = <&clock 316>;
> +		clock-names = "watchdog";
> +		samsung,syscon-phandle = <&pmu_syscon>;
> +		status = "okay";

Status property can be dropped.

> +        };

Wrong indentation?

Best regards,
Tomasz