From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v14 4/4] CMDQ: save more energy in idle Date: Fri, 30 Sep 2016 11:01:32 +0200 Message-ID: <73a10cdc-6aeb-73be-adcb-0367e2e07824@gmail.com> References: <1473039885-24009-1-git-send-email-hs.liao@mediatek.com> <1473039885-24009-5-git-send-email-hs.liao@mediatek.com> <1474622885.21723.25.camel@mtksdaap41> <1475225766.25044.33.camel@mtksdaap41> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1475225766.25044.33.camel@mtksdaap41> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Horng-Shyang Liao , Jassi Brar Cc: Rob Herring , Daniel Kurtz , Sascha Hauer , Devicetree List , Linux Kernel Mailing List , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org, Sascha Hauer , Philipp Zabel , Nicolas Boichat , CK HU , cawa cheng , Bibby Hsieh , YT Shen , Daoyuan Huang , Damon Chu , Josh-YC Liu , Glory Hung List-Id: devicetree@vger.kernel.org On 09/30/2016 10:56 AM, Horng-Shyang Liao wrote: > On Fri, 2016-09-23 at 17:28 +0800, Horng-Shyang Liao wrote: >> On Thu, 2016-09-22 at 13:22 +0530, Jassi Brar wrote: >>> On Mon, Sep 5, 2016 at 7:14 AM, HS Liao wrote: >>>> Use clk_disable_unprepare instead of clk_disable to save more energy >>>> when CMDQ is idle. >>>> >>>> Signed-off-by: HS Liao >>>> --- >>>> drivers/mailbox/mtk-cmdq.c | 54 +++++++++++++++++++++++++++++++++++++++------- >>> >>> The driver is introduced by second patch of the set, so it makes sense >>> to merge this patch into patch 2/4. >> >> Hi Jassi, >> >> Could you take a look at previous discussion between Matthias and me? >> http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05239.html >> His basic idea is to simplify first working version. >> Therefore, I move some code to this patch. >> Well what I wanted to say is, that right now this driver is quite a big beast and this makes it difficult to review. So my idea was to just submit the most basic version of this driver. Any improvements on the driver should be sent in follow-up patches after the basic driver got merged. That was my idea. Regards, Matthias -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html