devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rong Zhang <i@rong.moe>, Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8974-samsung-klte: Add label on /i2c-gpio-led
Date: Mon, 22 Jan 2024 10:48:02 +0100	[thread overview]
Message-ID: <73d75a74-71db-43c7-935a-65423159ce42@linaro.org> (raw)
In-Reply-To: <20240121154010.168440-2-i@rong.moe>

On 21/01/2024 16:39, Rong Zhang wrote:
> Some variants of klte, e.g., the China edition (kltechn), have minor
> differences to differentiate them from klte. This includes the GPIO pins
> connected to /i2c-gpio-led.
> 
> A label is added on /i2c-gpio-led to allow DT of other variants to
> reference it conveniently. Considering both LEDs and a GPIO expander are
> connected to the node, it is named "i2c_led_gpio".
> 
> Signed-off-by: Rong Zhang <i@rong.moe>
> ---
>  arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> index b93539e2b87e..013946ccda0f 100644
> --- a/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-msm8974pro-samsung-klte.dts
> @@ -77,7 +77,7 @@ touchkey@20 {
>  		};
>  	};
>  
> -	i2c-gpio-led {
> +	i2c_led_gpio: i2c-gpio-led {

This does not make much sense on its own. 6 commit msg lines just to add
a label. Squash it.

Best regards,
Krzysztof


  reply	other threads:[~2024-01-22  9:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-21 15:39 [PATCH 0/4] ARM: dts: qcom: msm8974: Add Samsung Galaxy S5 China support Rong Zhang
2024-01-21 15:39 ` [PATCH 1/4] ARM: dts: qcom: msm8974-samsung-klte: Add label on /i2c-gpio-led Rong Zhang
2024-01-22  9:48   ` Krzysztof Kozlowski [this message]
2024-01-22 14:54     ` Rong Zhang
2024-01-21 15:39 ` [PATCH 2/4] ARM: dts: qcom: msm8974-samsung-klte: Pin brcm,board-type in wifi Rong Zhang
2024-01-21 15:39 ` [PATCH 3/4] dt-bindings: arm: qcom: add Samsung Galaxy S5 China (kltechn) Rong Zhang
2024-01-22  9:47   ` Krzysztof Kozlowski
2024-01-21 15:39 ` [PATCH 4/4] ARM: dts: qcom: msm8974: Add device tree for Samsung Galaxy S5 China Rong Zhang
2024-01-22  9:48   ` Krzysztof Kozlowski
2024-01-22 14:51     ` Rong Zhang
2024-01-22 15:17       ` Krzysztof Kozlowski
2024-01-22 15:27         ` Rong Zhang
2024-01-22 10:50   ` Konrad Dybcio
2024-01-22 14:01     ` Icenowy Zheng
2024-01-22 17:37     ` Rong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73d75a74-71db-43c7-935a-65423159ce42@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=i@rong.moe \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=uwu@icenowy.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).