From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Mark Brown <broonie@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, johan+linaro@kernel.org,
perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com,
ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com,
linux-kernel@vger.kernel.org,
pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT
Date: Wed, 28 Jun 2023 19:57:38 +0300 [thread overview]
Message-ID: <73dce263-bee6-554f-9eb6-af4aa7badab1@linaro.org> (raw)
In-Reply-To: <f71c8d2b-d5f4-42bb-932f-5b9ec6117ffc@sirena.org.uk>
On 28/06/2023 14:53, Mark Brown wrote:
> On Wed, Jun 28, 2023 at 11:26:20AM +0100, Srinivas Kandagatla wrote:
>> Currently firmware file name is autogenerated based on card name and model number,
>> however this imposed a restriction of finding firmware in a single firmware path.
>> Platform specific firmwares are normally located in sub folders of the SoC.
>>
>> Provide more flexibity by reading firmware-name from DT.
>
> Why not try a series of firmware names/locations generated using the
> identifying information for the card/system? That way we don't have to
> put a filename in the ABI which has fun scaling issues.
This is what was done by Srini in the initial (currently committed)
version. Unfortunately this easily results in the audio topology being
separated from the rest of the platform-specific firmware. For example,
for the mentioned X13s we already have a subdir under /lib/firmware/qcom
and several firmware-name DT properties pointing to the files in that
subdir:
$ grep firmware-name
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn";
firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn";
firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn";
This is not unique to the X13s, other Qualcomm boards also use full paths.
--
With best wishes
Dmitry
next prev parent reply other threads:[~2023-06-28 16:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 10:26 [PATCH 0/3] ASoC: qcom: get tplg firmware-name from device tree Srinivas Kandagatla
2023-06-28 10:26 ` [PATCH 1/3] ASoC: dt-bindings: q6apm: add firmware-name bindings Srinivas Kandagatla
2023-06-28 11:18 ` Rob Herring
2023-06-28 15:54 ` Rob Herring
2023-06-28 16:43 ` Srinivas Kandagatla
2023-06-28 10:26 ` [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT Srinivas Kandagatla
2023-06-28 11:53 ` Mark Brown
2023-06-28 16:30 ` Srinivas Kandagatla
2023-06-28 17:42 ` Mark Brown
2023-06-28 16:57 ` Dmitry Baryshkov [this message]
2023-06-28 18:10 ` Mark Brown
2023-06-28 19:33 ` Dmitry Baryshkov
2023-06-28 19:40 ` Mark Brown
2023-06-28 20:00 ` Dmitry Baryshkov
2023-06-28 20:11 ` Mark Brown
2023-06-28 10:26 ` [PATCH 3/3] arm64: dts: qcom: sc8280xp-x13s: Add audio topology firmware path Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73dce263-bee6-554f-9eb6-af4aa7badab1@linaro.org \
--to=dmitry.baryshkov@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=devicetree@vger.kernel.org \
--cc=johan+linaro@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).