From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24D60EB64D7 for ; Wed, 28 Jun 2023 16:57:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbjF1Q5p (ORCPT ); Wed, 28 Jun 2023 12:57:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230196AbjF1Q5n (ORCPT ); Wed, 28 Jun 2023 12:57:43 -0400 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 494A2170F for ; Wed, 28 Jun 2023 09:57:41 -0700 (PDT) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b6a16254a4so707661fa.0 for ; Wed, 28 Jun 2023 09:57:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687971459; x=1690563459; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Z/zCltrriS9+FwfYPkaoLx57nyP2zICnwZ3L4CTqa1o=; b=syyZXBBk17JauNows5A2urMe/pcWTLphLlt4SnwA2w1ABVK5XugBET02VZTNZuT4nG BDOc/kJ6ib1UvpjR32PSCHkft8ibj9934gCK2qvehWRrfkXF7XIf4m9a2w5Ob9dQ4t6m YZ5YM2SzILcwULe1BPJAKAJIk+Pp/GFko0WMt29LldbbJK8E+rLLMRBjb2C03Ue8b75A u7mMPttbXk1mjEURIFqk7RS7UbQLQ7z7WoDPAsVE6Q2SzvNwTuRfQw3Ojl1xWI2r0ocl c+kPoqasBRouUlgkGGyrbERJppvjbFjiNYmcTRbdgXFDfJYEir3S3Im2G2WUV2XiPykH lDBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687971459; x=1690563459; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z/zCltrriS9+FwfYPkaoLx57nyP2zICnwZ3L4CTqa1o=; b=GcaKMY1oae3XJYhg5CFgyBu3tjJ7YMaKFpDqYQpxw7sBBz6FELCjkRWHwRzhiaejcy 7VdiOY139Euf+SnPWF9gWKO6am5oKN6cUdrp0EtVW7wddqWlbN4dvGSmZ2ld6sdl4W/E HZp+oh/8KepHB8cj8/pVaKDqi19pY+YIioMRnXpix4hZq3pdDksJbkAXz3P0iN5y70F4 Zfb1G8HjpP1LYy6YGrsXDUN6lxyVt4J6Fc9/jqIoz3a7iIK5zvLNxAmCaX0lTGd9AoJY ms+y3RN/CjNBefRlpaQWKaT2MNmQveK0cNEeXRx7dxx9isUw1S6E/xfCH0ThXsamqiIB ZOBg== X-Gm-Message-State: AC+VfDy6+kvMhHYOkUKVhxvTC2gOKoEDeBlpjrAxTz5pNmozynHBj76T 17rWgf9l2Zfvd/heeGAtAd9ZiS1+gN7XWISQnos= X-Google-Smtp-Source: ACHHUZ5O1WkcZQ+NAg+pK0OUsPsx/35pHTmfE+O/DSkG1d2UB7WiB+g4BQBT7/MHrfwy18PtV+CYew== X-Received: by 2002:a2e:7c09:0:b0:2b5:80c9:1266 with SMTP id x9-20020a2e7c09000000b002b580c91266mr17376124ljc.43.1687971459498; Wed, 28 Jun 2023 09:57:39 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id t8-20020a2e9c48000000b002b6a824d65fsm1076904ljj.0.2023.06.28.09.57.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jun 2023 09:57:39 -0700 (PDT) Message-ID: <73dce263-bee6-554f-9eb6-af4aa7badab1@linaro.org> Date: Wed, 28 Jun 2023 19:57:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 2/3] ASoC: qcom: q6apm: add support for reading firmware name from DT Content-Language: en-GB To: Mark Brown , Srinivas Kandagatla Cc: krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, johan+linaro@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org References: <20230628102621.15016-1-srinivas.kandagatla@linaro.org> <20230628102621.15016-3-srinivas.kandagatla@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/06/2023 14:53, Mark Brown wrote: > On Wed, Jun 28, 2023 at 11:26:20AM +0100, Srinivas Kandagatla wrote: >> Currently firmware file name is autogenerated based on card name and model number, >> however this imposed a restriction of finding firmware in a single firmware path. >> Platform specific firmwares are normally located in sub folders of the SoC. >> >> Provide more flexibity by reading firmware-name from DT. > > Why not try a series of firmware names/locations generated using the > identifying information for the card/system? That way we don't have to > put a filename in the ABI which has fun scaling issues. This is what was done by Srini in the initial (currently committed) version. Unfortunately this easily results in the audio topology being separated from the rest of the platform-specific firmware. For example, for the mentioned X13s we already have a subdir under /lib/firmware/qcom and several firmware-name DT properties pointing to the files in that subdir: $ grep firmware-name arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcdxkmsuc8280.mbn"; firmware-name = "qcom/sc8280xp/LENOVO/21BX/qcadsp8280.mbn"; firmware-name = "qcom/sc8280xp/LENOVO/21BX/qccdsp8280.mbn"; This is not unique to the X13s, other Qualcomm boards also use full paths. -- With best wishes Dmitry