devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] of: Move of_skipped_node_table within #ifdef CONFIG_OF_ADDRESS
@ 2023-08-22  7:57 Viresh Kumar
  2023-08-22 17:52 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Viresh Kumar @ 2023-08-22  7:57 UTC (permalink / raw)
  To: Rob Herring, Frank Rowand
  Cc: Viresh Kumar, kernel test robot, devicetree, linux-kernel

The `struct of_skipped_node_table` is used only when CONFIG_OF_ADDRESS
is defined, move it within the #ifdef/#endif to avoid warnings on
configurations where CONFIG_OF_ADDRESS isn't defined.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308212037.YopffWSU-lkp@intel.com/
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 drivers/of/platform.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 051e29b7ad2b..3f7bdf7bc2f8 100644
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -31,11 +31,6 @@ const struct of_device_id of_default_bus_match_table[] = {
 	{} /* Empty terminated list */
 };
 
-static const struct of_device_id of_skipped_node_table[] = {
-	{ .compatible = "operating-points-v2", },
-	{} /* Empty terminated list */
-};
-
 /**
  * of_find_device_by_node - Find the platform_device associated with a node
  * @np: Pointer to device tree node
@@ -55,6 +50,11 @@ struct platform_device *of_find_device_by_node(struct device_node *np)
 EXPORT_SYMBOL(of_find_device_by_node);
 
 #ifdef CONFIG_OF_ADDRESS
+static const struct of_device_id of_skipped_node_table[] = {
+	{ .compatible = "operating-points-v2", },
+	{} /* Empty terminated list */
+};
+
 /*
  * The following routines scan a subtree and registers a device for
  * each applicable node.
-- 
2.31.1.272.g89b43f80a514


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] of: Move of_skipped_node_table within #ifdef CONFIG_OF_ADDRESS
  2023-08-22  7:57 [PATCH] of: Move of_skipped_node_table within #ifdef CONFIG_OF_ADDRESS Viresh Kumar
@ 2023-08-22 17:52 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2023-08-22 17:52 UTC (permalink / raw)
  To: Viresh Kumar
  Cc: kernel test robot, Frank Rowand, devicetree, Rob Herring,
	linux-kernel


On Tue, 22 Aug 2023 13:27:22 +0530, Viresh Kumar wrote:
> The `struct of_skipped_node_table` is used only when CONFIG_OF_ADDRESS
> is defined, move it within the #ifdef/#endif to avoid warnings on
> configurations where CONFIG_OF_ADDRESS isn't defined.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308212037.YopffWSU-lkp@intel.com/
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
>  drivers/of/platform.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 

Applied, thanks!


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-08-22 17:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-22  7:57 [PATCH] of: Move of_skipped_node_table within #ifdef CONFIG_OF_ADDRESS Viresh Kumar
2023-08-22 17:52 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).