From: Krzysztof Kozlowski <krzk@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>,
tglx@linutronix.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, tsbogend@alpha.franken.de,
daniel.lezcano@linaro.org, paulburton@kernel.org,
peterz@infradead.org, mail@birger-koblitz.de, bert@biot.com,
john@phrozen.org, sander@svanheule.net
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mips@vger.kernel.org, kabel@kernel.org,
ericwouds@gmail.com
Subject: Re: [PATCH 1/6] dt-bindings: mips: realtek: Add rtl930x-soc compatible
Date: Sun, 23 Jun 2024 09:12:16 +0200 [thread overview]
Message-ID: <73e55bc3-2409-4309-9eaa-64be1e8ecf6f@kernel.org> (raw)
In-Reply-To: <20240621042737.674128-2-chris.packham@alliedtelesis.co.nz>
On 21/06/2024 06:27, Chris Packham wrote:
> Add the rtl930x-soc and RTL9302C board to the list of Realtek compatible
> strings.
No, you did not do this. You added fallback, without any rationale.
>
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
> ---
> Documentation/devicetree/bindings/mips/realtek-rtl.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> index f8ac309d2994..f59249a2cefe 100644
> --- a/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> +++ b/Documentation/devicetree/bindings/mips/realtek-rtl.yaml
> @@ -19,6 +19,8 @@ properties:
> - items:
> - enum:
> - cisco,sg220-26
> + - realtek,RTL9302C
> - const: realtek,rtl8382-soc
> + - const: realtek,rtl930x-soc
Does not look right. First: Not tested. Second: does not really make
sense and commit msg does not explain it to me. Also, no wildcards.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-23 7:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-21 4:27 [PATCH 0/6] mips: Support for RTL9302C Chris Packham
2024-06-21 4:27 ` [PATCH 1/6] dt-bindings: mips: realtek: Add rtl930x-soc compatible Chris Packham
2024-06-22 12:15 ` Conor Dooley
2024-06-23 7:12 ` Krzysztof Kozlowski [this message]
2024-06-21 4:27 ` [PATCH 2/6] dt-bindings: timer: Add schema for realtek,otto-timer Chris Packham
2024-06-22 12:11 ` Conor Dooley
2024-06-23 21:23 ` Chris Packham
2024-06-24 16:34 ` Conor Dooley
2024-06-23 7:19 ` Krzysztof Kozlowski
2024-06-21 4:27 ` [PATCH 3/6] dt-bindings: interrupt-controller: realtek,rtl-intc: Add rtl9300-intc Chris Packham
2024-06-22 12:08 ` Conor Dooley
2024-06-23 7:12 ` Krzysztof Kozlowski
2024-06-21 4:27 ` [PATCH 4/6] clocksource: realtek: Add timer driver for rtl-otto platforms Chris Packham
2024-06-23 7:13 ` Krzysztof Kozlowski
2024-06-26 2:01 ` kernel test robot
2024-06-26 11:32 ` kernel test robot
2024-06-26 12:08 ` kernel test robot
2024-06-21 4:27 ` [PATCH 5/6] mips: generic: add fdt fixup for Realtek reference board Chris Packham
2024-06-21 4:27 ` [PATCH 6/6] mips: dts: realtek: Add RTL9302C board Chris Packham
2024-06-23 7:15 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73e55bc3-2409-4309-9eaa-64be1e8ecf6f@kernel.org \
--to=krzk@kernel.org \
--cc=bert@biot.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ericwouds@gmail.com \
--cc=john@phrozen.org \
--cc=kabel@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=mail@birger-koblitz.de \
--cc=paulburton@kernel.org \
--cc=peterz@infradead.org \
--cc=robh@kernel.org \
--cc=sander@svanheule.net \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).