public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Kevin Tung <kevin.tung.openbmc@gmail.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski	 <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Joel Stanley	 <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	 linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	Amithash Prasasd	 <amithash@meta.com>,
	Kevin Tung <Kevin.Tung@quantatw.com>,
	Ken Chen	 <Ken.Chen@quantatw.com>,
	Leo Yang <Leo-Yang@quantatw.com>,
	Jackson Liu	 <Jackson.Liu@quantatw.com>,
	Daniel Hsu <Daniel-Hsu@quantatw.com>
Subject: Re: [PATCH v5 2/8] ARM: dts: aspeed: yosemite5: Remove ambiguous power monitor DTS nodes
Date: Wed, 04 Mar 2026 13:11:16 +1030	[thread overview]
Message-ID: <73ea41bf341df0e3215c58a029c9ea2386c4ef8a.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20260223-yv5_revise_dts-v5-2-fc913e902488@gmail.com>

Hi Kevin,

Sorry for the patchy replies so far, but this series bothers me and
other priorities keep bumping it down the list.

On Mon, 2026-02-23 at 19:17 +0800, Kevin Tung wrote:
> Two different power monitor devices, using different drivers, reuse
> I2C addresses 0x40 and 0x45 on bus 10 across Yosemite5 board variants.
> Defining these devices statically in the DTS can lead to incorrect
> driver binding on newer boards when the wrong device is instantiated.

There are effective methods of maintaining devicetrees for variants.
Why are we choosing to remove information about the platform rather
than use existing techniques to properly describe them?

> 
> Therefore, remove 10-0040 and 10-0045 device nodes, and let the driver
> selection is instead handled in user space by the OpenBMC Entity
> Manager based on the actual board configuration.

As a separate problem to the one above, while you may run OpenBMC on
this platform, I'd rather keep the description abstract. We can finish
the sentence at "... is instead handled in user space" and remove the
rest.

Andrew

  reply	other threads:[~2026-03-04  2:41 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 11:17 [PATCH v5 0/8] Revise Meta Yosemite5 devicetree Kevin Tung
2026-02-23 11:17 ` [PATCH v5 1/8] ARM: dts: aspeed: yosemite5: Increase i2c4/i2c12 bus speed to 400 kHz Kevin Tung
2026-02-23 11:17 ` [PATCH v5 2/8] ARM: dts: aspeed: yosemite5: Remove ambiguous power monitor DTS nodes Kevin Tung
2026-03-04  2:41   ` Andrew Jeffery [this message]
2026-03-09 18:41     ` Kevin Tung
2026-03-26  6:07       ` Andrew Jeffery
2026-02-23 11:17 ` [PATCH v5 3/8] ARM: dts: aspeed: yosemite5: Add new SGPIO line names and rename signal Kevin Tung
2026-03-04  2:40   ` Andrew Jeffery
2026-03-09 18:34     ` Kevin Tung
2026-03-26  6:10       ` Andrew Jeffery
2026-02-23 11:17 ` [PATCH v5 4/8] ARM: dts: aspeed: yosemite5: Add IPMB node for OCP debug card Kevin Tung
2026-02-23 11:17 ` [PATCH v5 5/8] ARM: dts: aspeed: yosemite5: Correct power monitor shunt resistor Kevin Tung
2026-02-23 11:17 ` [PATCH v5 6/8] ARM: dts: aspeed: yosemite5: Add power distribution board IO expanders Kevin Tung
2026-02-23 11:17 ` [PATCH v5 7/8] ARM: dts: aspeed: yosemite5: Add debug card bypass GPIO Kevin Tung
2026-02-23 11:17 ` [PATCH v5 8/8] ARM: dts: aspeed: yosemite5: Fix host0-ready and add POST end GPIO Kevin Tung

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73ea41bf341df0e3215c58a029c9ea2386c4ef8a.camel@codeconstruct.com.au \
    --to=andrew@codeconstruct.com.au \
    --cc=Daniel-Hsu@quantatw.com \
    --cc=Jackson.Liu@quantatw.com \
    --cc=Ken.Chen@quantatw.com \
    --cc=Kevin.Tung@quantatw.com \
    --cc=Leo-Yang@quantatw.com \
    --cc=amithash@meta.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=kevin.tung.openbmc@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox