From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
sboyd@kernel.org, chun-jie.chen@mediatek.com,
rex-bc.chen@mediatek.com, wenst@chromium.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property
Date: Wed, 18 May 2022 13:50:20 +0200 [thread overview]
Message-ID: <73f6ab7c-635e-1ff3-2d48-492c256ffcc9@collabora.com> (raw)
In-Reply-To: <81dcc83b-7ef0-779e-ad2b-8d0722b48ba4@linaro.org>
Il 18/05/22 13:46, Krzysztof Kozlowski ha scritto:
> On 18/05/2022 11:36, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> These I considered as somehow fixes so I did not ask to remove the Fixes
> tag, so also not squashing. It's fine, though...
>
I'm sorry Krzysztof, for some reason I was sure that your comments were applicable
on the entire series...
I'll pay more attention next time, and eventually I'll make one more question
when/if needed. I take your last comment as "leave this series as it is", so
I will not send a v3.
Regards,
Angelo
next prev parent reply other threads:[~2022-05-18 11:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 9:36 [PATCH v2 0/2] dt-bindings: arm: MediaTek: Fix clock bindings AngeloGioacchino Del Regno
2022-05-18 9:36 ` [PATCH v2 1/2] dt-bindings: arm: mtk-clock: Remove unnecessary 'items' and fix formatting AngeloGioacchino Del Regno
2022-05-20 22:16 ` Rob Herring
2022-05-18 9:36 ` [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property AngeloGioacchino Del Regno
2022-05-18 11:46 ` Krzysztof Kozlowski
2022-05-18 11:50 ` AngeloGioacchino Del Regno [this message]
2022-05-20 22:19 ` Rob Herring
2022-05-21 14:05 ` Krzysztof Kozlowski
2022-05-23 14:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73f6ab7c-635e-1ff3-2d48-492c256ffcc9@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=rex-bc.chen@mediatek.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).