devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v6 2/2] backlight arcxcnn devicetree bindings for ArcticSand
@ 2017-02-28 18:20 Olimpiu Dejeu
       [not found] ` <1488306035-16461-1-git-send-email-olimpiu-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Olimpiu Dejeu @ 2017-02-28 18:20 UTC (permalink / raw)
  To: robh
  Cc: lee.jones, linux-kernel, linux-fbdev, devicetree, jingoohan1,
	bdodge, joe, medasaro, daniel.thompson, Olimpiu Dejeu

backlight: Add devicetree bindings for the Arctic Sand backlight driver
This patch provides devicetree bindings for the Arctic Sand
    driver submitted in the previous patch
Acked-by: Rob Herring <robh@kernel.org>
Signed-off-by: Olimpiu Dejeu <olimpiu@arcticsand.com>
---
v5 => v6:
- Version updated to match other patch in set. No other changes.
v4 => v5:
- Added spaces for increased readability per Lee Jones
v3 => v4:
- Added spaces for increased readability per Lee Jones
v2 => v3:
- Version updated to match other patch in set. No other changes.
v1 => v2:
- Version updated to match other patch in set. No other changes.

 .../bindings/leds/backlight/arcxcnn_bl.txt         | 33 ++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt

diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
new file mode 100644
index 0000000..ecb7731
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
@@ -0,0 +1,33 @@
+Binding for ArcticSand arc2c0608 LED driver
+
+Required properties:
+- compatible:		should be "arc,arc2c0608"
+- reg:			slave address
+
+Optional properties:
+- default-brightness:	brightness value on boot, value from: 0-4095
+- label:		The name of the backlight device
+			See Documentation/devicetree/bindings/leds/common.txt
+- led-sources:		List of enabled channels from 0 to 5.
+			See Documentation/devicetree/bindings/leds/common.txt
+
+- arc,led-config-0:	setting for register ILED_CONFIG_0
+- arc,led-config-1:	setting for register ILED_CONFIG_1
+- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
+- arc,comp-config:	setting for register CONFIG_COMP
+- arc,filter-config:	setting for register FILTER_CONFIG
+- arc,trim-config:	setting for register IMAXTUNE
+
+Note: Optional properties not specified will default to values in IC EPROM
+
+Example:
+
+arc2c0608@30 {
+	compatible = "arc,arc2c0608";
+	reg = <0x30>;
+	default-brightness = <500>;
+	label = "lcd-backlight";
+	linux,default-trigger = "backlight";
+	led-sources = <0 1 2 5>;
+};
+
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v6 2/2] backlight arcxcnn devicetree bindings for ArcticSand
       [not found] ` <1488306035-16461-1-git-send-email-olimpiu-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org>
@ 2017-03-10 13:17   ` Daniel Thompson
       [not found]     ` <73fb917e-d71c-b094-7d33-8ccddd0ea1cf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Thompson @ 2017-03-10 13:17 UTC (permalink / raw)
  To: Olimpiu Dejeu, robh-DgEjT+Ai2ygdnm+yROfE0A
  Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	jingoohan1-Re5JQEeQqe8AvxtiuMwx3w, bdodge-eV7fy4qpoLhpLGFMi4vTTA,
	joe-6d6DIl74uiNBDgjK7y7TUQ, medasaro-eV7fy4qpoLhpLGFMi4vTTA

On 28/02/17 19:20, Olimpiu Dejeu wrote:
> backlight: Add devicetree bindings for the Arctic Sand backlight driver
> This patch provides devicetree bindings for the Arctic Sand
>     driver submitted in the previous patch
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Signed-off-by: Olimpiu Dejeu <olimpiu-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org>

Acked-by: Daniel Thompson <daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

But...

This binding documentation patch should precede the code in the patch 
series (amoung other things this avoids transient checkpatch errors).


> ---
> v5 => v6:
> - Version updated to match other patch in set. No other changes.
> v4 => v5:
> - Added spaces for increased readability per Lee Jones
> v3 => v4:
> - Added spaces for increased readability per Lee Jones
> v2 => v3:
> - Version updated to match other patch in set. No other changes.
> v1 => v2:
> - Version updated to match other patch in set. No other changes.
>
>  .../bindings/leds/backlight/arcxcnn_bl.txt         | 33 ++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> new file mode 100644
> index 0000000..ecb7731
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> @@ -0,0 +1,33 @@
> +Binding for ArcticSand arc2c0608 LED driver
> +
> +Required properties:
> +- compatible:		should be "arc,arc2c0608"
> +- reg:			slave address
> +
> +Optional properties:
> +- default-brightness:	brightness value on boot, value from: 0-4095
> +- label:		The name of the backlight device
> +			See Documentation/devicetree/bindings/leds/common.txt
> +- led-sources:		List of enabled channels from 0 to 5.
> +			See Documentation/devicetree/bindings/leds/common.txt
> +
> +- arc,led-config-0:	setting for register ILED_CONFIG_0
> +- arc,led-config-1:	setting for register ILED_CONFIG_1
> +- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
> +- arc,comp-config:	setting for register CONFIG_COMP
> +- arc,filter-config:	setting for register FILTER_CONFIG
> +- arc,trim-config:	setting for register IMAXTUNE
> +
> +Note: Optional properties not specified will default to values in IC EPROM
> +
> +Example:
> +
> +arc2c0608@30 {
> +	compatible = "arc,arc2c0608";
> +	reg = <0x30>;
> +	default-brightness = <500>;
> +	label = "lcd-backlight";
> +	linux,default-trigger = "backlight";
> +	led-sources = <0 1 2 5>;
> +};
> +
>

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v6 2/2] backlight arcxcnn devicetree bindings for ArcticSand
       [not found]     ` <73fb917e-d71c-b094-7d33-8ccddd0ea1cf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
@ 2017-03-14 10:05       ` Lee Jones
  0 siblings, 0 replies; 3+ messages in thread
From: Lee Jones @ 2017-03-14 10:05 UTC (permalink / raw)
  To: Daniel Thompson
  Cc: Olimpiu Dejeu, robh-DgEjT+Ai2ygdnm+yROfE0A,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA,
	linux-fbdev-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	jingoohan1-Re5JQEeQqe8AvxtiuMwx3w, bdodge-eV7fy4qpoLhpLGFMi4vTTA,
	joe-6d6DIl74uiNBDgjK7y7TUQ, medasaro-eV7fy4qpoLhpLGFMi4vTTA

On Fri, 10 Mar 2017, Daniel Thompson wrote:

> On 28/02/17 19:20, Olimpiu Dejeu wrote:
> > backlight: Add devicetree bindings for the Arctic Sand backlight driver
> > This patch provides devicetree bindings for the Arctic Sand
> >     driver submitted in the previous patch
> > Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> > Signed-off-by: Olimpiu Dejeu <olimpiu-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org>
> 
> Acked-by: Daniel Thompson <daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> 
> But...
> 
> This binding documentation patch should precede the code in the patch series
> (amoung other things this avoids transient checkpatch errors).

Right.  Also, when you send patch-sets, please sent them 'threaded'.

Please resubmit with Daniel's Ack.

> > ---
> > v5 => v6:
> > - Version updated to match other patch in set. No other changes.
> > v4 => v5:
> > - Added spaces for increased readability per Lee Jones
> > v3 => v4:
> > - Added spaces for increased readability per Lee Jones
> > v2 => v3:
> > - Version updated to match other patch in set. No other changes.
> > v1 => v2:
> > - Version updated to match other patch in set. No other changes.
> > 
> >  .../bindings/leds/backlight/arcxcnn_bl.txt         | 33 ++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> > 
> > diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> > new file mode 100644
> > index 0000000..ecb7731
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt
> > @@ -0,0 +1,33 @@
> > +Binding for ArcticSand arc2c0608 LED driver
> > +
> > +Required properties:
> > +- compatible:		should be "arc,arc2c0608"
> > +- reg:			slave address
> > +
> > +Optional properties:
> > +- default-brightness:	brightness value on boot, value from: 0-4095
> > +- label:		The name of the backlight device
> > +			See Documentation/devicetree/bindings/leds/common.txt
> > +- led-sources:		List of enabled channels from 0 to 5.
> > +			See Documentation/devicetree/bindings/leds/common.txt
> > +
> > +- arc,led-config-0:	setting for register ILED_CONFIG_0
> > +- arc,led-config-1:	setting for register ILED_CONFIG_1
> > +- arc,dim-freq:		PWM mode frequence setting (bits [3:0] used)
> > +- arc,comp-config:	setting for register CONFIG_COMP
> > +- arc,filter-config:	setting for register FILTER_CONFIG
> > +- arc,trim-config:	setting for register IMAXTUNE
> > +
> > +Note: Optional properties not specified will default to values in IC EPROM
> > +
> > +Example:
> > +
> > +arc2c0608@30 {
> > +	compatible = "arc,arc2c0608";
> > +	reg = <0x30>;
> > +	default-brightness = <500>;
> > +	label = "lcd-backlight";
> > +	linux,default-trigger = "backlight";
> > +	led-sources = <0 1 2 5>;
> > +};
> > +
> > 
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-03-14 10:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-28 18:20 [PATCH v6 2/2] backlight arcxcnn devicetree bindings for ArcticSand Olimpiu Dejeu
     [not found] ` <1488306035-16461-1-git-send-email-olimpiu-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org>
2017-03-10 13:17   ` Daniel Thompson
     [not found]     ` <73fb917e-d71c-b094-7d33-8ccddd0ea1cf-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-03-14 10:05       ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).