From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH v6 2/2] backlight arcxcnn devicetree bindings for ArcticSand Date: Fri, 10 Mar 2017 14:17:32 +0100 Message-ID: <73fb917e-d71c-b094-7d33-8ccddd0ea1cf@linaro.org> References: <1488306035-16461-1-git-send-email-olimpiu@arcticsand.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1488306035-16461-1-git-send-email-olimpiu-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olimpiu Dejeu , robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fbdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, jingoohan1-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, bdodge-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org, joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, medasaro-eV7fy4qpoLhpLGFMi4vTTA@public.gmane.org List-Id: devicetree@vger.kernel.org On 28/02/17 19:20, Olimpiu Dejeu wrote: > backlight: Add devicetree bindings for the Arctic Sand backlight driver > This patch provides devicetree bindings for the Arctic Sand > driver submitted in the previous patch > Acked-by: Rob Herring > Signed-off-by: Olimpiu Dejeu Acked-by: Daniel Thompson But... This binding documentation patch should precede the code in the patch series (amoung other things this avoids transient checkpatch errors). > --- > v5 => v6: > - Version updated to match other patch in set. No other changes. > v4 => v5: > - Added spaces for increased readability per Lee Jones > v3 => v4: > - Added spaces for increased readability per Lee Jones > v2 => v3: > - Version updated to match other patch in set. No other changes. > v1 => v2: > - Version updated to match other patch in set. No other changes. > > .../bindings/leds/backlight/arcxcnn_bl.txt | 33 ++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > > diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > new file mode 100644 > index 0000000..ecb7731 > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > @@ -0,0 +1,33 @@ > +Binding for ArcticSand arc2c0608 LED driver > + > +Required properties: > +- compatible: should be "arc,arc2c0608" > +- reg: slave address > + > +Optional properties: > +- default-brightness: brightness value on boot, value from: 0-4095 > +- label: The name of the backlight device > + See Documentation/devicetree/bindings/leds/common.txt > +- led-sources: List of enabled channels from 0 to 5. > + See Documentation/devicetree/bindings/leds/common.txt > + > +- arc,led-config-0: setting for register ILED_CONFIG_0 > +- arc,led-config-1: setting for register ILED_CONFIG_1 > +- arc,dim-freq: PWM mode frequence setting (bits [3:0] used) > +- arc,comp-config: setting for register CONFIG_COMP > +- arc,filter-config: setting for register FILTER_CONFIG > +- arc,trim-config: setting for register IMAXTUNE > + > +Note: Optional properties not specified will default to values in IC EPROM > + > +Example: > + > +arc2c0608@30 { > + compatible = "arc,arc2c0608"; > + reg = <0x30>; > + default-brightness = <500>; > + label = "lcd-backlight"; > + linux,default-trigger = "backlight"; > + led-sources = <0 1 2 5>; > +}; > + > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html