From: Josua Mayer <josua@solid-run.com>
To: Pratyush Yadav <pratyush@kernel.org>
Cc: Tudor Ambarus <tudor.ambarus@linaro.org>,
Michael Walle <mwalle@kernel.org>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Yazan Shhady <yazan.shhady@solid-run.com>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] dt-bindings: mtd: spi-nor: add optional interrupts property
Date: Tue, 20 Feb 2024 13:31:14 +0100 [thread overview]
Message-ID: <741c19b8-55f5-4f3f-8391-10fc2758e687@solid-run.com> (raw)
In-Reply-To: <mafs08r3f8h16.fsf@kernel.org>
Am 20.02.24 um 13:19 schrieb Pratyush Yadav:
> On Mon, Feb 19 2024, Josua Mayer wrote:
>
>> Some spi flash memories have an interrupt signal which can be used for
>> signalling on-chip events such as busy status or ecc errors to the host.
>>
>> Add binding for "interrupts" property so that boards wiring this signal
>> may describe the connection.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
>> Acked-by: Rob Herring <robh@kernel.org>
> Acked-by: Pratyush Yadav <pratyush@kernel.org>
>
> BTW, I don't see any support in SPI NOR for handling these interrupts.
> Do you plan to add them in a later patchset?
No current plans, I have little knowledge how spi-nor works in the kernel.
> If not, what do you get by
> describing them?
Foremost I get to submit a correct device-tree (describes hardware)
to the kernel, without maintainers getting all over me for introducing
new dtbs_check errors.
And I really do prefer submitting a complete device-tree so that all
knowledge I have gained reading private schematics is readily
available the next time someone works on it.
>
>> ---
>> Changes in v7:
>> - split out of original patchset because it should go via mtd tree
>> - collected acked-by Rob Herring from v6
>> - Link to v6: https://lore.kernel.org/r/20240212-add-am64-som-v6-0-b59edb2bc8c3@solid-run.com
>> ---
>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index 58f0cea160ef..6e3afb42926e 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -52,6 +52,9 @@ properties:
>> minItems: 1
>> maxItems: 2
>>
>> + interrupts:
>> + maxItems: 1
>> +
>> m25p,fast-read:
>> type: boolean
>> description:
>>
next prev parent reply other threads:[~2024-02-20 12:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:41 [PATCH v7] dt-bindings: mtd: spi-nor: add optional interrupts property Josua Mayer
2024-02-20 12:19 ` Pratyush Yadav
2024-02-20 12:31 ` Josua Mayer [this message]
2024-02-20 13:30 ` Pratyush Yadav
2024-02-21 8:27 ` Michael Walle
2024-02-21 9:13 ` Josua Mayer
2024-02-21 9:23 ` Michael Walle
2024-02-21 10:48 ` Pratyush Yadav
2024-02-21 11:52 ` Michael Walle
2024-02-26 10:02 ` Tudor Ambarus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=741c19b8-55f5-4f3f-8391-10fc2758e687@solid-run.com \
--to=josua@solid-run.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
--cc=yazan.shhady@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).