From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Naresh Solanki <naresh.solanki@9elements.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: hwmon: Add binding for max6639
Date: Tue, 18 Apr 2023 18:17:32 +0200 [thread overview]
Message-ID: <742f546b-3952-32f4-9f20-3a355785d162@linaro.org> (raw)
In-Reply-To: <20230418113217.781524-1-Naresh.Solanki@9elements.com>
On 18/04/2023 13:32, Naresh Solanki wrote:
> Add Devicetree binding documentation for Maxim MAX6639 temperature
> monitor with PWM fan-speed controller.
Subject: drop second/last, redundant "binding for". The "dt-bindings"
prefix is already stating that these are bindings.
>
> Signed-off-by: Naresh Solanki <Naresh.Solanki@9elements.com>
> ---
> .../bindings/hwmon/maxim,max6639.yaml | 55 +++++++++++++++++++
> 1 file changed, 55 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
> new file mode 100644
> index 000000000000..20b28cd36555
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/maxim,max6639.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
Drop blank line
This is v9. Where is the changelog? Where is previous authorship? At
least some parts of it? Why this has less properties than old one? Why
this has more mistakes than the old one? Go to previous patch... or fix
everything which was already fixed.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-04-18 16:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 11:32 [PATCH 1/2] dt-bindings: hwmon: Add binding for max6639 Naresh Solanki
2023-04-18 16:17 ` Krzysztof Kozlowski [this message]
2023-04-19 9:00 ` Naresh Solanki
2023-04-19 9:04 ` Krzysztof Kozlowski
2023-04-19 9:15 ` Naresh Solanki
-- strict thread matches above, loose matches on Subject: below --
2022-09-22 5:07 [PATCH 0/2] Add max6639 regulator and devicetree support Naresh Solanki
2022-09-22 5:07 ` [PATCH 1/2] dt-bindings: hwmon: Add binding for max6639 Naresh Solanki
2022-09-22 6:34 ` Krzysztof Kozlowski
2022-10-05 18:40 ` Guenter Roeck
2022-10-06 6:30 ` Naresh Solanki
2022-10-06 14:22 ` Guenter Roeck
2022-09-23 11:09 ` Patrick Rudolph
2022-09-29 19:32 ` Rob Herring
2022-10-05 13:16 ` Naresh Solanki
2022-10-05 15:45 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=742f546b-3952-32f4-9f20-3a355785d162@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=naresh.solanki@9elements.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).