devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: dt-bindings: tfa9879: Convert to dtschema
Date: Wed, 20 Sep 2023 21:12:16 +0530	[thread overview]
Message-ID: <74322740-8db4-f165-7c01-47ed98f07e51@gmail.com> (raw)
In-Reply-To: <9d612171-8ae4-de65-31b0-fbb5f1f8331e@linaro.org>


On 20/09/23 16:58, Krzysztof Kozlowski wrote:
> On 19/09/2023 11:07, Bragatheswaran Manickavel wrote:
>> Convert the tfa9879 audio CODEC bindings to DT schema
>>
>> +required:
>> +  - compatible
>> +  - reg
>> +  - '#sound-dai-cells'
>> +
>> +additionalProperties: false
> Instead:
> unevaluatedProperties: false
>
>> +
>> +examples:
>> +  - |
>> +    i2c1 {
>> +       #address-cells = <1>;
>> +       #size-cells = <0>;
>> +       amp: amp@6c {
> amplifier@6c
>
>> +          compatible: "nxp,tfa9879";
>> +          reg: <0x6c>;
>> +          "#sound-dai-cells": <0>;
>> +          pinctrl-names: "default";
>> +          pinctrl-0: <&pinctrl_i2c1>;
> That's not a DT syntax.
>
> Best regards,
> Krzysztof
>
Let me correct all this errors/warnings and send a new patch.

Thanks,
Bragathe

      reply	other threads:[~2023-09-20 15:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-19  9:07 [PATCH] ASoC: dt-bindings: tfa9879: Convert to dtschema Bragatheswaran Manickavel
2023-09-19 10:55 ` Rob Herring
2023-09-20 10:44 ` kernel test robot
2023-09-20 11:28 ` Krzysztof Kozlowski
2023-09-20 15:42   ` Bragatheswaran Manickavel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74322740-8db4-f165-7c01-47ed98f07e51@gmail.com \
    --to=bragathemanick0908@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).