Re: [PATCH v2] dt-bindings: dma: ti,dma-crossbar: Convert to DT schema

[Krzysztof Kozlowski <krzk@kernel.org>]

On 12/07/2026 18:28, Bhargav Joshi wrote:
> Hi,
> 
> On Sun, Jul 12, 2026 at 6:22 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On Wed, Jul 08, 2026 at 10:02:18PM +0530, Bhargav Joshi wrote:
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - ti,dra7-dma-crossbar
>>> +      - ti,am335x-edma-crossbar
>>> +
>>> +  reg:
>>> +    maxItems: 1
>>> +
>>> +  "#dma-cells":
>>> +    minimum: 1
>>> +    maximum: 3
>>
>> That's rather:
>>   enum: [1, 3]
>>
>> right?
> value 2 is required by DRA7 enhanced DMA crossbar (edma_xbar), and it is
> used in dra7-l4.dtsi so i think we can keep it unless you specifically
> prefer enum: [1, 2, 3]

I missed that edma device. It is fine.

> 
>>
>>> +
>>> +  dma-requests:
>>> +    minimum: 1
>>> +    maximum: 256
>>> +
>>> +  dma-masters:
>>> +    maxItems: 1
>>> +
>>> +  ti,dma-safe-map:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description: Safe routing value for unused request lines
>>> +
>>> +  ti,reserved-dma-request-ranges:
>>> +    $ref: /schemas/types.yaml#/definitions/uint32-matrix
>>> +    description:
>>> +      DMA request ranges which should not be used when mapping xbar input to
>>> +      DMA request, they are either allocated to be used by for example the DSP
>>> +      or they are used as memcpy channels in eDMA.
>>> +    items:
>>> +      items:
>>> +        - description: starting DMA request line number
>>> +        - description: number of consecutive lines to reserve
>>> +
>>> +required:
>>> +  - compatible
>>> +  - reg
>>> +  - "#dma-cells"
>>> +  - dma-requests
>>> +  - dma-masters
>>> +
>>> +allOf:
>>> +  - $ref: dma-router.yaml#
>>> +
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          contains:
>>> +            const: ti,am335x-edma-crossbar
>>> +    then:
>>> +      properties:
>>> +        "#dma-cells":
>>> +          const: 3
>>
>> else:
>>   properties:
>>     dma-cels:
>>       const: 1
> Yes but this should be rather,
> else:
>   properties:
>     '#dma-cells':
>         enum: [1, 2]
> as dra7 doesn't use value 3 but uses 1 and 2, I will add it in next version


Yes


Best regards,
Krzysztof