From: Sven Eckelmann <sven@narfation.org>
To: ath11k@lists.infradead.org
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, Anilkumar Kolli <akolli@codeaurora.org>
Subject: Re: [PATCH v5 2/2] ath11k: Use reserved host DDR addresses from DT for PCI devices
Date: Tue, 23 Nov 2021 14:01:34 +0100 [thread overview]
Message-ID: <74442923.uYUSDj6SXF@ripper> (raw)
In-Reply-To: <1637666940-30548-2-git-send-email-akolli@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Tuesday, 23 November 2021 12:29:00 CET Anilkumar Kolli wrote:
> + ret = of_property_read_u32(dev->of_node, "memory-region",
> + &hremote_phandle);
> + if (ret) {
> + ath11k_dbg(ab, ATH11K_DBG_QMI,
> + "qmi fail to get hremote phandle\n");
> + return ret;
> + }
> +
> + hremote_node = of_find_node_by_phandle(hremote_phandle);
> + if (!hremote_node) {
> + ath11k_dbg(ab, ATH11K_DBG_QMI,
> + "qmi fail to get hremote_node\n");
> + return ret;
> + }
Afaik, this can be combined via
hremote_node = of_parse_phandle(dev->of_node, "memory-region", 0);
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-23 13:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 11:28 [PATCH v5 1/2] dt: bindings: add new DT entry for ath11k PCI device support Anilkumar Kolli
2021-11-23 11:29 ` [PATCH v5 2/2] ath11k: Use reserved host DDR addresses from DT for PCI devices Anilkumar Kolli
2021-11-23 13:01 ` Sven Eckelmann [this message]
2021-11-25 11:15 ` Anilkumar Kolli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74442923.uYUSDj6SXF@ripper \
--to=sven@narfation.org \
--cc=akolli@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).