From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: sboyd@kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, mturquette@baylibre.com,
bjorn.andersson@linaro.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: clock: Add support for LPASS Audio Clock Controller
Date: Wed, 23 Sep 2020 11:25:16 +0100 [thread overview]
Message-ID: <7454ad51-edd7-4080-72b6-1d37858ba3ff@linaro.org> (raw)
In-Reply-To: <20200918172917.GA3827183@bogus>
Hi Rob,
On 18/09/2020 18:29, Rob Herring wrote:
> On Thu, 17 Sep 2020 14:28:47 +0100, Srinivas Kandagatla wrote:
>> Audio Clock controller is a block inside LPASS which controls
>> 2 Glitch free muxes to LPASS codec Macros.
>>
>> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
>> ---
>> .../bindings/clock/qcom,audiocc-sm8250.yaml | 58 +++++++++++++++++++
>> .../clock/qcom,sm8250-lpass-audiocc.h | 13 +++++
>> 2 files changed, 71 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.yaml
>> create mode 100644 include/dt-bindings/clock/qcom,sm8250-lpass-audiocc.h
>>
>
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> Error: Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.example.dts:25.30-31 syntax error
> FATAL ERROR: Unable to parse input tree
> make[1]: *** [scripts/Makefile.lib:342: Documentation/devicetree/bindings/clock/qcom,audiocc-sm8250.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1366: dt_binding_check] Error 2
>
Is this check done against linux-next?
or linux master?
I have rechecked this once again on next and I see no check failures.
Next has a patch [1] which adds defines in header file that are used in
example! Possibly that is what is making the check fail!
thanks,
srini
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200922&id=4e398353a7e51410c34fd19f8b7dfc56fff5901b
>
> See https://patchwork.ozlabs.org/patch/1366127
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure dt-schema is up to date:
>
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>
> Please check and re-submit.
>
next prev parent reply other threads:[~2020-09-23 10:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-17 13:28 [PATCH 0/4] clk: qcom : add sm8250 LPASS GFM drivers Srinivas Kandagatla
2020-09-17 13:28 ` [PATCH 1/4] dt-bindings: clock: Add support for LPASS Audio Clock Controller Srinivas Kandagatla
2020-09-18 17:29 ` Rob Herring
2020-09-23 10:25 ` Srinivas Kandagatla [this message]
2020-09-17 13:28 ` [PATCH 2/4] dt-bindings: clock: Add support for LPASS Always ON Controller Srinivas Kandagatla
2020-09-18 17:29 ` Rob Herring
2020-09-17 13:28 ` [PATCH 3/4] clk: qcom: Add support to LPASS AUDIO_CC Glitch Free Mux clocks Srinivas Kandagatla
2020-09-22 18:41 ` Stephen Boyd
2020-09-22 21:45 ` Srinivas Kandagatla
2020-09-23 23:28 ` Stephen Boyd
2020-09-22 21:49 ` Dmitry Baryshkov
2020-09-17 13:28 ` [PATCH 4/4] clk: qcom: Add support to LPASS AON_CC " Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7454ad51-edd7-4080-72b6-1d37858ba3ff@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).