From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Nuno Sá" <noname.nuno@gmail.com>, "Nuno Sa" <nuno.sa@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: adi,ad5791: Add support for controlling RBUF
Date: Wed, 29 Nov 2023 09:50:08 +0100 [thread overview]
Message-ID: <745bbf6c-ea58-4401-ab1d-c2372d2f30f4@linaro.org> (raw)
In-Reply-To: <fde82c39dbf56eeb8decac715ce5ec723da31e32.camel@gmail.com>
On 29/11/2023 09:28, Nuno Sá wrote:
> On Tue, 2023-11-28 at 16:58 +0100, Krzysztof Kozlowski wrote:
>> On 28/11/2023 16:26, Nuno Sa wrote:
>>> From: Michael Hennerich <michael.hennerich@analog.com>
>>>
>>> This change adds support for an external amplifier to be connected in a
>>
>> Nothing improved here.
>>
>> I said "This commit/patch" so you replaced it to "change", really, read
>> the Submitting patches document.
>>
>
> And? Is this message so horrible? Yes, you did said "This commit/patch" but I thought
> "commit/patch" was the issue because yes, I already saw other maintainers/reviewers
> complaining about using those specific words but nothing really against "This change"
> (and I do have some messages like that). Yeah, the submitting patches document
> suggests to do it more like "Added a new property so bala bla ..." but I dunno every
> word in that document is blindly followed. Is this such a big deal in here that you
> had reply like I don't care? And even if you're technically right, there were better
> ways to say that what I have was not exactly what you asked for...
>
> Submitters should make maintainers/reviewers life easier but the other way around is
> equally true and nitpicky things like this are not helpful. Really...
Nitpicking is caused by ignored review feedback and by not reading at
all attached/linked guideline. I gave quite explicit instruction,
including what I want the contributor to read. It was not read.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-29 8:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 15:26 [PATCH v2 0/2] iio: dac: ad5791: Add support for controlling RBUF via devicetree Nuno Sa
2023-11-28 15:26 ` [PATCH v2 1/2] dt-bindings: adi,ad5791: Add support for controlling RBUF Nuno Sa
2023-11-28 15:58 ` Krzysztof Kozlowski
2023-11-29 8:28 ` Nuno Sá
2023-11-29 8:50 ` Krzysztof Kozlowski [this message]
2023-11-28 15:26 ` [PATCH v2 2/2] iio: dac: ad5791: Add support for controlling RBUF via devicetree Nuno Sa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=745bbf6c-ea58-4401-ab1d-c2372d2f30f4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Michael.Hennerich@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=noname.nuno@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).