From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89390178CD2 for ; Tue, 25 Jun 2024 17:45:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719337529; cv=none; b=Abcqb+ieL6lVkOGEvuJq+VcWrF3ATX/FwoioyTUCdKlZAVrHG0kjpRcpRL2VYZBwCSsao/7PLr0wxWf3cCvZDzUGznikT+rzDNwUOz4HVMoOzc8l4qfahGhHu11vgHTasmR62fc3Gj308gS5bLAkdAa+l7OXulNona9mliu2trk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719337529; c=relaxed/simple; bh=ACNmRsg1SdwYlkSsmEVUDUeBB0yGXonpKYuVmWEPnpw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oce6zi5Nk+dpLE+w/tx/bkS7It2oE1H207pgkUb/9IFZWOmZuOaLf0wju2BoM7PC/TyGTtAa8vz+li1jbowny08y32C9D53F4AF6BLmyfeo5BtsbufiV+9NqwOlK2g+s1FOsGecIi20jDMysT7rM4yruecvHE9TCUJGkOo1G0pE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=lIMtADT5; arc=none smtp.client-ip=209.85.218.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lIMtADT5" Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a724440f597so400367266b.0 for ; Tue, 25 Jun 2024 10:45:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1719337525; x=1719942325; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=NZtQ+FPCoD6gGOl3U2rq3VHnQdVXsv7N8AK93klpC3g=; b=lIMtADT5aebvhgiJPpfINltYOJwacBMDisOiUusiTbdy3cb6DwOEArU0DnsoIwR4/G MFdUBhbJUIMlUmEDCYME3Kl7pXTNQFVZWjHf/R6rBbmSuij3RiUW9Ls7AWQeytGwMl6R C4Z9u29/mTJhhlnCdbFIAEJFGO/qMavHxeUX5H51rsbxg/Dr0ZwhWw5DGp8Wrql6KVDH C+sk353RJoTHYCuyhwTlG4qNiAAnQ4MRKoa/r1CCG3KzhYC3D/mzWBx78Ixy9hcvNzf0 9VrkXt6NGiAf7MoVxg7DL9kU0mH7rHftAjGwPUBGn1WRxB3Z4btdOUQeQS7i3qwngksh Vxmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719337525; x=1719942325; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=NZtQ+FPCoD6gGOl3U2rq3VHnQdVXsv7N8AK93klpC3g=; b=XQRxluzbTMC9SD5lXcHU79sLVh5oAGYmTXJ/trlONR454OXUF58qKA6jTlRY+Wy27i Ex0asqsA2sIwySWQVTe4ydq9tAKsRQmvQtKMcwazX6q8kB/HGOcSyMGJ7eMq5fim+sYP OocdW5hX+0Z1lt+XqVHoZDJ/ggkxSjQTnqOOLDtYNMJXs+CVqPZsCIDs7HJ0YY8UYVJw GeBR3LsyW3QBuZjwyIY8XMvAJ5n1l7HicBNRqiTSfrMPHQW3S2GDMx9s3WDLgZfx9NKD zv/8wtMEk9tNUwBs6xeE7vXJjtDxHE08rkB0famETdfxNV/KExk7EQKlXg9gr09yw4ri /nAg== X-Forwarded-Encrypted: i=1; AJvYcCW0zpVwZi2Jkv7TeReW2fLEEYNPd9XAiXtaVDOYqSUMyAWfci+d/giRTqJJd0nu2et84R0Vxz1dzxJZmQebmWw3NcbCjl3nwDaTCQ== X-Gm-Message-State: AOJu0YwpViGbA5lZAeLxZf0J5jJ1SM+eQBh7eezk6ZPU8zJjRA8LIOfe GdE+beJP6gvB0BV5JRe9tiw5j2P0bRo9nkJZb99I5AuME1dLy36tGKRJ/VqOwh8= X-Google-Smtp-Source: AGHT+IHBZiHbATOJgOa5gf/nGJ6ih3pE8Xg9MD/ucyXaGPgPhvAdwT2toiUPIliZvaxOfY+mmItumA== X-Received: by 2002:a17:906:e085:b0:a6f:d990:338c with SMTP id a640c23a62f3a-a7245b8f33dmr528502966b.20.1719337524703; Tue, 25 Jun 2024 10:45:24 -0700 (PDT) Received: from [192.168.215.29] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf48b24asm535271766b.57.2024.06.25.10.45.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jun 2024 10:45:24 -0700 (PDT) Message-ID: <7461891d-afa6-48b7-985a-02fcecf227c9@linaro.org> Date: Tue, 25 Jun 2024 19:45:21 +0200 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/7] drm/msm/adreno: Add speedbin data for SM8550 / A740 To: Rob Clark Cc: Bjorn Andersson , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, Neil Armstrong References: <20240605-topic-smem_speedbin-v2-0-8989d7e3d176@linaro.org> <20240605-topic-smem_speedbin-v2-4-8989d7e3d176@linaro.org> Content-Language: en-US From: Konrad Dybcio Autocrypt: addr=konrad.dybcio@linaro.org; keydata= xsFNBF9ALYUBEADWAhxdTBWrwAgDQQzc1O/bJ5O7b6cXYxwbBd9xKP7MICh5YA0DcCjJSOum BB/OmIWU6X+LZW6P88ZmHe+KeyABLMP5s1tJNK1j4ntT7mECcWZDzafPWF4F6m4WJOG27kTJ HGWdmtO+RvadOVi6CoUDqALsmfS3MUG5Pj2Ne9+0jRg4hEnB92AyF9rW2G3qisFcwPgvatt7 TXD5E38mLyOPOUyXNj9XpDbt1hNwKQfiidmPh5e7VNAWRnW1iCMMoKqzM1Anzq7e5Afyeifz zRcQPLaqrPjnKqZGL2BKQSZDh6NkI5ZLRhhHQf61fkWcUpTp1oDC6jWVfT7hwRVIQLrrNj9G MpPzrlN4YuAqKeIer1FMt8cq64ifgTzxHzXsMcUdclzq2LTk2RXaPl6Jg/IXWqUClJHbamSk t1bfif3SnmhA6TiNvEpDKPiT3IDs42THU6ygslrBxyROQPWLI9IL1y8S6RtEh8H+NZQWZNzm UQ3imZirlPjxZtvz1BtnnBWS06e7x/UEAguj7VHCuymVgpl2Za17d1jj81YN5Rp5L9GXxkV1 aUEwONM3eCI3qcYm5JNc5X+JthZOWsbIPSC1Rhxz3JmWIwP1udr5E3oNRe9u2LIEq+wH/toH kpPDhTeMkvt4KfE5m5ercid9+ZXAqoaYLUL4HCEw+HW0DXcKDwARAQABzShLb25yYWQgRHli Y2lvIDxrb25yYWQuZHliY2lvQGxpbmFyby5vcmc+wsGOBBMBCAA4FiEEU24if9oCL2zdAAQV R4cBcg5dfFgFAmQ5bqwCGwMFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQR4cBcg5dfFjO BQ//YQV6fkbqQCceYebGg6TiisWCy8LG77zV7DB0VMIWJv7Km7Sz0QQrHQVzhEr3trNenZrf yy+o2tQOF2biICzbLM8oyQPY8B///KJTWI2khoB8IJSJq3kNG68NjPg2vkP6CMltC/X3ohAo xL2UgwN5vj74QnlNneOjc0vGbtA7zURNhTz5P/YuTudCqcAbxJkbqZM4WymjQhe0XgwHLkiH 5LHSZ31MRKp/+4Kqs4DTXMctc7vFhtUdmatAExDKw8oEz5NbskKbW+qHjW1XUcUIrxRr667V GWH6MkVceT9ZBrtLoSzMLYaQXvi3sSAup0qiJiBYszc/VOu3RbIpNLRcXN3KYuxdQAptacTE mA+5+4Y4DfC3rUSun+hWLDeac9z9jjHm5rE998OqZnOU9aztbd6zQG5VL6EKgsVXAZD4D3RP x1NaAjdA3MD06eyvbOWiA5NSzIcC8UIQvgx09xm7dThCuQYJR4Yxjd+9JPJHI6apzNZpDGvQ BBZzvwxV6L1CojUEpnilmMG1ZOTstktWpNzw3G2Gis0XihDUef0MWVsQYJAl0wfiv/0By+XK mm2zRR+l/dnzxnlbgJ5pO0imC2w0TVxLkAp0eo0LHw619finad2u6UPQAkZ4oj++iIGrJkt5 Lkn2XgB+IW8ESflz6nDY3b5KQRF8Z6XLP0+IEdLOOARkOW7yEgorBgEEAZdVAQUBAQdAwmUx xrbSCx2ksDxz7rFFGX1KmTkdRtcgC6F3NfuNYkYDAQgHwsF2BBgBCAAgFiEEU24if9oCL2zd AAQVR4cBcg5dfFgFAmQ5bvICGwwACgkQR4cBcg5dfFju1Q//Xta1ShwL0MLSC1KL1lXGXeRM 8arzfyiB5wJ9tb9U/nZvhhdfilEDLe0jKJY0RJErbdRHsalwQCrtq/1ewQpMpsRxXzAjgfRN jc4tgxRWmI+aVTzSRpywNahzZBT695hMz81cVZJoZzaV0KaMTlSnBkrviPz1nIGHYCHJxF9r cIu0GSIyUjZ/7xslxdvjpLth16H27JCWDzDqIQMtg61063gNyEyWgt1qRSaK14JIH/DoYRfn jfFQSC8bffFjat7BQGFz4ZpRavkMUFuDirn5Tf28oc5ebe2cIHp4/kajTx/7JOxWZ80U70mA cBgEeYSrYYnX+UJsSxpzLc/0sT1eRJDEhI4XIQM4ClIzpsCIN5HnVF76UQXh3a9zpwh3dk8i bhN/URmCOTH+LHNJYN/MxY8wuukq877DWB7k86pBs5IDLAXmW8v3gIDWyIcgYqb2v8QO2Mqx YMqL7UZxVLul4/JbllsQB8F/fNI8AfttmAQL9cwo6C8yDTXKdho920W4WUR9k8NT/OBqWSyk bGqMHex48FVZhexNPYOd58EY9/7mL5u0sJmo+jTeb4JBgIbFPJCFyng4HwbniWgQJZ1WqaUC nas9J77uICis2WH7N8Bs9jy0wQYezNzqS+FxoNXmDQg2jetX8en4bO2Di7Pmx0jXA4TOb9TM izWDgYvmBE8= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 25.06.2024 7:21 PM, Rob Clark wrote: > On Wed, Jun 5, 2024 at 1:10 PM Konrad Dybcio wrote: >> >> Add speebin data for A740, as found on SM8550 and derivative SoCs. >> >> Reviewed-by: Dmitry Baryshkov >> Signed-off-by: Konrad Dybcio >> --- >> drivers/gpu/drm/msm/adreno/adreno_device.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/gpu/drm/msm/adreno/adreno_device.c b/drivers/gpu/drm/msm/adreno/adreno_device.c >> index 901ef767e491..e00eef8099ae 100644 >> --- a/drivers/gpu/drm/msm/adreno/adreno_device.c >> +++ b/drivers/gpu/drm/msm/adreno/adreno_device.c >> @@ -570,6 +570,10 @@ static const struct adreno_info gpulist[] = { >> .zapfw = "a740_zap.mdt", >> .hwcg = a740_hwcg, >> .address_space_size = SZ_16G, >> + .speedbins = ADRENO_SPEEDBINS( >> + { ADRENO_SKU_ID(SOCINFO_FC_AC), 0 }, >> + { ADRENO_SKU_ID(SOCINFO_FC_AF), 0 }, > > Did you really mean for these both to map to the same speedbin? Yes There were more entries previously but the info was unclear and different between BSPs.. For non-development SoCs it seems that "everything except FC_AC, FC_AF should be speedbin 1", but what the values are for said "everything" are not known, so that's an exercise left to the user.. Konrad