From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] ARM: dts: rockchip: reuse firefly dtsi Date: Wed, 19 Apr 2017 00:20:32 +0200 Message-ID: <746291609.ssvjv54Vin@phil> References: <20170418121527.3155-1-eddie.cai.linux@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20170418121527.3155-1-eddie.cai.linux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Eddie Cai Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Eddie, Am Dienstag, 18. April 2017, 20:15:27 CEST schrieb Eddie Cai: > firefly reload is very similar with firefly board, so reuse firefly dtsi > > Signed-off-by: Eddie Cai > --- > arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 310 ------------------ > arch/arm/boot/dts/rk3288-firefly-reload.dts | 368 ++-------------------- I would disagree and remember having a similar discussion when the reload- support was initially submitted. Please keep in mind that the firefly- reload is a som+baseboard combination, so somebody could (or maybe already has) create a completely different baseboard for the som that does not have any similarities with the original firefly. The previous firefly being a real single board. We also don't combine rock2 and firefly and other boards following the general rk3288 design guidelines :-) and the original firefly and reload are very different boards if you look at them. Heiko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html