devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: David Bauer <mail@david-bauer.net>,
	davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
	Pavel Machek <pavel@ucw.cz>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: net: add RTL8152 binding documentation
Date: Sat, 14 Aug 2021 20:33:56 +0200	[thread overview]
Message-ID: <74795336-e3fa-422f-0004-a8cb180d84bc@gmail.com> (raw)
In-Reply-To: <20210814181107.138992-1-mail@david-bauer.net>

On 14.08.2021 20:11, David Bauer wrote:
> Add binding documentation for the Realtek RTL8152 / RTL8153 USB ethernet
> adapters.
> 
> Signed-off-by: David Bauer <mail@david-bauer.net>
> ---
>  .../bindings/net/realtek,rtl8152.yaml         | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/realtek,rtl8152.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml
> new file mode 100644
> index 000000000000..ab760000b3a6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl8152.yaml
> @@ -0,0 +1,43 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/realtek,rtl8152.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Realtek RTL8152/RTL8153 series USB ethernet
> +
> +maintainers:
> +  - David Bauer <mail@david-bauer.net>
> +
> +properties:
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - realtek,rtl8152
> +              - realtek,rtl8153
> +
> +  reg:
> +    description: The device number on the USB bus
> +
> +  realtek,led-data:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Value to be written to the LED configuration register.
> +

+Pavel as LED subsystem maintainer

There's an ongoing discussion (with certain decisions taken already) about
how to configure network device LEDs.

> +required:
> +  - compatible
> +  - reg
> +
> +examples:
> +  - |
> +    usb@100 {
> +      reg = <0x100 0x100>;
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      usb-eth@2 {
> +        compatible = "realtek,rtl8153";
> +        reg = <0x2>;
> +        realtek,led-data = <0x87>;
> +      };
> +    };
> 


  parent reply	other threads:[~2021-08-14 18:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14 18:11 [PATCH 1/2] dt-bindings: net: add RTL8152 binding documentation David Bauer
2021-08-14 18:11 ` [PATCH 2/2] r8152: add LED configuration from OF David Bauer
2021-08-14 18:33 ` Heiner Kallweit [this message]
2021-08-14 22:26   ` [PATCH 1/2] dt-bindings: net: add RTL8152 binding documentation David Bauer
2021-08-14 23:00     ` Heiner Kallweit
2021-08-15 14:46 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74795336-e3fa-422f-0004-a8cb180d84bc@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mail@david-bauer.net \
    --cc=netdev@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).