* [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"
@ 2023-11-11 9:46 Krzysztof Kozlowski
2023-11-11 12:42 ` Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-11 9:46 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
Cc: Krzysztof Kozlowski
This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
The commit introduced unsupported and undocumented properties:
qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 7 -------
1 file changed, 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index c8cd40a462a3..3bd0c06e7315 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -1423,13 +1423,6 @@ PDO_FIXED_DUAL_ROLE |
PDO_FIXED_USB_COMM |
PDO_FIXED_DATA_SWAP)>;
- altmodes {
- displayport {
- svid = <0xff01>;
- vdo = <0x00001c46>;
- };
- };
-
ports {
#address-cells = <1>;
#size-cells = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"
2023-11-11 9:46 [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode" Krzysztof Kozlowski
@ 2023-11-11 12:42 ` Krzysztof Kozlowski
2023-11-13 10:09 ` Dmitry Baryshkov
2023-11-13 12:01 ` Konrad Dybcio
2 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-11 12:42 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel, Dmitry Baryshkov
On 11/11/2023 10:46, Krzysztof Kozlowski wrote:
> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
>
> The commit introduced unsupported and undocumented properties:
>
> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
I forgot to Cc Dmitry, author of reverted commit. I bounced the original
email to him and Cc-ing him here as well.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"
2023-11-11 9:46 [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode" Krzysztof Kozlowski
2023-11-11 12:42 ` Krzysztof Kozlowski
@ 2023-11-13 10:09 ` Dmitry Baryshkov
2023-11-13 12:02 ` Konrad Dybcio
2023-11-14 15:28 ` Krzysztof Kozlowski
2023-11-13 12:01 ` Konrad Dybcio
2 siblings, 2 replies; 6+ messages in thread
From: Dmitry Baryshkov @ 2023-11-13 10:09 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
>
> The commit introduced unsupported and undocumented properties:
>
> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'
We need this property to enable DP altmode on RB5. It has been parsed
by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add
typec_port_register_altmodes()"), merged in April 2021.
Rather than landing this commit, let me propose to send the proper
binding instead. If we can not agree on a compatible bindings document
within the sensible timeframe (e.g. 1 month), I'm fine with dropping
of the altmodes from qrb5156-rb5.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> index c8cd40a462a3..3bd0c06e7315 100644
> --- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> +++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
> @@ -1423,13 +1423,6 @@ PDO_FIXED_DUAL_ROLE |
> PDO_FIXED_USB_COMM |
> PDO_FIXED_DATA_SWAP)>;
>
> - altmodes {
> - displayport {
> - svid = <0xff01>;
> - vdo = <0x00001c46>;
> - };
> - };
> -
> ports {
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.34.1
>
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"
2023-11-13 10:09 ` Dmitry Baryshkov
@ 2023-11-13 12:02 ` Konrad Dybcio
2023-11-14 15:28 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-11-13 12:02 UTC (permalink / raw)
To: Dmitry Baryshkov, Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
On 13.11.2023 11:09, Dmitry Baryshkov wrote:
> On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
>>
>> The commit introduced unsupported and undocumented properties:
>>
>> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> We need this property to enable DP altmode on RB5. It has been parsed
> by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add
> typec_port_register_altmodes()"), merged in April 2021.
>
> Rather than landing this commit, let me propose to send the proper
> binding instead. If we can not agree on a compatible bindings document
> within the sensible timeframe (e.g. 1 month), I'm fine with dropping
> of the altmodes from qrb5156-rb5.
Right, I'dve imagined this was taken care of.. Retain my r-b but have what
Dmitry said in mind..
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"
2023-11-13 10:09 ` Dmitry Baryshkov
2023-11-13 12:02 ` Konrad Dybcio
@ 2023-11-14 15:28 ` Krzysztof Kozlowski
1 sibling, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-14 15:28 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 13/11/2023 11:09, Dmitry Baryshkov wrote:
> On Sat, 11 Nov 2023 at 11:46, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
>>
>> The commit introduced unsupported and undocumented properties:
>>
>> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> We need this property to enable DP altmode on RB5. It has been parsed
> by the typec subsystem since the commit 7b458a4c5d73 ("usb: typec: Add
> typec_port_register_altmodes()"), merged in April 2021.
>
> Rather than landing this commit, let me propose to send the proper
> binding instead. If we can not agree on a compatible bindings document
> within the sensible timeframe (e.g. 1 month), I'm fine with dropping
> of the altmodes from qrb5156-rb5.
I agree, sounds good for me. I just want to stir the pot and have the
issue resolved :)
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode"
2023-11-11 9:46 [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode" Krzysztof Kozlowski
2023-11-11 12:42 ` Krzysztof Kozlowski
2023-11-13 10:09 ` Dmitry Baryshkov
@ 2023-11-13 12:01 ` Konrad Dybcio
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2023-11-13 12:01 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 11.11.2023 10:46, Krzysztof Kozlowski wrote:
> This reverts commit b3dea914127e9065df003002ed13a2ef40d19877.
>
> The commit introduced unsupported and undocumented properties:
>
> qrb5165-rb5.dtb: pmic@2: typec@1500:connector: 'altmodes' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-11-14 15:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-11 9:46 [PATCH] arm64: dts: qcom: Revert "arm64: dts: qcom: qrb5165-rb5: enable DP altmode" Krzysztof Kozlowski
2023-11-11 12:42 ` Krzysztof Kozlowski
2023-11-13 10:09 ` Dmitry Baryshkov
2023-11-13 12:02 ` Konrad Dybcio
2023-11-14 15:28 ` Krzysztof Kozlowski
2023-11-13 12:01 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).