From: Alexey Charkov <alchark@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: rockchip: Add DSI LCD display on rk3576-evb1
Date: Mon, 20 Oct 2025 12:50:58 +0400 [thread overview]
Message-ID: <748fd61a-31fb-436f-b028-b47807a4860c@gmail.com> (raw)
In-Reply-To: <5143458.iZASKD2KPV@phil>
On Mon, Oct 20, 2025 at 12:31 PM Heiko Stuebner <heiko@sntech.de> wrote:
>
> Am Montag, 20. Oktober 2025, 10:19:51 Mitteleuropäische Sommerzeit schrieb Alexey Charkov:
> > On Thu, Sep 25, 2025 at 12:38 AM Alexey Charkov <alchark@gmail.com> wrote:
> > >
> > > Add support for the Rockchip W552793DBA-V10 LCD+touchscreen assembly which
> > > comes physically attached to Rockchip RK3576 EVB1 boards.
> > >
> > > The display part is driven by the on-chip MIPI DSI controller, and the
> > > touchscreen is connected over I2C.
> > >
> > > Signed-off-by: Alexey Charkov <alchark@gmail.com>
> > > ---
> > > Note that backlight support is left out for now, as it depends on PWM
> > > support [0] which has not yet been merged.
> > >
> > > A workaround is simply `gpioset -c 0 13=1` to set the respective GPIO
> > > pin high and thus to light up the display unconditionally.
> > >
> > > [0] https://lore.kernel.org/lkml/20250602-rk3576-pwm-v2-0-a6434b0ce60c@collabora.com/
> > > ---
> > > arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 89 ++++++++++++++++++++++++
> > > 1 file changed, 89 insertions(+)
> >
> > Hi Heiko,
> >
> > Any thoughts about this one? Can we perhaps get it merged for -next?
>
> Does the gpio-backlight work on that device?
> That would make the gpioset hack unnecessary.
I've got a local patch using pwm-gpio and pwm-backlight as a stop-gap
solution, but I don't think it's worth merging upstream, because the
backlight is supposed to be driven by the hardware PWM on the same pin
(not bit-banging the GPIO line). After all, Nicolas has been working on
adding a proper hardware PWM driver for RK3576.
The display itself works without PWM support, and so does the touchscreen.
My temp patch goes like this:
---
arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
index f20cd6f2c079..5c27fff03569 100644
--- a/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3576-evb1-v10.dts
@@ -58,6 +58,14 @@ button-vol-up {
};
};
+ backlight: backlight {
+ compatible = "pwm-backlight";
+ brightness-levels = <20 220>;
+ default-brightness-level = <100>;
+ num-interpolated-steps = <200>;
+ pwms = <&lcd_bl_pwm 0 25000 0>;
+ };
+
hdmi-con {
compatible = "hdmi-connector";
type = "a";
@@ -78,6 +86,12 @@ work_led: led-0 {
};
};
+ lcd_bl_pwm: pwm {
+ #pwm-cells = <3>;
+ compatible = "pwm-gpio";
+ gpios = <&gpio0 RK_PB5 GPIO_ACTIVE_HIGH>;
+ };
+
vbus5v0_typec: regulator-vbus5v0-typec {
compatible = "regulator-fixed";
regulator-name = "vbus5v0_typec";
@@ -277,6 +291,7 @@ panel@0 {
compatible = "wanchanglong,w552793baa", "raydium,rm67200";
reg = <0>;
+ backlight = <&backlight>;
iovcc-supply = <&vcc3v3_lcd_n>;
reset-gpios = <&gpio3 RK_PB5 GPIO_ACTIVE_LOW>;
vdd-supply = <&vcc3v3_lcd_n>;
--
Best regards,
Alexey
next prev parent reply other threads:[~2025-10-20 8:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 20:38 [PATCH] arm64: dts: rockchip: Add DSI LCD display on rk3576-evb1 Alexey Charkov
2025-10-20 8:19 ` Alexey Charkov
2025-10-20 8:31 ` Heiko Stuebner
2025-10-20 8:50 ` Alexey Charkov [this message]
2025-10-20 12:31 ` Heiko Stuebner
2025-10-21 15:08 ` Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=748fd61a-31fb-436f-b028-b47807a4860c@gmail.com \
--to=alchark@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).