From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 225F3C433EF for ; Fri, 5 Nov 2021 16:03:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E97C46127A for ; Fri, 5 Nov 2021 16:03:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231728AbhKEQGS (ORCPT ); Fri, 5 Nov 2021 12:06:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48880 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231184AbhKEQGS (ORCPT ); Fri, 5 Nov 2021 12:06:18 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56FF5C061205 for ; Fri, 5 Nov 2021 09:03:38 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id b184-20020a1c1bc1000000b0033140bf8dd5so6745322wmb.5 for ; Fri, 05 Nov 2021 09:03:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=s68XxEAQVTsbV0tiQ0iC8ThpTbLQFrCbAZYJOejjuWU=; b=WZNy4+rVsDTNDm9cYERP4vmFEuI5AYOyn6O+Fm8jDDNB4DPKNk3+wNX3QBRg0oiPLV ElOLuPozvQJ2xRfo597DUFJHrpCk0yIxEVCInREkf0a4HFyNnwAuAlGuf7ZHA0mQrT7y qFnlc296uLGzOc4ys0WtehThiUh0gSSVA8NjHkSOwa6wX/GOt+Y2TOkftC9qG3l2wiKC rZ7ckF4ezvs144xYLRost6UaGvjpVqW6FhSJRpAzrv+VVFgHhTSI3w/InkASTuZ5MRJo rA0v7ZT0oHFrkI9E7Rq4mhjD/t99LmFGHpimIsLZQSe3qU/LuCZsBc575c26Lpp8EmtZ 6csg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=s68XxEAQVTsbV0tiQ0iC8ThpTbLQFrCbAZYJOejjuWU=; b=5DwabiIJgY7tEldVdsr2V3bSj5P7TQCy6Uhz684+fTeNR+OraInF01x6MbiQe+QHEc 83ghqvzATd1hwiBgtxt+4YrxdV/ePxdkuGhf0R8UgO2Rx7oVC0pnE3uMZb5UfLzHrixv QGpoM7M1fXH9D+oHygDyj2KacfBvYTd4MgZQ+0JfC0f80Cf8HC9nqdbm59wNsLeqXsJ1 CmVJqSviYOTcNymJZ8fvYI6DseTY1gFTAFafat6PJ/XAZP6wWgU59WY+zvo4jJPsqLP0 7WTyHdkcimGPdeF6nxDfn/cLEZv/JY7Gf+uluACA2oX8ghOoXYBcQ7oHvNXPKvlWL2Fr iuIA== X-Gm-Message-State: AOAM533OuWCbf+MUn7KZ7Qe1RCXgQ5MOkdoHtJ5Ejjpt6APttBWDLI6c QRy4GnRTv7AGv5HmVVqotwa3Xw== X-Google-Smtp-Source: ABdhPJwk5F9B0etWwFBCXvheHF5J5gH7BY6sepmL4k2YFCG8vTHMM7lBF6xaLxyQR3GplJclTlSZvg== X-Received: by 2002:a1c:447:: with SMTP id 68mr31515335wme.69.1636128216838; Fri, 05 Nov 2021 09:03:36 -0700 (PDT) Received: from [192.168.0.162] (188-141-3-169.dynamic.upc.ie. [188.141.3.169]) by smtp.gmail.com with ESMTPSA id h7sm8044083wrt.64.2021.11.05.09.03.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Nov 2021 09:03:36 -0700 (PDT) Message-ID: <749a058d-a16d-3a92-25b6-97afcfaa7787@linaro.org> Date: Fri, 5 Nov 2021 16:05:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.1 Subject: Re: [PATCH v3 6/7] usb: typec: qcom: Remove standalone qcom pm8150b typec driver Content-Language: en-US To: Heikki Krogerus Cc: linux@roeck-us.net, gregkh@linuxfoundation.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, wcheng@codeaurora.org References: <20211105033558.1573552-1-bryan.odonoghue@linaro.org> <20211105033558.1573552-7-bryan.odonoghue@linaro.org> From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org >> >> I don't like that you create point where the support is temporarily >> removed for this hardware. I know Guenter asked that you remove the >> old driver in a separate patch, but I believe at that point you were >> also proposing different config option name for the new driver, so you >> could have removed the old driver only after you added the new one. >> >> Since you now use the same configuration option name - which makes >> perfect sense to me - I think you need to refactor this series. Maybe >> you could first just move the old driver under drivers/usb/typec/tcpm/ >> in one patch, and then modify and slit it in another patch. No problem with this in principle > Or just merge this patch to the next one. I think this for preference unless Guenter has an objection .. easier/less work --- bod