Re: [PATCH v4 8/8] dt-bindings: Add rt5033 mfd, regulator and charger

[Jakob Hauser <jahau@rocketmail.com>]

Hi Krzysztof,

On 09.05.23 11:18, Krzysztof Kozlowski wrote:
> On 06/05/2023 17:54, Jakob Hauser wrote:

...

>> diff --git a/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml b/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml
>> new file mode 100644
>> index 000000000000..b8607cc6ec63
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/power/supply/richtek,rt5033-charger.yaml
>> @@ -0,0 +1,64 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/power/supply/richtek,rt5033-charger.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Richtek RT5033 PIMC Battery Charger
> 
> PMIC

Good catch.

>> +
>> +maintainers:
>> +  - Jakob Hauser <jahau@rocketmail.com>
>> +
>> +description:
>> +  The battery charger of the multifunction device RT5033 has to be instantiated
>> +  under sub-node named "charger" using the following format.
>> +
>> +properties:
>> +  compatible:
>> +    const: richtek,rt5033-charger
>> +
>> +  monitored-battery:
>> +    description: |
>> +      Phandle to the monitored battery according to battery.yaml. The battery
>> +      node needs to contain five parameters.
>> +
>> +      precharge-current-microamp:
>> +      Current of pre-charge mode. The pre-charge current levels are 350 mA
>> +      to 650 mA programmed by I2C per 100 mA.
>> +
>> +      constant-charge-current-max-microamp:
>> +      Current of fast-charge mode. The fast-charge current levels are 700 mA
>> +      to 2000 mA programmed by I2C per 100 mA.
>> +
>> +      charge-term-current-microamp:
>> +      This property is end of charge current. Its level ranges from 150 mA
>> +      to 600 mA. Between 150 mA and 300 mA in 50 mA steps, between 300 mA and
>> +      600 mA in 100 mA steps.
>> +
>> +      precharge-upper-limit-microvolt:
>> +      Voltage of pre-charge mode. If the battery voltage is below the pre-charge
>> +      threshold voltage, the charger is in pre-charge mode with pre-charge
>> +      current. Its levels are 2.3 V to 3.8 V programmed by I2C per 0.1 V.
>> +
>> +      constant-charge-voltage-max-microvolt:
>> +      Battery regulation voltage of constant voltage mode. This voltage levels
>> +      from 3.65 V to 4.4 V by I2C per 0.025 V.
>> +
>> +  connector:
>> +    description:
>> +      Phandle to a USB connector according to usb-connector.yaml. The connector
>> +      should be a child of the extcon device.
>> +    maxItems: 1
> 
> Missing type/ref... but then you will notice you have conflicting ref
> with existing connector. connector is usb-connector.yaml, not phandle. I
> am not sure if we need generic property, so let's go with device
> specific - richtek,usb-connector

Actually, as we already switched to the connector thing, I would have 
liked to do it properly, if at all. Again looking for examples how it 
should be done, the usb-connector.yaml schema gets mostly used in the 
USB and PHY domain. Those examples don't fit the specific case well. I 
didn't find examples in the power supply domain.

Therefore, giving in, I'll chage it to richtek,usb-connector.

It's still hard for me to understand why phandle excton shouldn't fit 
the specific simple case. Now we have neither a proper "connector" thing 
nor a simple extcon phandle.

...

Kind regards,
Jakob