From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222CCC0015E for ; Wed, 19 Jul 2023 19:05:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230179AbjGSTF1 (ORCPT ); Wed, 19 Jul 2023 15:05:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229540AbjGSTF1 (ORCPT ); Wed, 19 Jul 2023 15:05:27 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 680DB1BF3 for ; Wed, 19 Jul 2023 12:05:25 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b700e85950so107508211fa.3 for ; Wed, 19 Jul 2023 12:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689793523; x=1692385523; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=Uxzu4bTwNO5BdcIxJkw1/nWB+CP9FwcUhHLLgewCkgw=; b=bhII2Uj+TkgnIjMm9sToEM5IW39MSLgMv2SVJAXa7OF8jwzzINNd/XuigFxHQKUOGi PcMsH5te8ILc8UFlgsgn1LPxw76s/7v+Kwz6nRfJmqRLmByrpsBR4DXLXPfaQ9goWtGq 8qATDajVQY90BOwRwW0UGOLFm8OwZ/2KVRBYZv2hDKojVbQtxFvKaidB9AOORwelCPJ1 VkYNVU0PqX7lysKjjmRT71I/8Fux5AERdcvGlnVZKELBP89KbrGah/2JgTAZwrlmo6ed Cmmdrl7XM0KOvdPco4h+qiz0C8/Wj7WoKGEiuK0Zve4LUntVjUJGnZWwtlO2cQjqtxav nXsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689793523; x=1692385523; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uxzu4bTwNO5BdcIxJkw1/nWB+CP9FwcUhHLLgewCkgw=; b=B8hqQqjwSsuc3AgmoPuaNsWxL7y+LlyfM11CItWUSovf3clAgmXXZdDTjsbuzwn+dN WQiw4MtVB/H5Vy7K+FZT9QuynkAGGzTeZlzRHj3kr8INPf1u6CnBsL9suJQuRlldlB2K mUDfje+daAHArd2eCsgXhOzvfXJulJgLpM1p9tJdssBwbEEz6mQlTS/9cWrYNonTWPZB QczvrTQIpTFJY0G008jmlReAMRHcbwzu2YdZDugK2Y1xsdBlDUNwAoLDzK1JU7oazKWe eWZf2CvtSyx5dl8lI/UbR9YD3XQPel9G0wf916oFude4dv/0oQstd+4tq6abEGxL0rXk 66hA== X-Gm-Message-State: ABy/qLbkBK7yvIklLxDn43+pF8pdG+HkJjXWvUKeyCBchOg1ztnIxGBT JeYdG7HI3urVatmP3MIRdJxcsg== X-Google-Smtp-Source: APBJJlHfDiWa6z/RIaWmCgcjPLMVIlHwrtDTsbKJH/hNfg/cg6myuLG7psXda3yupTjsCaobBA3dfw== X-Received: by 2002:a2e:99cd:0:b0:2b7:14d4:ce6d with SMTP id l13-20020a2e99cd000000b002b714d4ce6dmr613499ljj.48.1689793523679; Wed, 19 Jul 2023 12:05:23 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id gx3-20020a170906f1c300b00993cc1242d4sm2692809ejb.151.2023.07.19.12.05.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Jul 2023 12:05:23 -0700 (PDT) Message-ID: <74f81a77-6cba-37eb-54ed-e7570db47632@linaro.org> Date: Wed, 19 Jul 2023 21:05:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2 2/3] pinctrl: qcom: sm8350-lpass-lpi: add SM8350 LPASS TLMM To: Konrad Dybcio , Bjorn Andersson , Andy Gross , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230619092735.20323-1-krzysztof.kozlowski@linaro.org> <20230619092735.20323-2-krzysztof.kozlowski@linaro.org> <851790f2-f673-f754-08b8-d07cc2c809fb@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: <851790f2-f673-f754-08b8-d07cc2c809fb@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 24/06/2023 14:12, Konrad Dybcio wrote: > On 19.06.2023 11:27, Krzysztof Kozlowski wrote: >> Add driver for pin controller in Low Power Audio SubSystem (LPASS). The >> driver is similar to SM8250 LPASS pin controller, with difference in one >> new pin (gpio14). >> > < LPI_MUX_swr_tx_data2, > 54d52 > < static int gpio14_pins[] = { 14 }; > 71d68 > < PINCTRL_PIN(14, "gpio14"), > 75c72 > < static const char * const swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio5", "gpio14" }; > --- >> static const char * const swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio5" }; > 111d107 > < LPI_PINGROUP(14, 6, swr_rx_data, _, _, _), > > > > I really think adding just these pin14 entries to the 8250 driver would > be a good idea.. > I could extend arrays with gpio14 and pass array size -1 to sm8250 variant and full size to sm8350. However the difference will be in: -static const char * const swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio5" }; +static const char * const swr_tx_data_groups[] = { "gpio1", "gpio2", "gpio5", "gpio14" }; I cannot create here variant "swr_tx_data_groups_sm8350" because the name is used in macros. Using bigger (with gpio14) group for sm8250 should work, because there is no gpio14, but produces difference in the controller: -/sys/kernel/debug/pinctrl/33c0000.pinctrl/pinmux-functions:function 18: swr_tx_data, groups = [ gpio1 gpio2 gpio5 ] +/sys/kernel/debug/pinctrl/33c0000.pinctrl/pinmux-functions:function 18: swr_tx_data, groups = [ gpio1 gpio2 gpio5 gpio14 ] Therefore I will go with separate drivers. Best regards, Krzysztof