From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Okan Sahin <okan.sahin@analog.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"open list:VOLTAGE AND CURRENT REGULATOR FRAMEWORK"
<linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 4/5] dt-bindings: regulator: adi,max77541-regulator.yaml Add MAX77541 Regulator bindings
Date: Tue, 27 Dec 2022 08:56:32 +0100 [thread overview]
Message-ID: <74fd9706-119e-c6c3-4c64-c7ee419ce4bb@linaro.org> (raw)
In-Reply-To: <20221226223839.103460-5-okan.sahin@analog.com>
On 26/12/2022 23:38, Okan Sahin wrote:
> The bindings for MAX77541 and MAX77540
> regulator drivers.
1. Again:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
2. Please wrap commit message according to Linux coding style /
submission process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
3. Subject: drop second, redundant "bindings".
>
> Signed-off-by: Okan Sahin <okan.sahin@analog.com>
> ---
> .../regulator/adi,max77541-regulator.yaml | 44 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 45 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml
>
> diff --git a/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml b/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml
> new file mode 100644
> index 000000000000..67d48bfcb627
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/adi,max77541-regulator.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/regulator/adi,max77541-regulator.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Buck Converter for MAX77540/MAX77541
> +
> +maintainers:
> + - Okan Sahin <okan.sahin@analog.com>
> +
> +description: |
> + This is a part of device tree bindings for ADI MAX77540/MAX77541
> +
> + The buck converter is represented as a sub-node of the PMIC node on the device tree.
> +
> + The device has two buck regulators.
> + See also Documentation/devicetree/bindings/mfd/adi,max77541.yaml for
> + additional information and example.
> +
> +properties:
> + compatible:
> + enum:
> + - adi,max77540-regulator
> + - adi,max77541-regulator
> +
> +patternProperties:
> + "^BUCK[12]$":
Old DT example was correct - lowercase node names.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-27 7:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221226223839.103460-1-okan.sahin@analog.com>
2022-12-26 22:38 ` [PATCH v2 2/5] dt-bindings: mfd: adi,max77541.yaml Add MAX77541 bindings Okan Sahin
2022-12-27 7:53 ` Krzysztof Kozlowski
2023-01-15 17:40 ` Sahin, Okan
2023-01-15 19:16 ` Krzysztof Kozlowski
2022-12-28 0:27 ` Rob Herring
2022-12-26 22:38 ` [PATCH v2 4/5] dt-bindings: regulator: adi,max77541-regulator.yaml Add MAX77541 Regulator bindings Okan Sahin
2022-12-27 7:56 ` Krzysztof Kozlowski [this message]
2023-01-15 17:41 ` Sahin, Okan
2023-01-15 19:12 ` Krzysztof Kozlowski
2022-12-29 4:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74fd9706-119e-c6c3-4c64-c7ee419ce4bb@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=okan.sahin@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).