* [PATCH v2 0/3] clocksource: Document Renesas SoC specific bindings
@ 2014-09-04 0:55 Simon Horman
2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Simon Horman @ 2014-09-04 0:55 UTC (permalink / raw)
To: linux-sh
Cc: linux-arm-kernel, Magnus Damm, devicetree, Laurent Pinchart,
Geert Uytterhoeven, Mark Rutland, Sergei Shtylyov, Simon Horman
In general Renesas hardware is not documented to the extent where the
relationship between IP blocks on different SoCs can be assumed although
they may appear to operate the same way. Furthermore the documentation
typically does not specify a version for individual IP blocks. For these
reasons a convention of using the SoC name in place of a version and
providing SoC-specific compat strings has been adopted.
Although not universally liked this convention is used in the bindings for
a number of drivers for Renesas hardware. The purpose of this patch is to
update the Renesas clocksource drivers to follow this convention.
I plan to follow up with patches to use these new bindings in the
dtsi files for the affected SoCs.
Changes between v1 and v2:
* Addressed feedback from Sergei Shtylyov, Geert Uytterhoeven and
Mark Rutland: corrected editing errors and generally made
things clearer.
Simon Horman (3):
clocksource: sh_cmt: Document SoC specific bindings
clocksource: sh_mtu2: Document r7s72100 binding
clocksource: sh_tmu: Document r8a7779 binding
.../devicetree/bindings/timer/renesas,cmt.txt | 44 +++++++++++++++++++---
.../devicetree/bindings/timer/renesas,mtu2.txt | 6 ++-
.../devicetree/bindings/timer/renesas,tmu.txt | 6 ++-
3 files changed, 46 insertions(+), 10 deletions(-)
--
2.0.1
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH v2 1/3] clocksource: sh_cmt: Document SoC specific bindings 2014-09-04 0:55 [PATCH v2 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman @ 2014-09-04 0:55 ` Simon Horman 2014-09-04 6:51 ` Laurent Pinchart 2014-09-04 6:58 ` Laurent Pinchart 2014-09-04 0:55 ` [PATCH v2 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman 2014-09-04 0:55 ` [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman 2 siblings, 2 replies; 9+ messages in thread From: Simon Horman @ 2014-09-04 0:55 UTC (permalink / raw) To: linux-sh Cc: linux-arm-kernel, Magnus Damm, devicetree, Laurent Pinchart, Geert Uytterhoeven, Mark Rutland, Sergei Shtylyov, Simon Horman In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted. Although not universally liked this convention is used in the bindings for a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Compare Match Timer (CMT) driver to follow this convention. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> Acked-by: Mark Rutland <mark.rutland@arm.com> --- * I plan to follow up with patches to use these new bindings in the dtsi files for the affected SoCs. v2 * Reorder compat entries so more-specific entries and their fallbacks are grouped with the fallback entry coming last. * Explicitly document fallback --- .../devicetree/bindings/timer/renesas,cmt.txt | 44 +++++++++++++++++++--- 1 file changed, 38 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt b/Documentation/devicetree/bindings/timer/renesas,cmt.txt index a17418b..7b44f4b 100644 --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt @@ -11,15 +11,47 @@ datasheets. Required Properties: - - compatible: must contain one of the following. - - "renesas,cmt-32" for the 32-bit CMT + - compatible: must contain one or more of the following: + - "renesas,cmt-32-r8a7740" for the R8a7740 32-bit CMT + (CMT0) + - "renesas,cmt-32-sh7372" for the SH7372 32-bit CMT + (CMT0) + - "renesas,cmt-32-sh73a0" for the SH73a0 32-bit CMT + (CMT0) + - "renesas,cmt-32" for all 32-bit CMT without fast clock support (CMT0 on sh7372, sh73a0 and r8a7740) - - "renesas,cmt-32-fast" for the 32-bit CMT with fast clock support + This is a fallback for the above renesas,cmt-32-* entries. + + - "renesas,cmt-32-fast-r8a7740" for the R8A7740 32-bit CMT with fast + clock support (CMT[234]) + - "renesas,cmt-32-fast-sh7372" for the SH7372 32-bit CMT with fast + clock support (CMT[234]) + - "renesas,cmt-32-fast-sh73a0" for the SH73A0 32-bit CMT with fast + clock support (CMT[234]) + - "renesas,cmt-32-fast" for all 32-bit CMT with fast clock support (CMT[234] on sh7372, sh73a0 and r8a7740) - - "renesas,cmt-48" for the 48-bit CMT + This is a fallback for the above renesas,cmt-32-fast-* entries. + + - "renesas,cmt-48-sh7372" for the SH7372 48-bit CMT + (CMT1) + - "renesas,cmt-48-sh73a0" for the SH73A0 48-bit CMT + (CMT1) + - "renesas,cmt-48-r8a7740" for the R8A7740 48-bit CMT + (CMT1) + - "renesas,cmt-48" for all non-second generation 48-bit CMT (CMT1 on sh7372, sh73a0 and r8a7740) - - "renesas,cmt-48-gen2" for the second generation 48-bit CMT + This is a fallback for the above renesas,cmt-48-* entries. + + - "renesas,cmt-48-r8a73a4" for the R8A73A4 48-bit CMT + (CMT[01]) + - "renesas,cmt-48-r8a7790" for the R8A7790 48-bit CMT + (CMT[01]) + - "renesas,cmt-48-r8a7791" for the R8A7791 48-bit CMT + (CMT[01]) + - "renesas,cmt-48-gen2" for all second generation 48-bit CMT (CMT[01] on r8a73a4, r8a7790 and r8a7791) + This is a fallback for the renesas,cmt-48-r8a73a4, + renesas,cmt-48-r8a7790 and renesas,cmt-48-gen2 entries. - reg: base address and length of the registers block for the timer module. - interrupts: interrupt-specifier for the timer, one per channel. @@ -36,7 +68,7 @@ Example: R8A7790 (R-Car H2) CMT0 node them channels 0 and 1 in the documentation. cmt0: timer@ffca0000 { - compatible = "renesas,cmt-48-gen2"; + compatible = "renesas,cmt-48-r8a7790", "renesas,cmt-48-gen2"; reg = <0 0xffca0000 0 0x1004>; interrupts = <0 142 IRQ_TYPE_LEVEL_HIGH>, <0 142 IRQ_TYPE_LEVEL_HIGH>; -- 2.0.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] clocksource: sh_cmt: Document SoC specific bindings 2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman @ 2014-09-04 6:51 ` Laurent Pinchart 2014-09-04 6:58 ` Laurent Pinchart 1 sibling, 0 replies; 9+ messages in thread From: Laurent Pinchart @ 2014-09-04 6:51 UTC (permalink / raw) To: Simon Horman, Geert Uytterhoeven Cc: linux-sh, linux-arm-kernel, Magnus Damm, devicetree, Mark Rutland, Sergei Shtylyov Hi Simon, Thank you for the patch. On Thursday 04 September 2014 09:55:19 Simon Horman wrote: > In general Renesas hardware is not documented to the extent > where the relationship between IP blocks on different SoCs can be assumed > although they may appear to operate the same way. Furthermore the > documentation typically does not specify a version for individual > IP blocks. For these reasons a convention of using the SoC name in place > of a version and providing SoC-specific compat strings has been adopted. > > Although not universally liked this convention is used in the bindings for > a number of drivers for Renesas hardware. The purpose of this patch is to > update the Renesas R-Car Compare Match Timer (CMT) driver to follow this > convention. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Mark Rutland <mark.rutland@arm.com> > > --- > * I plan to follow up with patches to use these new bindings in the > dtsi files for the affected SoCs. > > v2 > * Reorder compat entries so more-specific entries and their fallbacks > are grouped with the fallback entry coming last. > * Explicitly document fallback > --- > .../devicetree/bindings/timer/renesas,cmt.txt | 44 ++++++++++++++++--- > 1 file changed, 38 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > b/Documentation/devicetree/bindings/timer/renesas,cmt.txt index > a17418b..7b44f4b 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > @@ -11,15 +11,47 @@ datasheets. > > Required Properties: > > - - compatible: must contain one of the following. > - - "renesas,cmt-32" for the 32-bit CMT > + - compatible: must contain one or more of the following: > + - "renesas,cmt-32-r8a7740" for the R8a7740 32-bit CMT > + (CMT0) > + - "renesas,cmt-32-sh7372" for the SH7372 32-bit CMT > + (CMT0) > + - "renesas,cmt-32-sh73a0" for the SH73a0 32-bit CMT > + (CMT0) > + - "renesas,cmt-32" for all 32-bit CMT without fast clock support > (CMT0 on sh7372, sh73a0 and r8a7740) > - - "renesas,cmt-32-fast" for the 32-bit CMT with fast clock support > + This is a fallback for the above renesas,cmt-32-* entries. > + > + - "renesas,cmt-32-fast-r8a7740" for the R8A7740 32-bit CMT with fast > + clock support (CMT[234]) > + - "renesas,cmt-32-fast-sh7372" for the SH7372 32-bit CMT with fast > + clock support (CMT[234]) > + - "renesas,cmt-32-fast-sh73a0" for the SH73A0 32-bit CMT with fast > + clock support (CMT[234]) > + - "renesas,cmt-32-fast" for all 32-bit CMT with fast clock support > (CMT[234] on sh7372, sh73a0 and r8a7740) > - - "renesas,cmt-48" for the 48-bit CMT > + This is a fallback for the above renesas,cmt-32-fast-* entries. > + > + - "renesas,cmt-48-sh7372" for the SH7372 48-bit CMT > + (CMT1) > + - "renesas,cmt-48-sh73a0" for the SH73A0 48-bit CMT > + (CMT1) > + - "renesas,cmt-48-r8a7740" for the R8A7740 48-bit CMT > + (CMT1) > + - "renesas,cmt-48" for all non-second generation 48-bit CMT > (CMT1 on sh7372, sh73a0 and r8a7740) > - - "renesas,cmt-48-gen2" for the second generation 48-bit CMT > + This is a fallback for the above renesas,cmt-48-* entries. > + > + - "renesas,cmt-48-r8a73a4" for the R8A73A4 48-bit CMT > + (CMT[01]) > + - "renesas,cmt-48-r8a7790" for the R8A7790 48-bit CMT > + (CMT[01]) > + - "renesas,cmt-48-r8a7791" for the R8A7791 48-bit CMT > + (CMT[01]) > + - "renesas,cmt-48-gen2" for all second generation 48-bit CMT > (CMT[01] on r8a73a4, r8a7790 and r8a7791) > + This is a fallback for the renesas,cmt-48-r8a73a4, > + renesas,cmt-48-r8a7790 and renesas,cmt-48-gen2 entries. If renesas,cmt-48-gen2 is a fallback for renesas,cmt-48-gen2, we'll have an infinite loop :-) I suppose you meant This is a fallback for the renesas,cmt-48-r8a73a4, renesas,cmt-48-r8a7790 and renesas,cmt-48-r8a7791 entries. With that change, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > - reg: base address and length of the registers block for the timer > module. - interrupts: interrupt-specifier for the timer, one per channel. > @@ -36,7 +68,7 @@ Example: R8A7790 (R-Car H2) CMT0 node > them channels 0 and 1 in the documentation. > > cmt0: timer@ffca0000 { > - compatible = "renesas,cmt-48-gen2"; > + compatible = "renesas,cmt-48-r8a7790", "renesas,cmt-48-gen2"; > reg = <0 0xffca0000 0 0x1004>; > interrupts = <0 142 IRQ_TYPE_LEVEL_HIGH>, > <0 142 IRQ_TYPE_LEVEL_HIGH>; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] clocksource: sh_cmt: Document SoC specific bindings 2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman 2014-09-04 6:51 ` Laurent Pinchart @ 2014-09-04 6:58 ` Laurent Pinchart 2014-09-06 1:14 ` Simon Horman 1 sibling, 1 reply; 9+ messages in thread From: Laurent Pinchart @ 2014-09-04 6:58 UTC (permalink / raw) To: Simon Horman Cc: linux-sh, linux-arm-kernel, Magnus Damm, devicetree, Laurent Pinchart, Geert Uytterhoeven, Mark Rutland, Sergei Shtylyov Hi Simon, A couple of other small issues I've missed. On Thursday 04 September 2014 09:55:19 Simon Horman wrote: > In general Renesas hardware is not documented to the extent > where the relationship between IP blocks on different SoCs can be assumed > although they may appear to operate the same way. Furthermore the > documentation typically does not specify a version for individual > IP blocks. For these reasons a convention of using the SoC name in place > of a version and providing SoC-specific compat strings has been adopted. > > Although not universally liked this convention is used in the bindings for > a number of drivers for Renesas hardware. The purpose of this patch is to > update the Renesas R-Car Compare Match Timer (CMT) driver to follow this > convention. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > Acked-by: Mark Rutland <mark.rutland@arm.com> > > --- > * I plan to follow up with patches to use these new bindings in the > dtsi files for the affected SoCs. > > v2 > * Reorder compat entries so more-specific entries and their fallbacks > are grouped with the fallback entry coming last. > * Explicitly document fallback > --- > .../devicetree/bindings/timer/renesas,cmt.txt | 44 ++++++++++++++++--- > 1 file changed, 38 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > b/Documentation/devicetree/bindings/timer/renesas,cmt.txt index > a17418b..7b44f4b 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > @@ -11,15 +11,47 @@ datasheets. > > Required Properties: > > - - compatible: must contain one of the following. > - - "renesas,cmt-32" for the 32-bit CMT > + - compatible: must contain one or more of the following: > + - "renesas,cmt-32-r8a7740" for the R8a7740 32-bit CMT s/R8a7740/R8A7740/ > + (CMT0) > + - "renesas,cmt-32-sh7372" for the SH7372 32-bit CMT > + (CMT0) > + - "renesas,cmt-32-sh73a0" for the SH73a0 32-bit CMT s/SH73a0/SH73A0/ > + (CMT0) > + - "renesas,cmt-32" for all 32-bit CMT without fast clock support > (CMT0 on sh7372, sh73a0 and r8a7740) > - - "renesas,cmt-32-fast" for the 32-bit CMT with fast clock support > + This is a fallback for the above renesas,cmt-32-* entries. > + > + - "renesas,cmt-32-fast-r8a7740" for the R8A7740 32-bit CMT with fast > + clock support (CMT[234]) > + - "renesas,cmt-32-fast-sh7372" for the SH7372 32-bit CMT with fast > + clock support (CMT[234]) > + - "renesas,cmt-32-fast-sh73a0" for the SH73A0 32-bit CMT with fast > + clock support (CMT[234]) > + - "renesas,cmt-32-fast" for all 32-bit CMT with fast clock support > (CMT[234] on sh7372, sh73a0 and r8a7740) > - - "renesas,cmt-48" for the 48-bit CMT > + This is a fallback for the above renesas,cmt-32-fast-* entries. > + > + - "renesas,cmt-48-sh7372" for the SH7372 48-bit CMT > + (CMT1) > + - "renesas,cmt-48-sh73a0" for the SH73A0 48-bit CMT > + (CMT1) > + - "renesas,cmt-48-r8a7740" for the R8A7740 48-bit CMT > + (CMT1) > + - "renesas,cmt-48" for all non-second generation 48-bit CMT > (CMT1 on sh7372, sh73a0 and r8a7740) > - - "renesas,cmt-48-gen2" for the second generation 48-bit CMT > + This is a fallback for the above renesas,cmt-48-* entries. > + > + - "renesas,cmt-48-r8a73a4" for the R8A73A4 48-bit CMT > + (CMT[01]) > + - "renesas,cmt-48-r8a7790" for the R8A7790 48-bit CMT > + (CMT[01]) > + - "renesas,cmt-48-r8a7791" for the R8A7791 48-bit CMT > + (CMT[01]) > + - "renesas,cmt-48-gen2" for all second generation 48-bit CMT > (CMT[01] on r8a73a4, r8a7790 and r8a7791) > + This is a fallback for the renesas,cmt-48-r8a73a4, > + renesas,cmt-48-r8a7790 and renesas,cmt-48-gen2 entries. > > - reg: base address and length of the registers block for the timer > module. - interrupts: interrupt-specifier for the timer, one per channel. > @@ -36,7 +68,7 @@ Example: R8A7790 (R-Car H2) CMT0 node > them channels 0 and 1 in the documentation. > > cmt0: timer@ffca0000 { > - compatible = "renesas,cmt-48-gen2"; > + compatible = "renesas,cmt-48-r8a7790", "renesas,cmt-48-gen2"; > reg = <0 0xffca0000 0 0x1004>; > interrupts = <0 142 IRQ_TYPE_LEVEL_HIGH>, > <0 142 IRQ_TYPE_LEVEL_HIGH>; -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 1/3] clocksource: sh_cmt: Document SoC specific bindings 2014-09-04 6:58 ` Laurent Pinchart @ 2014-09-06 1:14 ` Simon Horman 0 siblings, 0 replies; 9+ messages in thread From: Simon Horman @ 2014-09-06 1:14 UTC (permalink / raw) To: Laurent Pinchart Cc: linux-sh, linux-arm-kernel, Magnus Damm, devicetree, Laurent Pinchart, Geert Uytterhoeven, Mark Rutland, Sergei Shtylyov On Thu, Sep 04, 2014 at 09:58:40AM +0300, Laurent Pinchart wrote: > Hi Simon, > > A couple of other small issues I've missed. > > On Thursday 04 September 2014 09:55:19 Simon Horman wrote: > > In general Renesas hardware is not documented to the extent > > where the relationship between IP blocks on different SoCs can be assumed > > although they may appear to operate the same way. Furthermore the > > documentation typically does not specify a version for individual > > IP blocks. For these reasons a convention of using the SoC name in place > > of a version and providing SoC-specific compat strings has been adopted. > > > > Although not universally liked this convention is used in the bindings for > > a number of drivers for Renesas hardware. The purpose of this patch is to > > update the Renesas R-Car Compare Match Timer (CMT) driver to follow this > > convention. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Acked-by: Mark Rutland <mark.rutland@arm.com> > > > > --- > > * I plan to follow up with patches to use these new bindings in the > > dtsi files for the affected SoCs. > > > > v2 > > * Reorder compat entries so more-specific entries and their fallbacks > > are grouped with the fallback entry coming last. > > * Explicitly document fallback > > --- > > .../devicetree/bindings/timer/renesas,cmt.txt | 44 ++++++++++++++++--- > > 1 file changed, 38 insertions(+), 6 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > b/Documentation/devicetree/bindings/timer/renesas,cmt.txt index > > a17418b..7b44f4b 100644 > > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.txt > > @@ -11,15 +11,47 @@ datasheets. > > > > Required Properties: > > > > - - compatible: must contain one of the following. > > - - "renesas,cmt-32" for the 32-bit CMT > > + - compatible: must contain one or more of the following: > > + - "renesas,cmt-32-r8a7740" for the R8a7740 32-bit CMT > > s/R8a7740/R8A7740/ > > > + (CMT0) > > + - "renesas,cmt-32-sh7372" for the SH7372 32-bit CMT > > + (CMT0) > > + - "renesas,cmt-32-sh73a0" for the SH73a0 32-bit CMT > > s/SH73a0/SH73A0/ Thanks, I have decided to go for lower case instead. That is consistent with other nearby usage in the same file. [snip] ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 2/3] clocksource: sh_mtu2: Document r7s72100 binding 2014-09-04 0:55 [PATCH v2 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman 2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman @ 2014-09-04 0:55 ` Simon Horman 2014-09-04 0:55 ` [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman 2 siblings, 0 replies; 9+ messages in thread From: Simon Horman @ 2014-09-04 0:55 UTC (permalink / raw) To: linux-sh Cc: linux-arm-kernel, Magnus Damm, devicetree, Laurent Pinchart, Geert Uytterhoeven, Mark Rutland, Sergei Shtylyov, Simon Horman In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted. Although not universally liked this convention is used in the bindings for a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Multi-Function Timer Pulse Unit 2 (MTU2) driver to follow this convention. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> --- * I plan to follow up with a patch patch to use the new binding in the dtsi files for the r7s72100 SoC. v2 * Suggestions by Mark Rutland and Sergei Shtylyov - Compatible strings should be "one or more" not "one" of those listed - Describe the generic binding as covering any MTU2 device - Re-order compat strings from most to least specific --- Documentation/devicetree/bindings/timer/renesas,mtu2.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/renesas,mtu2.txt b/Documentation/devicetree/bindings/timer/renesas,mtu2.txt index 917453f..defe2a1 100644 --- a/Documentation/devicetree/bindings/timer/renesas,mtu2.txt +++ b/Documentation/devicetree/bindings/timer/renesas,mtu2.txt @@ -8,7 +8,9 @@ are independent. The MTU2 hardware supports five channels indexed from 0 to 4. Required Properties: - - compatible: must contain "renesas,mtu2" + - compatible: must be one or more of the following: + - "renesas,mtu2-r7s72100" for R7S72100 MTU2 + - "renesas,mtu2" for any MTU2 - reg: base address and length of the registers block for the timer module. @@ -26,7 +28,7 @@ Required Properties: Example: R7S72100 (RZ/A1H) MTU2 node mtu2: timer@fcff0000 { - compatible = "renesas,mtu2"; + compatible = "renesas,mtu2-r7s72100", "renesas,mtu2"; reg = <0xfcff0000 0x400>; interrupts = <0 139 IRQ_TYPE_LEVEL_HIGH>, <0 146 IRQ_TYPE_LEVEL_HIGH>, -- 2.0.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding 2014-09-04 0:55 [PATCH v2 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman 2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman 2014-09-04 0:55 ` [PATCH v2 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman @ 2014-09-04 0:55 ` Simon Horman 2014-09-04 7:00 ` Laurent Pinchart 2 siblings, 1 reply; 9+ messages in thread From: Simon Horman @ 2014-09-04 0:55 UTC (permalink / raw) To: linux-sh Cc: linux-arm-kernel, Magnus Damm, devicetree, Laurent Pinchart, Geert Uytterhoeven, Mark Rutland, Sergei Shtylyov, Simon Horman In general Renesas hardware is not documented to the extent where the relationship between IP blocks on different SoCs can be assumed although they may appear to operate the same way. Furthermore the documentation typically does not specify a version for individual IP blocks. For these reasons a convention of using the SoC name in place of a version and providing SoC-specific compat strings has been adopted. Although not universally liked this convention is used in the bindings for a number of drivers for Renesas hardware. The purpose of this patch is to update the Renesas R-Car Timer Unit (TMU) driver to follow this convention. Signed-off-by: Simon Horman <horms+renesas@verge.net.au> Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> --- * I plan to follow up with a patch patch to use the new binding in the dtsi files for the r8a7779 SoC. commit 471269b790aec03385dc4fb127ed7094ff83c16d v2 * Suggestions by Mark Rutland and Sergei Shtylyov - Compatible strings should be "one or more" not "one" of those listed - Describe the generic binding as covering any MTU2 device - Re-order compat strings from most to least specific --- Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt b/Documentation/devicetree/bindings/timer/renesas,tmu.txt index 425d0c5..f9a9545 100644 --- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt @@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three channels. Required Properties: - - compatible: must contain "renesas,tmu" + - compatible: must contain one or more of the following: + - "renesas,tmu-r8a7779" R8A7779 TMU + - "renesas,tmu" any TMU - reg: base address and length of the registers block for the timer module. @@ -27,7 +29,7 @@ Optional Properties: Example: R8A7779 (R-Car H1) TMU0 node tmu0: timer@ffd80000 { - compatible = "renesas,tmu"; + compatible = "renesas,tmu-r8a7779", "renesas,tmu"; reg = <0xffd80000 0x30>; interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>, <0 33 IRQ_TYPE_LEVEL_HIGH>, -- 2.0.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding 2014-09-04 0:55 ` [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman @ 2014-09-04 7:00 ` Laurent Pinchart 2014-09-06 1:21 ` Simon Horman 0 siblings, 1 reply; 9+ messages in thread From: Laurent Pinchart @ 2014-09-04 7:00 UTC (permalink / raw) To: Simon Horman, Geert Uytterhoeven Cc: linux-sh, linux-arm-kernel, Magnus Damm, devicetree, Mark Rutland, Sergei Shtylyov Hi Simon, Thank you for the patch. On Thursday 04 September 2014 09:55:21 Simon Horman wrote: > In general Renesas hardware is not documented to the extent > where the relationship between IP blocks on different SoCs can be assumed > although they may appear to operate the same way. Furthermore the > documentation typically does not specify a version for individual > IP blocks. For these reasons a convention of using the SoC name in place > of a version and providing SoC-specific compat strings has been adopted. > > Although not universally liked this convention is used in the bindings > for a number of drivers for Renesas hardware. The purpose of this patch is > to update the Renesas R-Car Timer Unit (TMU) driver to follow this > convention. > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > --- > * I plan to follow up with a patch patch to use the new binding in the > dtsi files for the r8a7779 SoC. > commit 471269b790aec03385dc4fb127ed7094ff83c16d > > v2 > * Suggestions by Mark Rutland and Sergei Shtylyov > - Compatible strings should be "one or more" not "one" of those listed > - Describe the generic binding as covering any MTU2 device > - Re-order compat strings from most to least specific > --- > Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt > b/Documentation/devicetree/bindings/timer/renesas,tmu.txt index > 425d0c5..f9a9545 100644 > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt > @@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three > channels. > > Required Properties: > > - - compatible: must contain "renesas,tmu" > + - compatible: must contain one or more of the following: > + - "renesas,tmu-r8a7779" R8A7779 TMU > + - "renesas,tmu" any TMU How about matching the wording of patch 1/3 with - "renesas,tmu-r8a7779" for the R8A7779 TMU - "renesas,tmu" for any TMU. This is a fallback for the above renesas,tmu-* entries Same comment for patch 2/3. With this change, Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > - reg: base address and length of the registers block for the timer > module. > > @@ -27,7 +29,7 @@ Optional Properties: > Example: R8A7779 (R-Car H1) TMU0 node > > tmu0: timer@ffd80000 { > - compatible = "renesas,tmu"; > + compatible = "renesas,tmu-r8a7779", "renesas,tmu"; > reg = <0xffd80000 0x30>; > interrupts = <0 32 IRQ_TYPE_LEVEL_HIGH>, > <0 33 IRQ_TYPE_LEVEL_HIGH>, -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding 2014-09-04 7:00 ` Laurent Pinchart @ 2014-09-06 1:21 ` Simon Horman 0 siblings, 0 replies; 9+ messages in thread From: Simon Horman @ 2014-09-06 1:21 UTC (permalink / raw) To: Laurent Pinchart Cc: Geert Uytterhoeven, linux-sh, linux-arm-kernel, Magnus Damm, devicetree, Mark Rutland, Sergei Shtylyov On Thu, Sep 04, 2014 at 10:00:03AM +0300, Laurent Pinchart wrote: > Hi Simon, > > Thank you for the patch. > > On Thursday 04 September 2014 09:55:21 Simon Horman wrote: > > In general Renesas hardware is not documented to the extent > > where the relationship between IP blocks on different SoCs can be assumed > > although they may appear to operate the same way. Furthermore the > > documentation typically does not specify a version for individual > > IP blocks. For these reasons a convention of using the SoC name in place > > of a version and providing SoC-specific compat strings has been adopted. > > > > Although not universally liked this convention is used in the bindings > > for a number of drivers for Renesas hardware. The purpose of this patch is > > to update the Renesas R-Car Timer Unit (TMU) driver to follow this > > convention. > > > > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > --- > > * I plan to follow up with a patch patch to use the new binding in the > > dtsi files for the r8a7779 SoC. > > commit 471269b790aec03385dc4fb127ed7094ff83c16d > > > > v2 > > * Suggestions by Mark Rutland and Sergei Shtylyov > > - Compatible strings should be "one or more" not "one" of those listed > > - Describe the generic binding as covering any MTU2 device > > - Re-order compat strings from most to least specific > > --- > > Documentation/devicetree/bindings/timer/renesas,tmu.txt | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/timer/renesas,tmu.txt > > b/Documentation/devicetree/bindings/timer/renesas,tmu.txt index > > 425d0c5..f9a9545 100644 > > --- a/Documentation/devicetree/bindings/timer/renesas,tmu.txt > > +++ b/Documentation/devicetree/bindings/timer/renesas,tmu.txt > > @@ -8,7 +8,9 @@ are independent. The TMU hardware supports up to three > > channels. > > > > Required Properties: > > > > - - compatible: must contain "renesas,tmu" > > + - compatible: must contain one or more of the following: > > + - "renesas,tmu-r8a7779" R8A7779 TMU > > + - "renesas,tmu" any TMU > > How about matching the wording of patch 1/3 with > > - "renesas,tmu-r8a7779" for the R8A7779 TMU > - "renesas,tmu" for any TMU. > This is a fallback for the above renesas,tmu-* entries > > Same comment for patch 2/3. > > With this change, > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Thanks, will do. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-09-06 1:21 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-09-04 0:55 [PATCH v2 0/3] clocksource: Document Renesas SoC specific bindings Simon Horman 2014-09-04 0:55 ` [PATCH v2 1/3] clocksource: sh_cmt: Document " Simon Horman 2014-09-04 6:51 ` Laurent Pinchart 2014-09-04 6:58 ` Laurent Pinchart 2014-09-06 1:14 ` Simon Horman 2014-09-04 0:55 ` [PATCH v2 2/3] clocksource: sh_mtu2: Document r7s72100 binding Simon Horman 2014-09-04 0:55 ` [PATCH v2 3/3] clocksource: sh_tmu: Document r8a7779 binding Simon Horman 2014-09-04 7:00 ` Laurent Pinchart 2014-09-06 1:21 ` Simon Horman
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).