From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65709C77B61 for ; Sat, 8 Apr 2023 12:12:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230166AbjDHMMS (ORCPT ); Sat, 8 Apr 2023 08:12:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbjDHMMR (ORCPT ); Sat, 8 Apr 2023 08:12:17 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 251C8EF8B; Sat, 8 Apr 2023 05:12:16 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id jg21so2092863ejc.2; Sat, 08 Apr 2023 05:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680955934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gsp6bAaqdkC+3l7L0QU9gWWFuWF86YUu16J9MyhyV3E=; b=Vzms7iQnafiqUkeMs1GMmPsw583bn+6RhHpsqKO6zfkfU10NzcwiOfy+EMZesNx5vb W+YGKbjYybKIxFFaYXDNotsBdrMm6NKOWtzAu6Yvjv3USDondpL9Ns2QsTGtrVTgd0Wg stS2FNX2Z3XSzrNDITuRIme9HfeIEahuuNLWvC06exD1Qjg1lv9/wjHLnb+arT4M2mtH g8w9lhCldDRNFrIV5VY1w98FYZKIwEDJqt0SUy2epVSqNrUkcsKdQfGAsgRMuDcVrFBi dhkdgQDTnRXFVF3EEBUsF5hphK0cX6AdpsOQoyHLUCyAiZ4sEQgNlvshf4rmgrD1cXEI ReZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680955934; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gsp6bAaqdkC+3l7L0QU9gWWFuWF86YUu16J9MyhyV3E=; b=gpC7K420jcdGH4IlShNAaTX7c2ALQW9nsYOeR3UtYMiB4wcNFX5DW7xMQrxY4X3Jte pvPH6rDPGiDM6ovy+HJGkDFZgZsp4zIP/I+SIUMRuMgOyjQt/MdtaJ0rHPd55KWDCvW7 1wSZ6KK4qRrHdOmwS8XmcVaSln+fZxApwGCROQFqNzaRO11s66VNQBj9tlwhp9TS7AhY WLEmAi4xTsE5H/ZNyUNVM8+64a48sunD1oMR5J38lHPUHEBdYvpaptKdn4OmyUPoUudd feVvvTyPY7g0FUKSp/Gvq5Gdk9V+VQKzeFfTdqKQhIbsXgt2advGKQ22h9pIQk6lpoYm AMvg== X-Gm-Message-State: AAQBX9c8WXsQ0xIcQHvzvztMVFPFlja2W4Qhz0kAN1k7YP09YJodlKbo NO/GTWJJ8ic1oUMLoE6+2T4= X-Google-Smtp-Source: AKy350ZoljWQmJaFYZYXyiATILTnWWThGxROLCrvBR/uFCN9linJDLlNU8p8TFP9b2zvbHhV1DPxfg== X-Received: by 2002:a17:907:e91:b0:920:254c:1e2d with SMTP id ho17-20020a1709070e9100b00920254c1e2dmr2670313ejc.39.1680955934385; Sat, 08 Apr 2023 05:12:14 -0700 (PDT) Received: from jernej-laptop.localnet (89-212-118-115.static.t-2.net. [89.212.118.115]) by smtp.gmail.com with ESMTPSA id m2-20020a1709062ac200b008b176df2899sm3072135eje.160.2023.04.08.05.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 05:12:13 -0700 (PDT) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: Greg Kroah-Hartman , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Heiko Stuebner , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Nicolas Frattaroli , Cristian Ciocaltea Cc: linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-riscv@lists.infradead.org, kernel@collabora.com Subject: Re: [PATCH v2 02/10] ARM: dts: sun6i: a31: Switch dma-names order for snps,dw-apb-uart nodes Date: Sat, 08 Apr 2023 14:12:12 +0200 Message-ID: <7505967.EvYhyI6sBW@jernej-laptop> In-Reply-To: <20230321215624.78383-3-cristian.ciocaltea@collabora.com> References: <20230321215624.78383-1-cristian.ciocaltea@collabora.com> <20230321215624.78383-3-cristian.ciocaltea@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Dne torek, 21. marec 2023 ob 22:56:16 CEST je Cristian Ciocaltea napisal(a): > Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma & > dma-names properties") documented dma-names property to handle Allwinner > D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the > reverse of what a bunch of different boards expect. > > The initial proposed solution was to allow a flexible dma-names order in > the binding, due to potential ABI breakage concerns after fixing the DTS > files. But luckily the Allwinner boards are not affected, since they are > using a shared DMA channel for rx and tx. > > Hence, the first step in fixing the inconsistency was to change > dma-names order in the binding to tx->rx. > > Do the same for the snps,dw-apb-uart nodes in the DTS file. > > Signed-off-by: Cristian Ciocaltea Acked-by: Jernej Skrabec Best regards, Jernej > --- > arch/arm/boot/dts/sun6i-a31.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi > b/arch/arm/boot/dts/sun6i-a31.dtsi index 6cdadba6a3ac..5cce4918f84c 100644 > --- a/arch/arm/boot/dts/sun6i-a31.dtsi > +++ b/arch/arm/boot/dts/sun6i-a31.dtsi > @@ -822,7 +822,7 @@ uart0: serial@1c28000 { > clocks = <&ccu CLK_APB2_UART0>; > resets = <&ccu RST_APB2_UART0>; > dmas = <&dma 6>, <&dma 6>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -835,7 +835,7 @@ uart1: serial@1c28400 { > clocks = <&ccu CLK_APB2_UART1>; > resets = <&ccu RST_APB2_UART1>; > dmas = <&dma 7>, <&dma 7>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -848,7 +848,7 @@ uart2: serial@1c28800 { > clocks = <&ccu CLK_APB2_UART2>; > resets = <&ccu RST_APB2_UART2>; > dmas = <&dma 8>, <&dma 8>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -861,7 +861,7 @@ uart3: serial@1c28c00 { > clocks = <&ccu CLK_APB2_UART3>; > resets = <&ccu RST_APB2_UART3>; > dmas = <&dma 9>, <&dma 9>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -874,7 +874,7 @@ uart4: serial@1c29000 { > clocks = <&ccu CLK_APB2_UART4>; > resets = <&ccu RST_APB2_UART4>; > dmas = <&dma 10>, <&dma 10>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > }; > > @@ -887,7 +887,7 @@ uart5: serial@1c29400 { > clocks = <&ccu CLK_APB2_UART5>; > resets = <&ccu RST_APB2_UART5>; > dmas = <&dma 22>, <&dma 22>; > - dma-names = "rx", "tx"; > + dma-names = "tx", "rx"; > status = "disabled"; > };