From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C995C433EF for ; Wed, 6 Apr 2022 12:54:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231262AbiDFM4G (ORCPT ); Wed, 6 Apr 2022 08:56:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231477AbiDFMzw (ORCPT ); Wed, 6 Apr 2022 08:55:52 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D51A2F8FD1 for ; Wed, 6 Apr 2022 01:57:24 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id bh17so2808905ejb.8 for ; Wed, 06 Apr 2022 01:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7oGdqe4edvqr+iYfJInFHVmb7+U6NUbqblozp3XrpQg=; b=i+U889ubHp/vqD39N9mGHzSBxDkleyQwz/NKD0dqRtQCXOhQn3Be6msm33/4hP8WDQ z//23cjvUb+fkkceiSyT7T08AqIo5FDX3UurpydepsVA13l5Tghgh949AbE1vo/0vpMS MunVwbnQlqlray9rykp3K4cZu09MwZYvYgxR7ZLSaXY0RdRxmlrb94cBBclWn8AZLD+I GklRqWwbXTQebvLfyShnONpxJdDb4dEZplwAwS55peWNy77EAcMiCpeHmX5qK+U30fnQ MkpxHFM8PcP5yg0wFjXJWB4ONKi+TXcIZ6EE3CVbb9yyWs+LFbKmQMKadXfJWkgtGIiH 2QNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7oGdqe4edvqr+iYfJInFHVmb7+U6NUbqblozp3XrpQg=; b=YkVV5+Z9JiF7dfK8Ef3JIJEOOtPW6L8o4QEVJHNtl1ZS7//xdyJC/JMb2xUlwpQVpv kyCBeXXQM4nFML8EvqKkLJZj4EZ+igPUfZeMQVsaHwBPCED77FObi2/a9PlyswngrjTx wwH07yTDWxXOLtASN0ShEEDj8U+U3xtFXJDNU4GkqgxcWXqyLr4nCHxP2bm2EJbdB2iE bob6YBu6RKdOxViMlzktnb5N74ZG4KjJiawWsVrtwoqw1U98/4NPVHJSR2e7HpkZApyT mY8DRzAhZtMslXXa7kinXvMLOb230PwU0XIyDzZ7EvLlYvlhlpm8f345RaHljuWNTCzu /w6g== X-Gm-Message-State: AOAM5310oD2lfTrijx5IjPHW0JWkC8wl6B9XHwKH0ErmE3aNDGbso+YJ 6sSCTkDZbyiy3mpNyni972eGGQ== X-Google-Smtp-Source: ABdhPJw2YtGOMiUak58GFk63SIktW16kDe4il6YrYPXGz8jzb5j689+r7WfODo7WQ8xkLk7+CqqeKg== X-Received: by 2002:a17:906:698a:b0:6ce:b983:babf with SMTP id i10-20020a170906698a00b006ceb983babfmr7573228ejr.553.1649235442532; Wed, 06 Apr 2022 01:57:22 -0700 (PDT) Received: from [192.168.0.183] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id c4-20020a170906340400b006d077e850b5sm6331152ejb.23.2022.04.06.01.57.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 01:57:22 -0700 (PDT) Message-ID: <750c1f9e-6a53-16d5-390e-f9f81fa23afd@linaro.org> Date: Wed, 6 Apr 2022 10:57:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 04/14] dt-bindings: arm: mediatek: document WED binding for MT7622 Content-Language: en-US To: Felix Fietkau , Arnd Bergmann Cc: Networking , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi , DTML , Linux ARM , "moderated list:ARM/Mediatek SoC..." , Linux Kernel Mailing List References: <20220405195755.10817-1-nbd@nbd.name> <20220405195755.10817-5-nbd@nbd.name> <08883cf4-27b9-30bf-bd27-9391b763417c@nbd.name> From: Krzysztof Kozlowski In-Reply-To: <08883cf4-27b9-30bf-bd27-9391b763417c@nbd.name> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/04/2022 10:32, Felix Fietkau wrote: > On 06.04.22 10:29, Arnd Bergmann wrote: >> On Wed, Apr 6, 2022 at 10:18 AM Felix Fietkau >> wrote: >>> On 06.04.22 10:09, Krzysztof Kozlowski wrote: >>>> On 05/04/2022 21:57, Felix Fietkau wrote: >>>>> From: Lorenzo Bianconi >>>>> >>>>> Document the binding for the Wireless Ethernet Dispatch core >>>>> on the MT7622 SoC, which is used for Ethernet->WLAN >>>>> offloading Add related info in mediatek-net bindings. >>>>> >>>>> Signed-off-by: Lorenzo Bianconi >>>>> Signed-off-by: Felix Fietkau >>>> >>>> Thank you for your patch. There is something to >>>> discuss/improve. >>>> >>>>> --- .../arm/mediatek/mediatek,mt7622-wed.yaml | 50 >>>>> +++++++++++++++++++ >>>>> .../devicetree/bindings/net/mediatek-net.txt | 2 + 2 files >>>>> changed, 52 insertions(+) create mode 100644 >>>>> Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml >>>> >>>> >>>>> Don't store drivers in arm directory. See: >>>> https://lore.kernel.org/linux-devicetree/YkJa1oLSEP8R4U6y@robh.at.kernel.org/ >>>> >>>> >>>> Isn't this a network offload engine? If yes, then probably it should be >>>> in "net/". >>> It's not a network offload engine by itself. It's a SoC component >>> that connects to the offload engine and controls a MTK PCIe WLAN >>> device, intercepting interrupts and DMA rings in order to be able >>> to inject packets coming in from the offload engine. Do you think >>> it still belongs in net, or maybe in soc instead? >> >> I think it belongs into drivers/net/. Presumably this has some kind >> of user interface to configure which packets are forwarded? I would >> not want to maintain that in a SoC driver as this clearly needs to >> communicate with both of the normal network devices in some form. > The WLAN driver attaches to WED in order to deal with the intercepted > DMA rings, but other than that, WED itself has no user > configuration. Offload is controlled by the PPE code in the ethernet > driver (which is already upstream), and WED simply provides a > destination port for PPE, which allows packets to flow to the > wireless device. Thanks for clarification. I still wonder about the missing drivers as I responded to your second bindings: https://lore.kernel.org/all/20220405195755.10817-1-nbd@nbd.name/T/#m6d108c644f0c05cd12c05e56abe2ef75760c6cef Both of these compatibles - WED and PCIe - are not actually used. Now everything is done inside your Ethernet driver which pokes WED and PCIe-mirror address space via regmap/syscon. Separate bindings might have sense if WED/PCIe mirror were ever converted to real drivers. Best regards, Krzysztof