From: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Matti Vaittinen <mazziesaccount@gmail.com>,
Paul Gazzillo <paul@pgazz.com>, Matt Ranostay <matt@ranostay.sg>,
Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] iio: light: Add support for APDS9306 Light Sensor
Date: Fri, 27 Oct 2023 23:29:08 +1030 [thread overview]
Message-ID: <7524a9ef-c1c4-462e-8f9d-fc03c29ca092@tweaklogic.com> (raw)
In-Reply-To: <ZTuuUl0PBklbVjb9@smile.fi.intel.com>
On 27/10/23 23:04, Andy Shevchenko wrote:
> This will benefit from guard() or scoped_guard().
> And many other functions in your driver.
> I believe ~15% of LoCs can be dropped with help of cleanup.h.
Acknowledging all other comments. Jonathan commented earlier on using guard() and cleanup.h
Unfortunately I missed it. Like GTS, it will again be a brand new thing to understand!
Thank you for reviewing.
Regards,
Subhajit Ghosh
next prev parent reply other threads:[~2023-10-27 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 14:35 [PATCH v1 0/2] Support for Avago APDS9306 Ambient Light Sensor Subhajit Ghosh
2023-10-26 14:35 ` [PATCH v1 1/2] dt-bindings: iio: light: Avago APDS9306 Subhajit Ghosh
2023-10-27 14:26 ` Conor Dooley
2023-10-26 14:35 ` [PATCH v1 2/2] iio: light: Add support for APDS9306 Light Sensor Subhajit Ghosh
2023-10-27 3:26 ` kernel test robot
2023-10-27 10:49 ` Matti Vaittinen
2023-10-27 11:21 ` Subhajit Ghosh
2023-10-27 12:34 ` Andy Shevchenko
2023-10-27 12:59 ` Subhajit Ghosh [this message]
2023-10-27 13:20 ` Subhajit Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7524a9ef-c1c4-462e-8f9d-fc03c29ca092@tweaklogic.com \
--to=subhajit.ghosh@tweaklogic.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@ranostay.sg \
--cc=mazziesaccount@gmail.com \
--cc=paul@pgazz.com \
--cc=robh+dt@kernel.org \
--cc=stefan.windfeldt-prytz@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).