From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Cixi Geng <gengcixi@gmail.com>,
lee.jones@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, orsonzhai@gmail.com,
baolin.wang7@gmail.com, zhang.lyra@gmail.com,
mturquette@baylibre.com, sboyd@kernel.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH V6 0/2] Add ums512 clocks and relative bindings file
Date: Tue, 26 Jul 2022 19:47:15 +0200 [thread overview]
Message-ID: <7555b0ca-2028-dba9-9950-ca0d21c2863c@linaro.org> (raw)
In-Reply-To: <20220726102404.564498-1-gengcixi@gmail.com>
On 26/07/2022 12:24, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> This patchset is add the UMS512 clocks support
>
> v2 changes:
> adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd"
> compatibles to fix match failed logs in the dt_binding_check.
> add the property license and copyright notice.
>
> v3 changes:
> fix wrong indentation and hint: "maxItems" is not needed with an "items"
> list when use the latest dtschema.
>
> v4 changes:
> move the syscon bindins from clk to glbreg yaml file by pickup
> chunyan's patch for global registers bindings
> fix the comments from Krzysztof in v3 patchset
> add the Acked-by: Krzysztof in patch v4 3/4
> fix the warning Prefer "GPL" over "GPL v2"
>
> v5 changes:
> Add review tags.
> fix the comments in ums512-glbreg.yaml.
>
> v6 changes:
> No more send the patch 1/4 and 3/4 in V5 for applied by Stephen
> change GPL to GPL v2 license
> fix the lack of space in some "{" and "}"
> add check error for sprd_clk_regmap_init.
That's not good. That was a dependency here (for MFD bindings). You must
describe the dependencies in cover letter so maintainers know how to do it.
Your MFD patch is not applicable now...
Best regards,
Krzysztof
prev parent reply other threads:[~2022-07-26 17:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-26 10:24 [PATCH V6 0/2] Add ums512 clocks and relative bindings file Cixi Geng
2022-07-26 10:24 ` [PATCH V6 1/2] dt-bindings: mfd: sprd: Add bindings for ums512 global registers Cixi Geng
2022-07-26 13:51 ` Rob Herring
2022-07-26 17:45 ` Krzysztof Kozlowski
2022-07-26 17:48 ` Krzysztof Kozlowski
2022-07-27 1:38 ` Cixi Geng
2022-07-26 10:24 ` [PATCH V6 2/2] clk: sprd: Add clocks support for UMS512 Cixi Geng
2022-07-26 17:47 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7555b0ca-2028-dba9-9950-ca0d21c2863c@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=baolin.wang7@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gengcixi@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee.jones@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).