From: Krzysztof Kozlowski <krzk@kernel.org>
To: xianwei.zhao@amlogic.com, Yiting Deng <yiting.deng@amlogic.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-amlogic@lists.infradead.org, linux-rtc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] rtc: support for the Amlogic on-chip RTC
Date: Tue, 3 Sep 2024 16:04:25 +0200 [thread overview]
Message-ID: <7560bdd0-aafc-4c6a-b5a8-f50e9aa3124b@kernel.org> (raw)
In-Reply-To: <20240903-rtc-v2-2-05da5755b8d9@amlogic.com>
On 03/09/2024 09:00, Xianwei Zhao via B4 Relay wrote:
> From: Yiting Deng <yiting.deng@amlogic.com>
>
...
> + rtc->map = devm_regmap_init_mmio(&pdev->dev, base, &aml_rtc_regmap_config);
> + if (IS_ERR(rtc->map)) {
> + dev_err_probe(&pdev->dev, PTR_ERR(rtc->map), "regmap init failed\n");
> + return PTR_ERR(rtc->map);
Nothing improved. Read the comment. Use git grep to see how this is done
if the comment is somehow unclear.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-03 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 7:00 [PATCH v2 0/3] support for amlogic rtc Xianwei Zhao via B4 Relay
2024-09-03 7:00 ` [PATCH v2 1/3] dt-bindings: rtc: Add Amlogic A4 and A5 rtc Xianwei Zhao via B4 Relay
2024-09-03 14:03 ` Krzysztof Kozlowski
2024-09-04 8:18 ` Xianwei Zhao
2024-09-03 7:00 ` [PATCH v2 2/3] rtc: support for the Amlogic on-chip RTC Xianwei Zhao via B4 Relay
2024-09-03 14:04 ` Krzysztof Kozlowski [this message]
2024-09-04 8:44 ` Xianwei Zhao
2024-09-03 7:00 ` [PATCH v2 3/3] MAINTAINERS: Add an entry for Amlogic RTC driver Xianwei Zhao via B4 Relay
2024-09-03 14:05 ` Krzysztof Kozlowski
2024-09-04 8:50 ` Xianwei Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7560bdd0-aafc-4c6a-b5a8-f50e9aa3124b@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=xianwei.zhao@amlogic.com \
--cc=yiting.deng@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).