* [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema
@ 2024-03-26 12:17 Animesh Agarwal
2024-03-26 12:25 ` Damien Le Moal
2024-03-26 18:14 ` Conor Dooley
0 siblings, 2 replies; 5+ messages in thread
From: Animesh Agarwal @ 2024-03-26 12:17 UTC (permalink / raw)
Cc: animeshagarwal28, Damien Le Moal, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-ide, devicetree,
linux-kernel
Convert the ahci-da850 bindings to DT schema
Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
---
.../devicetree/bindings/ata/ahci-da850.txt | 18 ----------
.../bindings/ata/ti,da850-ahci.yaml | 36 +++++++++++++++++++
2 files changed, 36 insertions(+), 18 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt
create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt
deleted file mode 100644
index 5f8193417725..000000000000
--- a/Documentation/devicetree/bindings/ata/ahci-da850.txt
+++ /dev/null
@@ -1,18 +0,0 @@
-Device tree binding for the TI DA850 AHCI SATA Controller
----------------------------------------------------------
-
-Required properties:
- - compatible: must be "ti,da850-ahci"
- - reg: physical base addresses and sizes of the two register regions
- used by the controller: the register map as defined by the
- AHCI 1.1 standard and the Power Down Control Register (PWRDN)
- for enabling/disabling the SATA clock receiver
- - interrupts: interrupt specifier (refer to the interrupt binding)
-
-Example:
-
- sata: sata@218000 {
- compatible = "ti,da850-ahci";
- reg = <0x218000 0x2000>, <0x22c018 0x4>;
- interrupts = <67>;
- };
diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
new file mode 100644
index 000000000000..d54f58c12e78
--- /dev/null
+++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI DA850 AHCI SATA Controller
+
+maintainers:
+ - Animesh Agarwal <animeshagarwal28@gmail.com>
+
+properties:
+ compatible:
+ const: ti,da850-ahci
+
+ reg:
+ minItems: 2
+ maxItems: 2
+
+ interrupts:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ sata@218000 {
+ compatible = "ti,da850-ahci";
+ reg = <0x218000 0x2000>, <0x22c018 0x4>;
+ interrupts = <67>;
+ };
--
2.44.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema
2024-03-26 12:17 [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema Animesh Agarwal
@ 2024-03-26 12:25 ` Damien Le Moal
2024-03-27 4:54 ` Animesh Agarwal
2024-03-26 18:14 ` Conor Dooley
1 sibling, 1 reply; 5+ messages in thread
From: Damien Le Moal @ 2024-03-26 12:25 UTC (permalink / raw)
To: Animesh Agarwal
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-ide,
devicetree, linux-kernel
On 3/26/24 21:17, Animesh Agarwal wrote:
> Convert the ahci-da850 bindings to DT schema
Missing a period at the end of the sentence.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
> .../devicetree/bindings/ata/ahci-da850.txt | 18 ----------
> .../bindings/ata/ti,da850-ahci.yaml | 36 +++++++++++++++++++
> 2 files changed, 36 insertions(+), 18 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt
> create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt
> deleted file mode 100644
> index 5f8193417725..000000000000
> --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -Device tree binding for the TI DA850 AHCI SATA Controller
> ----------------------------------------------------------
> -
> -Required properties:
> - - compatible: must be "ti,da850-ahci"
> - - reg: physical base addresses and sizes of the two register regions
> - used by the controller: the register map as defined by the
> - AHCI 1.1 standard and the Power Down Control Register (PWRDN)
> - for enabling/disabling the SATA clock receiver
> - - interrupts: interrupt specifier (refer to the interrupt binding)
> -
> -Example:
> -
> - sata: sata@218000 {
> - compatible = "ti,da850-ahci";
> - reg = <0x218000 0x2000>, <0x22c018 0x4>;
> - interrupts = <67>;
> - };
> diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> new file mode 100644
> index 000000000000..d54f58c12e78
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> @@ -0,0 +1,36 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DA850 AHCI SATA Controller
> +
> +maintainers:
> + - Animesh Agarwal <animeshagarwal28@gmail.com>
> +
> +properties:
> + compatible:
> + const: ti,da850-ahci
> +
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + interrupts:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sata@218000 {
> + compatible = "ti,da850-ahci";
> + reg = <0x218000 0x2000>, <0x22c018 0x4>;
> + interrupts = <67>;
> + };
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema
2024-03-26 12:25 ` Damien Le Moal
@ 2024-03-27 4:54 ` Animesh Agarwal
0 siblings, 0 replies; 5+ messages in thread
From: Animesh Agarwal @ 2024-03-27 4:54 UTC (permalink / raw)
To: Damien Le Moal
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, linux-ide,
devicetree, linux-kernel
Sorry for the typo, I'll add it.
On Tue, Mar 26, 2024 at 5:55 PM Damien Le Moal <dlemoal@kernel.org> wrote:
>
> On 3/26/24 21:17, Animesh Agarwal wrote:
> > Convert the ahci-da850 bindings to DT schema
>
> Missing a period at the end of the sentence.
>
> >
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > ---
> > .../devicetree/bindings/ata/ahci-da850.txt | 18 ----------
> > .../bindings/ata/ti,da850-ahci.yaml | 36 +++++++++++++++++++
> > 2 files changed, 36 insertions(+), 18 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt
> > create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Documentation/devicetree/bindings/ata/ahci-da850.txt
> > deleted file mode 100644
> > index 5f8193417725..000000000000
> > --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt
> > +++ /dev/null
> > @@ -1,18 +0,0 @@
> > -Device tree binding for the TI DA850 AHCI SATA Controller
> > ----------------------------------------------------------
> > -
> > -Required properties:
> > - - compatible: must be "ti,da850-ahci"
> > - - reg: physical base addresses and sizes of the two register regions
> > - used by the controller: the register map as defined by the
> > - AHCI 1.1 standard and the Power Down Control Register (PWRDN)
> > - for enabling/disabling the SATA clock receiver
> > - - interrupts: interrupt specifier (refer to the interrupt binding)
> > -
> > -Example:
> > -
> > - sata: sata@218000 {
> > - compatible = "ti,da850-ahci";
> > - reg = <0x218000 0x2000>, <0x22c018 0x4>;
> > - interrupts = <67>;
> > - };
> > diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> > new file mode 100644
> > index 000000000000..d54f58c12e78
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> > @@ -0,0 +1,36 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: TI DA850 AHCI SATA Controller
> > +
> > +maintainers:
> > + - Animesh Agarwal <animeshagarwal28@gmail.com>
> > +
> > +properties:
> > + compatible:
> > + const: ti,da850-ahci
> > +
> > + reg:
> > + minItems: 2
> > + maxItems: 2
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + sata@218000 {
> > + compatible = "ti,da850-ahci";
> > + reg = <0x218000 0x2000>, <0x22c018 0x4>;
> > + interrupts = <67>;
> > + };
>
> --
> Damien Le Moal
> Western Digital Research
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema
2024-03-26 12:17 [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema Animesh Agarwal
2024-03-26 12:25 ` Damien Le Moal
@ 2024-03-26 18:14 ` Conor Dooley
2024-03-27 4:55 ` Animesh Agarwal
1 sibling, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2024-03-26 18:14 UTC (permalink / raw)
To: Animesh Agarwal
Cc: Damien Le Moal, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-ide, devicetree, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 586 bytes --]
On Tue, Mar 26, 2024 at 05:47:28PM +0530, Animesh Agarwal wrote:
> - - compatible: must be "ti,da850-ahci"
> - - reg: physical base addresses and sizes of the two register regions
> - used by the controller: the register map as defined by the
> - AHCI 1.1 standard and the Power Down Control Register (PWRDN)
> - for enabling/disabling the SATA clock receiver
> + reg:
> + minItems: 2
> + maxItems: 2
Could you make this an items list with a pair of text descriptions
please? The original text binding's text for each can be reused.
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-03-27 4:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-26 12:17 [PATCH] dt-bindings: ata: ahci-da850: Convert to dtschema Animesh Agarwal
2024-03-26 12:25 ` Damien Le Moal
2024-03-27 4:54 ` Animesh Agarwal
2024-03-26 18:14 ` Conor Dooley
2024-03-27 4:55 ` Animesh Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).