From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
linux-arm-msm@vger.kernel.org
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, linux-kernel@vger.kernel.org,
bhupesh.linux@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
Date: Thu, 9 Feb 2023 17:00:03 +0100 [thread overview]
Message-ID: <757804b7-8a63-db1c-afab-3c0c1a602807@kernel.org> (raw)
In-Reply-To: <c122426f-53d5-b5ee-9a15-0a735da4bc29@kernel.org>
On 09/02/2023 16:11, Krzysztof Kozlowski wrote:
> On 08/02/2023 13:27, Bhupesh Sharma wrote:
>> qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
>> Add the debug uart node in sm6115 dtsi file.
>>
>> Cc: Bjorn Andersson <andersson@kernel.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>> ---
>> Changes since v1:
>> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221128171215.1768745-1-bhupesh.sharma@linaro.org/
>> - Addressed Konrad's review comments on v1.
>> - Rebased againt latest linux-next/master which now has the 'qupv3_id_0' node
>> already in the dtsi file, so just add the debug uart node in v2.
>>
>> arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> index 50cb8a82ecd5..3eccfb8c16ce 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> @@ -963,6 +963,15 @@ spi4: spi@4a90000 {
>> status = "disabled";
>> };
>>
>> + uart4: serial@4a90000 {
>> + compatible = "qcom,geni-debug-uart";
>> + reg = <0x04a90000 0x4000>;
>> + clock-names = "se";
>> + clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>;
>> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> + };
>> +
>> i2c5: i2c@4a94000 {
>> compatible = "qcom,geni-i2c";
>> reg = <0x04a94000 0x4000>;
>> @@ -992,7 +1001,6 @@ spi5: spi@4a94000 {
>> dma-names = "tx", "rx";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - status = "disabled";
>
> Why do you enable SPI? The commit msg is not explaining it.
Sent fixup:
https://lore.kernel.org/linux-arm-msm/20230209155831.100066-1-krzysztof.kozlowski@linaro.org/T/#u
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-02-09 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 12:27 [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0 Bhupesh Sharma
2023-02-09 4:22 ` Bjorn Andersson
2023-02-09 15:11 ` Krzysztof Kozlowski
2023-02-09 16:00 ` Krzysztof Kozlowski [this message]
2023-02-09 16:21 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=757804b7-8a63-db1c-afab-3c0c1a602807@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).